Make benchmark link count configurable via environment variable

konard · claude · konard · commit 06da21932f75 · 2025-12-26T15:59:13.000+01:00
- Changed LINK_COUNT from a constant to a lazy static that reads from BENCHMARK_LINK_COUNT env var - Defaults to 10 links for faster PR benchmarks - Set to 1000 links for main/master branch via GitHub Actions workflow - Updated all benchmark code to dereference the lazy static with *LINK_COUNT - Applied cargo fmt to format all Rust code Fixes #11 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -65,6 +65,8 @@ jobs:
           NEO4J_URI: bolt://localhost:7687
           NEO4J_USER: neo4j
           NEO4J_PASSWORD: password
+          # Use 1000 links for main/master branch benchmarks, 10 for pull requests
+          BENCHMARK_LINK_COUNT: ${{ (github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master')) && '1000' || '10' }}
         run: |
           set -o pipefail
           cargo bench --bench bench -- --output-format bencher | tee out.txt
diff --git a/rust/benches/bench.rs b/rust/benches/bench.rs
@@ -1,12 +1,10 @@
 #![feature(allocator_api)]
 
-use {
-    benchmarks::{
-        create_links, delete_links, each_all, each_concrete, each_identity, each_incoming,
-        each_outgoing, update_links,
-    },
-    criterion::{criterion_group, criterion_main},
+use benchmarks::{
+    create_links, delete_links, each_all, each_concrete, each_identity, each_incoming,
+    each_outgoing, update_links,
 };
+use criterion::{criterion_group, criterion_main};
 
 mod benchmarks;
 
diff --git a/rust/benches/benchmarks/create.rs b/rust/benches/benchmarks/create.rs
@@ -1,28 +1,28 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        data::LinkType,
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction, LINK_COUNT},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    data::LinkType,
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction, LINK_COUNT};
+
+use crate::tri;
+
 fn bench<T: LinkType, B: Benched + Doublets<T>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
     mut benched: B,
 ) {
     group.bench_function(id, |bencher| {
         bench!(|fork| as B {
-            for _ in 0..LINK_COUNT {
+            for _ in 0..*LINK_COUNT {
                 let _ = elapsed! {fork.create_point()?};
             }
         })(bencher, &mut benched);
diff --git a/rust/benches/benchmarks/delete.rs b/rust/benches/benchmarks/delete.rs
@@ -1,19 +1,19 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction, LINK_COUNT},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction, LINK_COUNT};
+
+use crate::tri;
+
 fn bench<B: Benched + Doublets<usize>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
@@ -23,11 +23,11 @@ fn bench<B: Benched + Doublets<usize>>(
         bench!(|fork| as B {
             use linksneo4j::BACKGROUND_LINKS;
             // Create additional links beyond background links to delete
-            for _prepare in BACKGROUND_LINKS..BACKGROUND_LINKS + LINK_COUNT {
+            for _prepare in BACKGROUND_LINKS..BACKGROUND_LINKS + *LINK_COUNT {
                 let _ = fork.create_point();
             }
             // Delete the links we just created (in reverse order)
-            for id in (BACKGROUND_LINKS + 1..=BACKGROUND_LINKS + LINK_COUNT).rev() {
+            for id in (BACKGROUND_LINKS + 1..=BACKGROUND_LINKS + *LINK_COUNT).rev() {
                 let _ = elapsed! {fork.delete(id)?};
             }
         })(bencher, &mut benched);
diff --git a/rust/benches/benchmarks/each/all.rs b/rust/benches/benchmarks/each/all.rs
@@ -1,20 +1,20 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        data::{Flow, LinkType},
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    data::{Flow, LinkType},
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction};
+
+use crate::tri;
+
 fn bench<T: LinkType, B: Benched + Doublets<T>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
diff --git a/rust/benches/benchmarks/each/concrete.rs b/rust/benches/benchmarks/each/concrete.rs
@@ -1,20 +1,20 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        data::{Flow, LinksConstants},
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    data::{Flow, LinksConstants},
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction};
+
+use crate::tri;
+
 fn bench<B: Benched + Doublets<usize>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
diff --git a/rust/benches/benchmarks/each/identity.rs b/rust/benches/benchmarks/each/identity.rs
@@ -1,20 +1,20 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        data::{Flow, LinksConstants},
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    data::{Flow, LinksConstants},
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction};
+
+use crate::tri;
+
 fn bench<B: Benched + Doublets<usize>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
diff --git a/rust/benches/benchmarks/each/incoming.rs b/rust/benches/benchmarks/each/incoming.rs
@@ -1,20 +1,20 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        data::{Flow, LinksConstants},
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    data::{Flow, LinksConstants},
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction};
+
+use crate::tri;
+
 fn bench<B: Benched + Doublets<usize>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
diff --git a/rust/benches/benchmarks/each/mod.rs b/rust/benches/benchmarks/each/mod.rs
@@ -4,7 +4,8 @@ mod identity;
 mod incoming;
 mod outgoing;
 
-pub use {
-    all::each_all, concrete::each_concrete, identity::each_identity, incoming::each_incoming,
-    outgoing::each_outgoing,
-};
+pub use all::each_all;
+pub use concrete::each_concrete;
+pub use identity::each_identity;
+pub use incoming::each_incoming;
+pub use outgoing::each_outgoing;
diff --git a/rust/benches/benchmarks/each/outgoing.rs b/rust/benches/benchmarks/each/outgoing.rs
@@ -1,20 +1,20 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        data::{Flow, LinksConstants},
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    data::{Flow, LinksConstants},
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction};
+
+use crate::tri;
+
 fn bench<B: Benched + Doublets<usize>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
diff --git a/rust/benches/benchmarks/mod.rs b/rust/benches/benchmarks/mod.rs
@@ -2,4 +2,7 @@ mod create;
 mod delete;
 mod each;
 mod update;
-pub use {create::create_links, delete::delete_links, each::*, update::update_links};
+pub use create::create_links;
+pub use delete::delete_links;
+pub use each::*;
+pub use update::update_links;
diff --git a/rust/benches/benchmarks/update.rs b/rust/benches/benchmarks/update.rs
@@ -1,19 +1,19 @@
-use {
-    crate::tri,
-    criterion::{measurement::WallTime, BenchmarkGroup, Criterion},
-    doublets::{
-        mem::{Alloc, FileMapped},
-        parts::LinkPart,
-        split::{self, DataPart, IndexPart},
-        unit, Doublets,
-    },
-    linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction, LINK_COUNT},
-    std::{
-        alloc::Global,
-        time::{Duration, Instant},
-    },
+use std::{
+    alloc::Global,
+    time::{Duration, Instant},
 };
 
+use criterion::{measurement::WallTime, BenchmarkGroup, Criterion};
+use doublets::{
+    mem::{Alloc, FileMapped},
+    parts::LinkPart,
+    split::{self, DataPart, IndexPart},
+    unit, Doublets,
+};
+use linksneo4j::{bench, connect, Benched, Client, Exclusive, Fork, Transaction, LINK_COUNT};
+
+use crate::tri;
+
 fn bench<B: Benched + Doublets<usize>>(
     group: &mut BenchmarkGroup<WallTime>,
     id: &str,
@@ -23,7 +23,7 @@ fn bench<B: Benched + Doublets<usize>>(
         bench!(|fork| as B {
             use linksneo4j::BACKGROUND_LINKS;
             // Update the last LINK_COUNT links from background links
-            let start_id = if BACKGROUND_LINKS > LINK_COUNT { BACKGROUND_LINKS - LINK_COUNT + 1 } else { 1 };
+            let start_id = if BACKGROUND_LINKS > *LINK_COUNT { BACKGROUND_LINKS - *LINK_COUNT + 1 } else { 1 };
             for id in start_id..=BACKGROUND_LINKS {
                 let _ = elapsed! {fork.update(id, 0, 0)?};
                 let _ = elapsed! {fork.update(id, id, id)?};
diff --git a/rust/src/benched.rs b/rust/src/benched.rs
@@ -1,15 +1,15 @@
-use {
-    crate::{map_file, Client, Exclusive, Fork, Result, Sql, Transaction},
-    doublets::{
-        data::LinkType,
-        mem::{Alloc, FileMapped},
-        split::{self, DataPart, IndexPart},
-        unit::{self, LinkPart},
-        Doublets,
-    },
-    std::alloc::Global,
+use std::alloc::Global;
+
+use doublets::{
+    data::LinkType,
+    mem::{Alloc, FileMapped},
+    split::{self, DataPart, IndexPart},
+    unit::{self, LinkPart},
+    Doublets,
 };
 
+use crate::{map_file, Client, Exclusive, Fork, Result, Sql, Transaction};
+
 pub trait Benched: Sized {
     type Builder<'params>;
 
diff --git a/rust/src/client.rs b/rust/src/client.rs
diff --git a/rust/src/fork.rs b/rust/src/fork.rs
diff --git a/rust/src/lib.rs b/rust/src/lib.rs
diff --git a/rust/src/transaction.rs b/rust/src/transaction.rs
