Skip to content

Commit 1b69253

Browse files
konardclaude
andcommitted
Fix CI pipeline exit code masking with set -o pipefail
The benchmark command piped to tee was masking the exit code: cargo bench ... | tee out.txt When cargo bench failed with exit code 101, tee succeeded with exit code 0, making the whole pipeline appear successful. This caused: - False success status on CI runs where benchmarks actually failed - Subsequent steps running despite benchmark failures - Broken benchmark results being committed to main Solution: Add 'set -o pipefail' to ensure the pipeline returns the exit code of the first failing command, making CI properly fail when benchmarks fail. Fixes part of #5 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent a5bfd7d commit 1b69253

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/rust.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ jobs:
5757
NEO4J_URI: bolt://localhost:7687
5858
NEO4J_USER: neo4j
5959
NEO4J_PASSWORD: password
60-
run: cargo bench --bench bench -- --output-format bencher | tee out.txt
60+
run: |
61+
set -o pipefail
62+
cargo bench --bench bench -- --output-format bencher | tee out.txt
6163
6264
- name: Prepare benchmark results
6365
run: |

0 commit comments

Comments
 (0)