Addressed PR comments

Author: ezilber-akamai

plugins/modules/image_share_group_token.py

@@ -138,16 +138,28 @@ def _create(self) -> Optional[ImageShareGroupToken]:
 
     def _handle_present(self) -> None:
         label = self.module.params.get("label")
+        requested_uuid = self.module.params.get("valid_for_sharegroup_uuid")
+
         token = self._get_image_share_group_token_by_label(label)
 
-        if not token:
+        if token:
+            token._api_get()
+
+            existing_uuid = token.valid_for_sharegroup_uuid
+
+            if requested_uuid != existing_uuid:
+                self.fail(
+                    msg=(
+                        "failed to update {} -> {}: valid_for_sharegroup_uuid "
+                        "is a non-updatable field"
+                    ).format(existing_uuid, requested_uuid)
+                )
+        else:
             token = self._create()
             self.register_action(
                 "Created Image Share Group Token {0}".format(label)
             )
-
-        # Force lazy-loading
-        token._api_get()
+            token._api_get()
 
         self.results["image_share_group_token"] = token._raw_json
 

tests/integration/targets/image_share_group_token/tasks/main.yaml

@@ -44,6 +44,22 @@
           - share_group_token_create.single_use_token is defined
           - share_group_token_create.single_use_token | length > 0
 
+    - name: Attempt to update image share group token with modified share group UUID (should fail)
+      linode.cloud.image_share_group_token:
+        label: "ansible-test-{{ r }}"
+        valid_for_sharegroup_uuid: "{{ share_group_create.image_share_group.uuid }}x"
+        state: present
+      register: share_group_token_update_attempt
+      failed_when: false
+      environment:
+        LINODE_API_TOKEN: "{{ consumer_api_token }}"
+
+    - name: Assert image share group token update fails for non-mutable field
+      assert:
+        that:
+          - share_group_token_update_attempt.msg is defined
+          - "'non-updatable field' in share_group_token_update_attempt.msg"
+
   always:
     - ignore_errors: yes
       block: