fix: remove all the db messages on the websocket (#712)

(cherry picked from commit 1749940)

Author: CasLubbers

src/app.ts

@@ -14,7 +14,6 @@ import { CleanOptions } from 'simple-git'
 import { default as Authz } from 'src/authz'
 import {
   authzMiddleware,
-  DbMessage,
   errorMiddleware,
   getIo,
   getSessionStack,
@@ -80,9 +79,6 @@ const checkAgainstGitea = async () => {
     }
     // inflate new db
     await otomiStack.loadValues()
-    const sha = await otomiStack.git.getCommitSha()
-    const msg: DbMessage = { state: 'clean', editor: 'system', sha, reason: 'conflict' }
-    getIo().emit('db', msg)
   }
 }
 

src/git.ts

@@ -23,7 +23,6 @@ import {
 import { parse as parseYaml, stringify as stringifyYaml } from 'yaml'
 import { BASEURL } from './constants'
 import { GitPullError, HttpError, ValidationError } from './error'
-import { DbMessage, getIo } from './middleware'
 import { Core } from './otomi-models'
 import { FileMap, getFilePath, getResourceName, renderManifest, renderManifestForSecrets } from './repo'
 import { getSanitizedErrorMessage, removeBlankAttributes } from './utils'
@@ -394,10 +393,6 @@ export class Git {
       const eMessage = getSanitizedErrorMessage(e)
       debug('Could not pull from remote. Upstream commits? Marked db as corrupt.', eMessage)
       this.corrupt = true
-      if (!skipMsg) {
-        const msg: DbMessage = { editor: 'system', state: 'corrupt', reason: 'conflict' }
-        getIo().emit('db', msg)
-      }
       try {
         // Remove local changes so that no conflict can happen
         debug('Removing local changes.')
@@ -420,8 +415,6 @@ export class Git {
         throw new GitPullError('Failed to remove upstream commits!')
       }
       debug('Removed upstream commits!')
-      const cleanMsg: DbMessage = { editor: 'system', state: 'clean', reason: 'restored' }
-      getIo().emit('db', cleanMsg)
       this.corrupt = false
     }
   }

src/otomi-stack.ts

@@ -11,7 +11,7 @@ import { cloneDeep, filter, isEmpty, map, mapValues, merge, omit, pick, set, uns
 import { getAppList, getAppSchema, getSpec } from 'src/app'
 import { AlreadyExists, HttpError, OtomiError, PublicUrlExists, ValidationError } from 'src/error'
 import getRepo, { Git } from 'src/git'
-import { cleanSession, DbMessage, getIo, getSessionStack } from 'src/middleware'
+import { cleanSession, getIo, getSessionStack } from 'src/middleware'
 import {
   AplBackupRequest,
   AplBackupResponse,
@@ -2002,8 +2002,6 @@ export default class OtomiStack {
       const sha = await rootStack.git.getCommitSha()
       this.emitPipelineStatus(sha)
     } catch (e) {
-      const msg: DbMessage = { editor: 'system', state: 'corrupt', reason: 'deploy' }
-      getIo().emit('db', msg)
       e.message = getSanitizedErrorMessage(e)
       throw e
     } finally {
@@ -2032,8 +2030,6 @@ export default class OtomiStack {
       const sha = await rootStack.git.getCommitSha()
       this.emitPipelineStatus(sha)
     } catch (e) {
-      const msg: DbMessage = { editor: 'system', state: 'corrupt', reason: 'deploy' }
-      getIo().emit('db', msg)
       e.message = getSanitizedErrorMessage(e)
       throw e
     } finally {
@@ -2072,8 +2068,6 @@ export default class OtomiStack {
       const sha = await rootStack.git.getCommitSha()
       this.emitPipelineStatus(sha)
     } catch (e) {
-      const msg: DbMessage = { editor: 'system', state: 'corrupt', reason: 'deploy' }
-      getIo().emit('db', msg)
       e.message = getSanitizedErrorMessage(e)
       throw e
     } finally {