Skip to content

Commit 979f8da

Browse files
committed
Merge remote-tracking branch 'origin/main' into dependabot/npm_and_yarn/multi-a28ee524ce
2 parents df7a784 + 7251ed5 commit 979f8da

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

src/ai/DatabaseCR.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe('DatabaseCR', () => {
4848
test('should set required PostgreSQL extensions', () => {
4949
const dbCR = new DatabaseCR('team-123', 'test-kb', 'cluster-name')
5050

51-
expect(dbCR.spec.extensions).toEqual([{ name: 'pgvector' }, { name: 'pg_stat_statements' }])
51+
expect(dbCR.spec.extensions).toEqual([{ name: 'vector' }, { name: 'pg_stat_statements' }])
5252
})
5353

5454
test('should use environment variable for owner', () => {

src/ai/DatabaseCR.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export class DatabaseCR {
3333
name: knowledgeBaseName,
3434
owner: env.DB_OWNER,
3535
cluster: { name: clusterName },
36-
extensions: [{ name: 'pgvector' }, { name: 'pg_stat_statements' }],
36+
extensions: [{ name: 'vector' }, { name: 'pg_stat_statements' }],
3737
}
3838
}
3939

src/ai/aiModelHandler.test.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { V1Deployment } from '@kubernetes/client-node'
2-
import { transformK8sDeploymentToAplAIModel, getAIModels } from './aiModelHandler'
2+
import { getAIModels, transformK8sDeploymentToAplAIModel } from './aiModelHandler'
33
import * as k8s from './k8s'
44

55
// Mock the k8s module
@@ -14,7 +14,9 @@ describe('aiModelHandler', () => {
1414
name: 'gpt-4-deployment',
1515
namespace: 'ai-models',
1616
labels: {
17+
app: 'gpt-4',
1718
modelName: 'gpt-4',
19+
modelNameTitle: 'GPT-4o-mini',
1820
modelType: 'foundation',
1921
modelDimension: '1536',
2022
},
@@ -55,8 +57,8 @@ describe('aiModelHandler', () => {
5557
name: 'gpt-4',
5658
},
5759
spec: {
58-
displayName: 'gpt-4',
59-
modelEndpoint: 'http://gpt-4-deployment.ai-models.svc.cluster.local',
60+
displayName: 'GPT-4o-mini',
61+
modelEndpoint: 'http://gpt-4.ai-models.svc.cluster.local/openai/v1',
6062
modelType: 'foundation',
6163
modelDimension: 1536,
6264
},
@@ -98,7 +100,7 @@ describe('aiModelHandler', () => {
98100
const result = transformK8sDeploymentToAplAIModel(deploymentWithModelName)
99101

100102
expect(result.metadata.name).toBe('custom-model-name')
101-
expect(result.spec.displayName).toBe('custom-model-name')
103+
expect(result.spec.displayName).toBe('GPT-4o-mini')
102104
})
103105

104106
test('should use modelName from labels when deployment name is missing', () => {
@@ -117,7 +119,7 @@ describe('aiModelHandler', () => {
117119
const result = transformK8sDeploymentToAplAIModel(deploymentWithoutName)
118120

119121
expect(result.metadata.name).toBe('custom-model-name')
120-
expect(result.spec.displayName).toBe('custom-model-name')
122+
expect(result.spec.displayName).toBe('GPT-4o-mini')
121123
})
122124

123125
test('should handle deployment without labels', () => {
@@ -164,7 +166,7 @@ describe('aiModelHandler', () => {
164166

165167
const result = transformK8sDeploymentToAplAIModel(deploymentWithoutNamespace)
166168

167-
expect(result.spec.modelEndpoint).toBe('http://test-deployment.undefined.svc.cluster.local')
169+
expect(result.spec.modelEndpoint).toBe('http://gpt-4.undefined.svc.cluster.local/openai/v1')
168170
})
169171

170172
test('should handle deployment without status conditions', () => {
@@ -232,7 +234,7 @@ describe('aiModelHandler', () => {
232234
const result = transformK8sDeploymentToAplAIModel(deploymentWithoutMetadata)
233235

234236
expect(result.metadata.name).toBe('')
235-
expect(result.spec.modelEndpoint).toBe('http://undefined.undefined.svc.cluster.local')
237+
expect(result.spec.modelEndpoint).toBe('http://.undefined.svc.cluster.local/openai/v1')
236238
})
237239
})
238240

src/ai/aiModelHandler.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ function getConditions(deployment: V1Deployment) {
1515
export function transformK8sDeploymentToAplAIModel(deployment: V1Deployment): AplAIModelResponse {
1616
const labels = deployment.metadata?.labels || {}
1717
const modelName = labels.modelName || deployment.metadata?.name || ''
18+
const modelNameTitle = labels.modelNameTitle || deployment.metadata?.name || ''
19+
const endpointName = labels.app || deployment.metadata?.name || ''
1820

1921
// Convert K8s deployment conditions to schema format
2022
const conditions = getConditions(deployment)
@@ -25,8 +27,8 @@ export function transformK8sDeploymentToAplAIModel(deployment: V1Deployment): Ap
2527
name: modelName,
2628
},
2729
spec: {
28-
displayName: modelName,
29-
modelEndpoint: `http://${deployment.metadata?.name}.${deployment.metadata?.namespace}.svc.cluster.local`,
30+
displayName: modelNameTitle,
31+
modelEndpoint: `http://${endpointName}.${deployment.metadata?.namespace}.svc.cluster.local/openai/v1`,
3032
modelType: labels.modelType as 'foundation' | 'embedding',
3133
...(labels.modelDimension && { modelDimension: parseInt(labels.modelDimension, 10) }),
3234
},

src/validators.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export const GIT_PUSH_RETRIES = num({
9696
})
9797
export const PIPELINE_NAME = str({
9898
desc: 'The name of the current pipeline',
99-
default: 'doc-ingestion-pipeline',
99+
default: 'doc-ingest-pipeline',
100100
})
101101
export const KNOWLEDGE_BASE_API_VERSION = str({
102102
desc: 'The API version for AkamaiKnowledgeBase custom resources',

0 commit comments

Comments
 (0)