Skip to content

Commit a27c2ca

Browse files
committed
fix: added readable length errors for build netpol secret and service
1 parent 5336170 commit a27c2ca

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/otomi-stack.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,8 @@ export default class OtomiStack {
978978
}
979979

980980
async createAplNetpol(teamId: string, data: AplNetpolRequest): Promise<AplNetpolResponse> {
981+
if (data.metadata.name.length < 2)
982+
throw new ValidationError('Network policy name must be at least 2 characters long')
981983
try {
982984
const netpol = this.repoService.getTeamConfigService(teamId).createNetpol(data)
983985
await this.saveTeamConfigItem(netpol)
@@ -1424,6 +1426,8 @@ export default class OtomiStack {
14241426

14251427
async createAplBuild(teamId: string, data: AplBuildRequest): Promise<AplBuildResponse> {
14261428
const buildName = `${data?.spec?.imageName}-${data?.spec?.tag}`
1429+
if (data.spec.secretName)
1430+
if (data.spec.secretName.length < 2) throw new ValidationError('Secret name must be at least 2 characters long')
14271431
if (buildName.length > 128) {
14281432
throw new HttpError(
14291433
400,
@@ -1874,6 +1878,10 @@ export default class OtomiStack {
18741878
}
18751879

18761880
async createAplService(teamId: string, data: AplServiceRequest): Promise<AplServiceResponse> {
1881+
if (data.metadata.name.length < 2) throw new ValidationError('Service name must be at least 3 characters long')
1882+
if (data.spec.cname?.tlsSecretName)
1883+
if (data.spec.cname?.tlsSecretName.length < 2)
1884+
throw new ValidationError('Secret name must be at least 2 characters long')
18771885
try {
18781886
const service = this.repoService.getTeamConfigService(teamId).createService(data)
18791887
await this.saveTeamConfigItem(service)
@@ -2207,6 +2215,7 @@ export default class OtomiStack {
22072215
}
22082216

22092217
async createAplSealedSecret(teamId: string, data: AplSecretRequest): Promise<AplSecretResponse> {
2218+
if (data.metadata.name.length < 2) throw new ValidationError('Secret name must be at least 2 characters long')
22102219
try {
22112220
const sealedSecret = this.repoService.getTeamConfigService(teamId).createSealedSecret(data)
22122221
await this.saveTeamSealedSecret(sealedSecret)

0 commit comments

Comments
 (0)