Skip to content

Commit d962de2

Browse files
committed
fix: tests
1 parent 26d5dae commit d962de2

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/ai/aiModelHandler.test.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ describe('aiModelHandler', () => {
1616
labels: {
1717
app: 'gpt-4',
1818
modelName: 'gpt-4',
19+
modelNameTitle: 'GPT-4o-mini',
1920
modelType: 'foundation',
2021
modelDimension: '1536',
2122
},
@@ -56,8 +57,8 @@ describe('aiModelHandler', () => {
5657
name: 'gpt-4',
5758
},
5859
spec: {
59-
displayName: 'gpt-4',
60-
modelEndpoint: 'http://gpt-4-deployment.ai-models.svc.cluster.local',
60+
displayName: 'GPT-4o-mini',
61+
modelEndpoint: 'http://gpt-4.ai-models.svc.cluster.local/openai/v1',
6162
modelType: 'foundation',
6263
modelDimension: 1536,
6364
},
@@ -99,7 +100,7 @@ describe('aiModelHandler', () => {
99100
const result = transformK8sDeploymentToAplAIModel(deploymentWithModelName)
100101

101102
expect(result.metadata.name).toBe('custom-model-name')
102-
expect(result.spec.displayName).toBe('custom-model-name')
103+
expect(result.spec.displayName).toBe('GPT-4o-mini')
103104
})
104105

105106
test('should use modelName from labels when deployment name is missing', () => {
@@ -118,7 +119,7 @@ describe('aiModelHandler', () => {
118119
const result = transformK8sDeploymentToAplAIModel(deploymentWithoutName)
119120

120121
expect(result.metadata.name).toBe('custom-model-name')
121-
expect(result.spec.displayName).toBe('custom-model-name')
122+
expect(result.spec.displayName).toBe('GPT-4o-mini')
122123
})
123124

124125
test('should handle deployment without labels', () => {
@@ -165,7 +166,7 @@ describe('aiModelHandler', () => {
165166

166167
const result = transformK8sDeploymentToAplAIModel(deploymentWithoutNamespace)
167168

168-
expect(result.spec.modelEndpoint).toBe('http://test-deployment.undefined.svc.cluster.local')
169+
expect(result.spec.modelEndpoint).toBe('http://gpt-4.undefined.svc.cluster.local/openai/v1')
169170
})
170171

171172
test('should handle deployment without status conditions', () => {
@@ -233,7 +234,7 @@ describe('aiModelHandler', () => {
233234
const result = transformK8sDeploymentToAplAIModel(deploymentWithoutMetadata)
234235

235236
expect(result.metadata.name).toBe('')
236-
expect(result.spec.modelEndpoint).toBe('http://undefined.undefined.svc.cluster.local')
237+
expect(result.spec.modelEndpoint).toBe('http://.undefined.svc.cluster.local/openai/v1')
237238
})
238239
})
239240

src/ai/aiModelHandler.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ function getConditions(deployment: V1Deployment) {
1414

1515
export function transformK8sDeploymentToAplAIModel(deployment: V1Deployment): AplAIModelResponse {
1616
const labels = deployment.metadata?.labels || {}
17-
const modelName = labels.modelNameTitle || deployment.metadata?.name || ''
17+
const modelName = labels.modelName || deployment.metadata?.name || ''
18+
const modelNameTitle = labels.modelNameTitle || deployment.metadata?.name || ''
1819
const endpointName = labels.app || deployment.metadata?.name || ''
1920

2021
// Convert K8s deployment conditions to schema format
@@ -26,7 +27,7 @@ export function transformK8sDeploymentToAplAIModel(deployment: V1Deployment): Ap
2627
name: modelName,
2728
},
2829
spec: {
29-
displayName: modelName,
30+
displayName: modelNameTitle,
3031
modelEndpoint: `http://${endpointName}.${deployment.metadata?.namespace}.svc.cluster.local/openai/v1`,
3132
modelType: labels.modelType as 'foundation' | 'embedding',
3233
...(labels.modelDimension && { modelDimension: parseInt(labels.modelDimension, 10) }),

0 commit comments

Comments
 (0)