add a test

Author: tchinmai7

cloud/services/domains_test.go

@@ -349,6 +349,129 @@ func TestAddIPToDNS(t *testing.T) {
 		expectedDomainRecord *linodego.DomainRecord
 		expectedError        error
 	}{
+		{name: "Skip - If a CAPI machine is deleted, don't add its IP to the Domain but include other machines",
+			clusterScope: &scope.ClusterScope{
+				Cluster: &clusterv1.Cluster{
+					ObjectMeta: metav1.ObjectMeta{
+						Name: "test-cluster",
+						UID:  "test-uid",
+					},
+				},
+				LinodeCluster: &infrav1alpha2.LinodeCluster{
+					ObjectMeta: metav1.ObjectMeta{
+						Name: "test-cluster",
+						UID:  "test-uid",
+					},
+					Spec: infrav1alpha2.LinodeClusterSpec{
+						Network: infrav1alpha2.NetworkSpec{
+							LoadBalancerType:    "dns",
+							DNSRootDomain:       "lkedevs.net",
+							DNSUniqueIdentifier: "test-hash",
+						},
+					},
+				},
+				LinodeMachines: infrav1alpha2.LinodeMachineList{
+					Items: []infrav1alpha2.LinodeMachine{
+						{
+							// This machine's CAPI owner is deleted
+							ObjectMeta: metav1.ObjectMeta{
+								Name: "test-deleted-machine",
+								UID:  "test-uid-1",
+							},
+							Spec: infrav1alpha2.LinodeMachineSpec{
+								ProviderID: ptr.To("linode://123"),
+								InstanceID: ptr.To(123),
+							},
+							Status: infrav1alpha2.LinodeMachineStatus{
+								Addresses: []clusterv1.MachineAddress{
+									{
+										Type:    "ExternalIP",
+										Address: "10.10.10.10",
+									},
+								},
+							},
+						},
+						{
+							// This machine's CAPI owner is NOT deleted and should have DNS entries
+							ObjectMeta: metav1.ObjectMeta{
+								Name: "test-active-machine",
+								UID:  "test-uid-2",
+							},
+							Spec: infrav1alpha2.LinodeMachineSpec{
+								ProviderID: ptr.To("linode://456"),
+								InstanceID: ptr.To(456),
+							},
+							Status: infrav1alpha2.LinodeMachineStatus{
+								Addresses: []clusterv1.MachineAddress{
+									{
+										Type:    "ExternalIP",
+										Address: "10.20.20.20",
+									},
+								},
+							},
+						},
+					},
+				},
+			},
+			expects: func(mockClient *mock.MockLinodeClient) {
+				// The code path should still call ListDomains
+				mockClient.EXPECT().ListDomains(gomock.Any(), gomock.Any()).Return([]linodego.Domain{
+					{
+						ID:     1,
+						Domain: "lkedevs.net",
+					},
+				}, nil).AnyTimes()
+
+				// Must mock ListDomainRecords
+				mockClient.EXPECT().ListDomainRecords(gomock.Any(), gomock.Any(), gomock.Any()).Return([]linodego.DomainRecord{}, nil).AnyTimes()
+
+				// Expect CreateDomainRecord to be called for the active machine's IP (10.20.20.20)
+				// but NOT for the deleted machine's IP (10.10.10.10)
+				mockClient.EXPECT().CreateDomainRecord(gomock.Any(), gomock.Any(), gomock.Eq(linodego.DomainRecordCreateOptions{
+					Type:   "A",
+					Name:   "test-cluster-test-hash",
+					Target: "10.20.20.20",
+					TTLSec: 30,
+				})).Return(&linodego.DomainRecord{
+					ID:     1234,
+					Type:   "A",
+					Name:   "test-cluster",
+					Target: "10.20.20.20",
+					TTLSec: 30,
+				}, nil).AnyTimes()
+
+				// Make sure there's no expectation for the deleted machine's IP
+				// We don't need an explicit negative expectation since the mock
+				// will fail if any unexpected calls are made
+			},
+			expectedError: nil,
+			expectK8sClient: func(mockK8sClient *mock.MockK8sClient) {
+				mockK8sClient.EXPECT().Scheme().Return(nil).AnyTimes()
+
+				// Mock the Get call for GetOwnerMachine to handle both machines
+				mockK8sClient.EXPECT().Get(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).DoAndReturn(
+					func(ctx context.Context, key client.ObjectKey, obj client.Object, opts ...client.GetOption) error {
+						// Set the Machine fields based on the machine name
+						machine, ok := obj.(*clusterv1.Machine)
+						if ok {
+							if key.Name == "test-deleted-machine" {
+								// Set up as a deleted machine
+								machine.Name = "test-deleted-machine"
+								machine.Namespace = "default"
+								// Set DeletionTimestamp to indicate the machine is being deleted
+								deletionTime := metav1.Now()
+								machine.DeletionTimestamp = &deletionTime
+							} else if key.Name == "test-active-machine" {
+								// Set up as an active machine
+								machine.Name = "test-active-machine"
+								machine.Namespace = "default"
+								machine.DeletionTimestamp = nil
+							}
+						}
+						return nil
+					}).AnyTimes()
+			},
+		},
 		{
 			name: "Success - If the machine is a control plane node, add the IP to the Domain",
 			clusterScope: &scope.ClusterScope{