[improvement] Remove v1beta2 conditions package (#859)

* Remove the "sigs.k8s.io/cluster-api/util/conditions/v1beta2" package

* fix(?) LC controller test

* lint

Author: AshleyDumaine

api/v1alpha2/linodecluster_types.go

@@ -26,6 +26,7 @@ const (
 	// ClusterFinalizer allows ReconcileLinodeCluster to clean up Linode resources associated
 	// with LinodeCluster before removing it from the apiserver.
 	ClusterFinalizer = "linodecluster.infrastructure.cluster.x-k8s.io"
+	ConditionPaused  = "Paused"
 )
 
 // LinodeClusterSpec defines the desired state of LinodeCluster
@@ -121,26 +122,36 @@ type LinodeCluster struct {
 	Status LinodeClusterStatus `json:"status,omitempty"`
 }
 
-func (lc *LinodeCluster) GetConditions() []metav1.Condition {
+func (lc *LinodeCluster) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
+	}
 	for i := range lc.Status.Conditions {
-		if lc.Status.Conditions[i].Reason == "" {
-			lc.Status.Conditions[i].Reason = DefaultConditionReason
+		if lc.Status.Conditions[i].Type == cond.Type {
+			lc.Status.Conditions[i] = cond
+			return
 		}
 	}
-	return lc.Status.Conditions
+	lc.Status.Conditions = append(lc.Status.Conditions, cond)
 }
 
-func (lc *LinodeCluster) SetConditions(conditions []metav1.Condition) {
-	lc.Status.Conditions = conditions
-}
+func (lc *LinodeCluster) GetCondition(condType string) *metav1.Condition {
+	for i := range lc.Status.Conditions {
+		if lc.Status.Conditions[i].Type == condType {
+			return &lc.Status.Conditions[i]
+		}
+	}
 
-// We need V1Beta2Conditions helpers to be able to use the conditions package from cluster-api
-func (lc *LinodeCluster) GetV1Beta2Conditions() []metav1.Condition {
-	return lc.GetConditions()
+	return nil
 }
 
-func (lc *LinodeCluster) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	lc.SetConditions(conditions)
+func (lc *LinodeCluster) IsPaused() bool {
+	for i := range lc.Status.Conditions {
+		if lc.Status.Conditions[i].Type == ConditionPaused {
+			return lc.Status.Conditions[i].Status == metav1.ConditionTrue
+		}
+	}
+	return false
 }
 
 // NetworkSpec encapsulates Linode networking resources.

api/v1alpha2/linodefirewall_types.go

@@ -151,26 +151,36 @@ type LinodeFirewall struct {
 	Status LinodeFirewallStatus `json:"status,omitempty"`
 }
 
-func (lfw *LinodeFirewall) GetConditions() []metav1.Condition {
+func (lfw *LinodeFirewall) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
+	}
 	for i := range lfw.Status.Conditions {
-		if lfw.Status.Conditions[i].Reason == "" {
-			lfw.Status.Conditions[i].Reason = DefaultConditionReason
+		if lfw.Status.Conditions[i].Type == cond.Type {
+			lfw.Status.Conditions[i] = cond
+			return
 		}
 	}
-	return lfw.Status.Conditions
+	lfw.Status.Conditions = append(lfw.Status.Conditions, cond)
 }
 
-func (lfw *LinodeFirewall) SetConditions(conditions []metav1.Condition) {
-	lfw.Status.Conditions = conditions
-}
+func (lfw *LinodeFirewall) GetCondition(condType string) *metav1.Condition {
+	for i := range lfw.Status.Conditions {
+		if lfw.Status.Conditions[i].Type == condType {
+			return &lfw.Status.Conditions[i]
+		}
+	}
 
-// We need V1Beta2Conditions helpers to be able to use the conditions package from cluster-api
-func (lfw *LinodeFirewall) GetV1Beta2Conditions() []metav1.Condition {
-	return lfw.GetConditions()
+	return nil
 }
 
-func (lfw *LinodeFirewall) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	lfw.SetConditions(conditions)
+func (lfw *LinodeFirewall) IsPaused() bool {
+	for i := range lfw.Status.Conditions {
+		if lfw.Status.Conditions[i].Type == ConditionPaused {
+			return lfw.Status.Conditions[i].Status == metav1.ConditionTrue
+		}
+	}
+	return false
 }
 
 // +kubebuilder:object:root=true

api/v1alpha2/linodemachine_types.go

@@ -576,25 +576,45 @@ type LinodeMachine struct {
 	Status LinodeMachineStatus `json:"status,omitempty"`
 }
 
-func (lm *LinodeMachine) GetConditions() []metav1.Condition {
+func (lm *LinodeMachine) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
+	}
 	for i := range lm.Status.Conditions {
-		if lm.Status.Conditions[i].Reason == "" {
-			lm.Status.Conditions[i].Reason = DefaultConditionReason
+		if lm.Status.Conditions[i].Type == cond.Type {
+			lm.Status.Conditions[i] = cond
+
+			return
 		}
 	}
-	return lm.Status.Conditions
+	lm.Status.Conditions = append(lm.Status.Conditions, cond)
 }
 
-func (lm *LinodeMachine) SetConditions(conditions []metav1.Condition) {
-	lm.Status.Conditions = conditions
+func (lm *LinodeMachine) GetCondition(condType string) *metav1.Condition {
+	for i := range lm.Status.Conditions {
+		if lm.Status.Conditions[i].Type == condType {
+			return &lm.Status.Conditions[i]
+		}
+	}
+
+	return nil
 }
 
-func (lm *LinodeMachine) GetV1Beta2Conditions() []metav1.Condition {
-	return lm.GetConditions()
+func (lm *LinodeMachine) DeleteCondition(condType string) {
+	for i := range lm.Status.Conditions {
+		if lm.Status.Conditions[i].Type == condType {
+			lm.Status.Conditions = append(lm.Status.Conditions[:i], lm.Status.Conditions[i+1:]...)
+		}
+	}
 }
 
-func (lm *LinodeMachine) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	lm.SetConditions(conditions)
+func (lm *LinodeMachine) IsPaused() bool {
+	for i := range lm.Status.Conditions {
+		if lm.Status.Conditions[i].Type == ConditionPaused {
+			return lm.Status.Conditions[i].Status == metav1.ConditionTrue
+		}
+	}
+	return false
 }
 
 // +kubebuilder:object:root=true

api/v1alpha2/linodemachinetemplate_types.go

@@ -76,25 +76,18 @@ type LinodeMachineTemplate struct {
 	Status LinodeMachineTemplateStatus `json:"status,omitempty"`
 }
 
-func (lmt *LinodeMachineTemplate) GetConditions() []metav1.Condition {
+func (lmt *LinodeMachineTemplate) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
+	}
 	for i := range lmt.Status.Conditions {
-		if lmt.Status.Conditions[i].Reason == "" {
-			lmt.Status.Conditions[i].Reason = DefaultConditionReason
+		if lmt.Status.Conditions[i].Type == cond.Type {
+			lmt.Status.Conditions[i] = cond
+
+			return
 		}
 	}
-	return lmt.Status.Conditions
-}
-
-func (lmt *LinodeMachineTemplate) SetConditions(conditions []metav1.Condition) {
-	lmt.Status.Conditions = conditions
-}
-
-func (lmt *LinodeMachineTemplate) GetV1Beta2Conditions() []metav1.Condition {
-	return lmt.GetConditions()
-}
-
-func (lmt *LinodeMachineTemplate) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	lmt.SetConditions(conditions)
+	lmt.Status.Conditions = append(lmt.Status.Conditions, cond)
 }
 
 // +kubebuilder:object:root=true

api/v1alpha2/linodeobjectstoragebucket_types.go

@@ -122,25 +122,28 @@ type LinodeObjectStorageBucket struct {
 	Status LinodeObjectStorageBucketStatus `json:"status,omitempty"`
 }
 
-func (losb *LinodeObjectStorageBucket) GetConditions() []metav1.Condition {
-	for i := range losb.Status.Conditions {
-		if losb.Status.Conditions[i].Reason == "" {
-			losb.Status.Conditions[i].Reason = DefaultConditionReason
-		}
+func (lobj *LinodeObjectStorageBucket) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
 	}
-	return losb.Status.Conditions
-}
+	for i := range lobj.Status.Conditions {
+		if lobj.Status.Conditions[i].Type == cond.Type {
+			lobj.Status.Conditions[i] = cond
 
-func (losb *LinodeObjectStorageBucket) SetConditions(conditions []metav1.Condition) {
-	losb.Status.Conditions = conditions
+			return
+		}
+	}
+	lobj.Status.Conditions = append(lobj.Status.Conditions, cond)
 }
 
-func (losb *LinodeObjectStorageBucket) GetV1Beta2Conditions() []metav1.Condition {
-	return losb.GetConditions()
-}
+func (lobj *LinodeObjectStorageBucket) GetCondition(condType string) *metav1.Condition {
+	for i := range lobj.Status.Conditions {
+		if lobj.Status.Conditions[i].Type == condType {
+			return &lobj.Status.Conditions[i]
+		}
+	}
 
-func (losb *LinodeObjectStorageBucket) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	losb.SetConditions(conditions)
+	return nil
 }
 
 // +kubebuilder:object:root=true

api/v1alpha2/linodeobjectstoragekey_types.go

@@ -158,25 +158,28 @@ type LinodeObjectStorageKey struct {
 	Status LinodeObjectStorageKeyStatus `json:"status,omitempty"`
 }
 
-func (losk *LinodeObjectStorageKey) GetConditions() []metav1.Condition {
-	for i := range losk.Status.Conditions {
-		if losk.Status.Conditions[i].Reason == "" {
-			losk.Status.Conditions[i].Reason = DefaultConditionReason
-		}
+func (key *LinodeObjectStorageKey) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
 	}
-	return losk.Status.Conditions
-}
+	for i := range key.Status.Conditions {
+		if key.Status.Conditions[i].Type == cond.Type {
+			key.Status.Conditions[i] = cond
 
-func (losk *LinodeObjectStorageKey) SetConditions(conditions []metav1.Condition) {
-	losk.Status.Conditions = conditions
+			return
+		}
+	}
+	key.Status.Conditions = append(key.Status.Conditions, cond)
 }
 
-func (losk *LinodeObjectStorageKey) GetV1Beta2Conditions() []metav1.Condition {
-	return losk.GetConditions()
-}
+func (key *LinodeObjectStorageKey) GetCondition(condType string) *metav1.Condition {
+	for i := range key.Status.Conditions {
+		if key.Status.Conditions[i].Type == condType {
+			return &key.Status.Conditions[i]
+		}
+	}
 
-func (losk *LinodeObjectStorageKey) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	losk.SetConditions(conditions)
+	return nil
 }
 
 // LinodeObjectStorageKeyList contains a list of LinodeObjectStorageKey

api/v1alpha2/linodeplacementgroup_types.go

@@ -134,25 +134,37 @@ type LinodePlacementGroup struct {
 	Status LinodePlacementGroupStatus `json:"status,omitempty"`
 }
 
-func (lpg *LinodePlacementGroup) GetConditions() []metav1.Condition {
+func (lpg *LinodePlacementGroup) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
+	}
 	for i := range lpg.Status.Conditions {
-		if lpg.Status.Conditions[i].Reason == "" {
-			lpg.Status.Conditions[i].Reason = DefaultConditionReason
+		if lpg.Status.Conditions[i].Type == cond.Type {
+			lpg.Status.Conditions[i] = cond
+
+			return
 		}
 	}
-	return lpg.Status.Conditions
+	lpg.Status.Conditions = append(lpg.Status.Conditions, cond)
 }
 
-func (lpg *LinodePlacementGroup) SetConditions(conditions []metav1.Condition) {
-	lpg.Status.Conditions = conditions
-}
+func (lpg *LinodePlacementGroup) GetCondition(condType string) *metav1.Condition {
+	for i := range lpg.Status.Conditions {
+		if lpg.Status.Conditions[i].Type == condType {
+			return &lpg.Status.Conditions[i]
+		}
+	}
 
-func (lpg *LinodePlacementGroup) GetV1Beta2Conditions() []metav1.Condition {
-	return lpg.GetConditions()
+	return nil
 }
 
-func (lpg *LinodePlacementGroup) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	lpg.SetConditions(conditions)
+func (lpg *LinodePlacementGroup) IsPaused() bool {
+	for i := range lpg.Status.Conditions {
+		if lpg.Status.Conditions[i].Type == ConditionPaused {
+			return lpg.Status.Conditions[i].Status == metav1.ConditionTrue
+		}
+	}
+	return false
 }
 
 // +kubebuilder:object:root=true

api/v1alpha2/linodevpc_types.go

@@ -209,25 +209,37 @@ type LinodeVPC struct {
 	Status LinodeVPCStatus `json:"status,omitempty"`
 }
 
-func (lv *LinodeVPC) GetConditions() []metav1.Condition {
+func (lv *LinodeVPC) SetCondition(cond metav1.Condition) {
+	if cond.LastTransitionTime.IsZero() {
+		cond.LastTransitionTime = metav1.Now()
+	}
 	for i := range lv.Status.Conditions {
-		if lv.Status.Conditions[i].Reason == "" {
-			lv.Status.Conditions[i].Reason = DefaultConditionReason
+		if lv.Status.Conditions[i].Type == cond.Type {
+			lv.Status.Conditions[i] = cond
+
+			return
 		}
 	}
-	return lv.Status.Conditions
+	lv.Status.Conditions = append(lv.Status.Conditions, cond)
 }
 
-func (lv *LinodeVPC) SetConditions(conditions []metav1.Condition) {
-	lv.Status.Conditions = conditions
-}
+func (lv *LinodeVPC) GetCondition(condType string) *metav1.Condition {
+	for i := range lv.Status.Conditions {
+		if lv.Status.Conditions[i].Type == condType {
+			return &lv.Status.Conditions[i]
+		}
+	}
 
-func (lv *LinodeVPC) GetV1Beta2Conditions() []metav1.Condition {
-	return lv.GetConditions()
+	return nil
 }
 
-func (lv *LinodeVPC) SetV1Beta2Conditions(conditions []metav1.Condition) {
-	lv.SetConditions(conditions)
+func (lv *LinodeVPC) IsPaused() bool {
+	for i := range lv.Status.Conditions {
+		if lv.Status.Conditions[i].Type == ConditionPaused {
+			return lv.Status.Conditions[i].Status == metav1.ConditionTrue
+		}
+	}
+	return false
 }
 
 // +kubebuilder:object:root=true