Skip to content

Commit 66f8eeb

Browse files
committed
remove deprecated fields
1 parent ac1346f commit 66f8eeb

File tree

7 files changed

+0
-59
lines changed

7 files changed

+0
-59
lines changed

api/v1alpha2/linodemachine_types.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -527,13 +527,6 @@ type LinodeMachineStatus struct {
527527
// +listMapKey=address
528528
Addresses []clusterv1.MachineAddress `json:"addresses,omitempty"`
529529

530-
// cloudinitMetadataSupport determines whether to use cloud-init or not.
531-
// Deprecated: Stackscript no longer in use, so this field is not used.
532-
// +kubebuilder:deprecatedversion:warning="CloudinitMetadataSupport is deprecated"
533-
// +optional
534-
// +kubebuilder:default=true
535-
CloudinitMetadataSupport bool `json:"cloudinitMetadataSupport,omitempty"`
536-
537530
// instanceState is the state of the Linode instance for this machine.
538531
// +optional
539532
InstanceState *linodego.InstanceStatus `json:"instanceState,omitempty"`

api/v1alpha2/linodeobjectstoragekey_types.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -89,19 +89,6 @@ type LinodeObjectStorageKeySpec struct {
8989
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
9090
// +required
9191
GeneratedSecret `json:"generatedSecret"`
92-
93-
// secretType instructs the controller what type of secret to generate containing access key details.
94-
// Deprecated: Use generatedSecret.type.
95-
// +kubebuilder:validation:Enum=Opaque;addons.cluster.x-k8s.io/resource-set
96-
// +kubebuilder:deprecatedversion:warning="secretType deprecated by generatedSecret.type"
97-
// +optional
98-
SecretType corev1.SecretType `json:"secretType,omitempty"`
99-
100-
// secretDataFormat instructs the controller how to format the data stored in the secret containing access key details.
101-
// Deprecated: Use generatedSecret.format.
102-
// +kubebuilder:deprecatedversion:warning="secretDataFormat deprecated by generatedSecret.format"
103-
// +optional
104-
SecretDataFormat map[string]string `json:"secretDataFormat,omitempty"`
10592
}
10693

10794
// LinodeObjectStorageKeyStatus defines the observed state of LinodeObjectStorageKey

api/v1alpha2/zz_generated.deepcopy.go

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/infrastructure.cluster.x-k8s.io_linodemachines.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -937,12 +937,6 @@ spec:
937937
x-kubernetes-list-map-keys:
938938
- address
939939
x-kubernetes-list-type: map
940-
cloudinitMetadataSupport:
941-
default: true
942-
description: |-
943-
cloudinitMetadataSupport determines whether to use cloud-init or not.
944-
Deprecated: Stackscript no longer in use, so this field is not used.
945-
type: boolean
946940
conditions:
947941
description: conditions define the current service state of the LinodeMachine.
948942
items:

config/crd/bases/infrastructure.cluster.x-k8s.io_linodeobjectstoragekeys.yaml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -140,21 +140,6 @@ spec:
140140
description: keyGeneration may be modified to trigger a rotation of
141141
the access key.
142142
type: integer
143-
secretDataFormat:
144-
additionalProperties:
145-
type: string
146-
description: |-
147-
secretDataFormat instructs the controller how to format the data stored in the secret containing access key details.
148-
Deprecated: Use generatedSecret.format.
149-
type: object
150-
secretType:
151-
description: |-
152-
secretType instructs the controller what type of secret to generate containing access key details.
153-
Deprecated: Use generatedSecret.type.
154-
enum:
155-
- Opaque
156-
- addons.cluster.x-k8s.io/resource-set
157-
type: string
158143
required:
159144
- bucketAccess
160145
- generatedSecret

docs/src/reference/out.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,6 @@ _Appears in:_
723723
| `conditions` _[Condition](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.32/#condition-v1-meta) array_ | conditions define the current service state of the LinodeMachine. | | |
724724
| `ready` _boolean_ | ready is true when the provider resource is ready. | false | |
725725
| `addresses` _MachineAddress array_ | addresses contains the Linode instance associated addresses. | | |
726-
| `cloudinitMetadataSupport` _boolean_ | cloudinitMetadataSupport determines whether to use cloud-init or not.<br />Deprecated: Stackscript no longer in use, so this field is not used. | true | |
727726
| `instanceState` _[InstanceStatus](#instancestatus)_ | instanceState is the state of the Linode instance for this machine. | | |
728727
| `failureReason` _string_ | failureReason will be set in the event that there is a terminal problem<br />reconciling the Machine and will contain a succinct value suitable<br />for machine interpretation.<br />This field should not be set for transitive errors that a controller<br />faces that are expected to be fixed automatically over<br />time (like service outages), but instead indicate that something is<br />fundamentally wrong with the Machine's spec or the configuration of<br />the controller, and that manual intervention is required. Examples<br />of terminal errors would be invalid combinations of settings in the<br />spec, values that are unsupported by the controller, or the<br />responsible controller itself being critically misconfigured.<br />Any transient errors that occur during the reconciliation of Machines<br />can be added as events to the Machine object and/or logged in the<br />controller's output. | | |
729728
| `failureMessage` _string_ | failureMessage will be set in the event that there is a terminal problem<br />reconciling the Machine and will contain a more verbose string suitable<br />for logging and human consumption.<br />This field should not be set for transitive errors that a controller<br />faces that are expected to be fixed automatically over<br />time (like service outages), but instead indicate that something is<br />fundamentally wrong with the Machine's spec or the configuration of<br />the controller, and that manual intervention is required. Examples<br />of terminal errors would be invalid combinations of settings in the<br />spec, values that are unsupported by the controller, or the<br />responsible controller itself being critically misconfigured.<br />Any transient errors that occur during the reconciliation of Machines<br />can be added as events to the Machine object and/or logged in the<br />controller's output. | | |
@@ -982,8 +981,6 @@ _Appears in:_
982981
| `credentialsRef` _[SecretReference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.32/#secretreference-v1-core)_ | credentialsRef is a reference to a Secret that contains the credentials to use for generating access keys.<br />If not supplied, then the credentials of the controller will be used. | | |
983982
| `keyGeneration` _integer_ | keyGeneration may be modified to trigger a rotation of the access key. | 0 | |
984983
| `generatedSecret` _[GeneratedSecret](#generatedsecret)_ | generatedSecret configures the Secret to generate containing access key details. | | |
985-
| `secretType` _[SecretType](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.32/#secrettype-v1-core)_ | secretType instructs the controller what type of secret to generate containing access key details.<br />Deprecated: Use generatedSecret.type. | | Enum: [Opaque addons.cluster.x-k8s.io/resource-set] <br /> |
986-
| `secretDataFormat` _object (keys:string, values:string)_ | secretDataFormat instructs the controller how to format the data stored in the secret containing access key details.<br />Deprecated: Use generatedSecret.format. | | |
987984

988985

989986
#### LinodeObjectStorageKeyStatus

internal/webhook/v1alpha2/linodeobjectstoragekey_webhook.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,5 @@ func (d *LinodeObjectStorageKeyDefaulter) Default(ctx context.Context, obj runti
149149
key.Spec.Namespace = key.Namespace
150150
}
151151

152-
// Support deprecated fields when specified and updated fields are empty.
153-
if key.Spec.SecretType != "" && key.Spec.Type == "" {
154-
key.Spec.Type = key.Spec.SecretType
155-
}
156-
if len(key.Spec.SecretDataFormat) > 0 && len(key.Spec.Format) == 0 {
157-
key.Spec.Format = key.Spec.SecretDataFormat
158-
}
159-
160152
return nil
161153
}

0 commit comments

Comments
 (0)