address breaking pointer updates for linodego 1.59.0

Author: AshleyDumaine

internal/controller/linodemachine_controller_helpers.go

@@ -666,7 +666,7 @@ func getVPCLinodeInterfaceConfig(ctx context.Context, machineScope *scope.Machin
 		VPC: &linodego.VPCInterfaceCreateOptions{
 			SubnetID: subnetID,
 			IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
-				Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{{
+				Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{{
 					Primary:        ptr.To(true),
 					NAT1To1Address: ptr.To("auto"),
 					Address:        ptr.To("auto"),
@@ -751,7 +751,7 @@ func getVPCLinodeInterfaceConfigFromDirectID(ctx context.Context, machineScope *
 		VPC: &linodego.VPCInterfaceCreateOptions{
 			SubnetID: subnetID,
 			IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
-				Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{{
+				Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{{
 					Primary:        ptr.To(true),
 					NAT1To1Address: ptr.To("auto"),
 					Address:        ptr.To("auto"),
@@ -841,10 +841,7 @@ func isIPv6ConfigEmpty(opts *linodego.InstanceConfigInterfaceCreateOptionsIPv6)
 }
 
 func isVPCInterfaceIPv6ConfigEmpty(opts *linodego.VPCInterfaceIPv6CreateOptions) bool {
-	return opts == nil ||
-		len(opts.SLAAC) == 0 &&
-			len(opts.Ranges) == 0 &&
-			!opts.IsPublic
+	return opts == nil || (opts.SLAAC == nil && opts.Ranges == nil && opts.IsPublic == nil)
 }
 
 // getMachineIPv6Config returns the IPv6 configuration for a LinodeMachine.
@@ -898,18 +895,18 @@ func getVPCLinodeInterfaceIPv6Config(machineScope *scope.MachineScope, numIPv6Ra
 
 	if machineScope.LinodeMachine.Spec.IPv6Options.IsPublicIPv6 != nil {
 		// Set the public IPv6 flag based on the IsPublicIPv6 specification.
-		intfOpts.IsPublic = *machineScope.LinodeMachine.Spec.IPv6Options.IsPublicIPv6
+		intfOpts.IsPublic = machineScope.LinodeMachine.Spec.IPv6Options.IsPublicIPv6
 	}
 
 	if machineScope.LinodeMachine.Spec.IPv6Options.EnableSLAAC != nil && *machineScope.LinodeMachine.Spec.IPv6Options.EnableSLAAC {
-		intfOpts.SLAAC = []linodego.VPCInterfaceIPv6SLAACCreateOptions{
+		intfOpts.SLAAC = &[]linodego.VPCInterfaceIPv6SLAACCreateOptions{
 			{
 				Range: defaultNodeIPv6CIDRRange,
 			},
 		}
 	}
 	if machineScope.LinodeMachine.Spec.IPv6Options.EnableRanges != nil && *machineScope.LinodeMachine.Spec.IPv6Options.EnableRanges {
-		intfOpts.Ranges = []linodego.VPCInterfaceIPv6RangeCreateOptions{
+		intfOpts.Ranges = &[]linodego.VPCInterfaceIPv6RangeCreateOptions{
 			{
 				Range: defaultNodeIPv6CIDRRange,
 			},
@@ -1009,13 +1006,13 @@ func constructLinodeInterfaceVPC(iface infrav1alpha2.LinodeInterfaceCreateOption
 	return &linodego.VPCInterfaceCreateOptions{
 		SubnetID: subnetID,
 		IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
-			Addresses: ipv4Addrs,
-			Ranges:    ipv4Ranges,
+			Addresses: &ipv4Addrs,
+			Ranges:    &ipv4Ranges,
 		},
 		IPv6: &linodego.VPCInterfaceIPv6CreateOptions{
-			SLAAC:    ipv6SLAAC,
-			Ranges:   ipv6Ranges,
-			IsPublic: ipv6IsPublic,
+			SLAAC:    &ipv6SLAAC,
+			Ranges:   &ipv6Ranges,
+			IsPublic: &ipv6IsPublic,
 		},
 	}
 }
@@ -1043,10 +1040,10 @@ func constructLinodeInterfacePublic(iface infrav1alpha2.LinodeInterfaceCreateOpt
 	}
 	return &linodego.PublicInterfaceCreateOptions{
 		IPv4: &linodego.PublicInterfaceIPv4CreateOptions{
-			Addresses: ipv4Addrs,
+			Addresses: &ipv4Addrs,
 		},
 		IPv6: &linodego.PublicInterfaceIPv6CreateOptions{
-			Ranges: ipv6Ranges,
+			Ranges: &ipv6Ranges,
 		},
 	}
 }

internal/controller/linodemachine_controller_helpers_test.go

@@ -646,15 +646,19 @@ func validateInterfaceExpectations(
 		require.NotNil(t, linodeIface)
 		require.NotNil(t, linodeIface.VPC)
 		if linodeIface.VPC.IPv6 != nil && linodeIface.VPC.IPv6.SLAAC != nil {
-			require.Equal(t, defaultNodeIPv6CIDRRange, linodeIface.VPC.IPv6.SLAAC[0].Range)
+			slaac := *linodeIface.VPC.IPv6.SLAAC
+			require.Equal(t, defaultNodeIPv6CIDRRange, slaac[0].Range)
 		} else if linodeIface.VPC.IPv6 != nil && linodeIface.VPC.IPv6.Ranges != nil {
-			require.Equal(t, defaultNodeIPv6CIDRRange, linodeIface.VPC.IPv6.Ranges[0].Range)
+			ranges := *linodeIface.VPC.IPv6.Ranges
+			require.Equal(t, defaultNodeIPv6CIDRRange, ranges[0].Range)
 		}
 		require.NotNil(t, linodeIface.VPC.SubnetID)
 		require.Equal(t, expectSubnetID, linodeIface.VPC.SubnetID)
 		require.NotNil(t, linodeIface.VPC.IPv4)
-		require.NotNil(t, linodeIface.VPC.IPv4.Addresses[0].NAT1To1Address)
-		require.Equal(t, "auto", *linodeIface.VPC.IPv4.Addresses[0].NAT1To1Address)
+		require.NotNil(t, linodeIface.VPC.IPv4.Addresses)
+		addresses := *linodeIface.VPC.IPv4.Addresses
+		require.NotNil(t, addresses[0].NAT1To1Address)
+		require.Equal(t, "auto", *addresses[0].NAT1To1Address)
 	} else {
 		require.Nil(t, linodeIface)
 	}

internal/controller/linodemachine_controller_test.go

@@ -2816,7 +2816,7 @@ var _ = Describe("machine in VPC with new network interfaces", Label("machine",
 				VPC: &linodego.VPCInterfaceCreateOptions{
 					SubnetID: 1,
 					IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
-						Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{{
+						Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{{
 							NAT1To1Address: ptr.To("auto"),
 							Primary:        ptr.To(true),
 							Address:        ptr.To("auto"),
@@ -2883,7 +2883,7 @@ var _ = Describe("machine in VPC with new network interfaces", Label("machine",
 				VPC: &linodego.VPCInterfaceCreateOptions{
 					SubnetID: 1,
 					IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
-						Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{{
+						Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{{
 							NAT1To1Address: ptr.To("auto"),
 							Primary:        ptr.To(true),
 							Address:        ptr.To("auto"),
@@ -2956,7 +2956,7 @@ var _ = Describe("machine in VPC with new network interfaces", Label("machine",
 				VPC: &linodego.VPCInterfaceCreateOptions{
 					SubnetID: 27,
 					IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
-						Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{{
+						Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{{
 							NAT1To1Address: ptr.To("auto"),
 							Primary:        ptr.To(true),
 							Address:        ptr.To("auto"),