[fix] : avoid resetting condition with severity error to severity warning #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulait
force-pushed
the
fix-record-decaying-condition
branch
4 times, most recently
from
0fa85fa to
dd2b2d5
Compare
…ing next reconcile
rahulait
force-pushed
the
fix-record-decaying-condition
branch
from
dd2b2d5 to
cc44ce1
Compare
AshleyDumaine
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes sure we don't reset condition severity from error to warning during next reconciles. Last transition time for condition changes when its updated from warning to error. During next reconcile, if we look at the last reconcile time only, then it will be the updated time and current logic was assuming that time limit has not been reached and was flipping the condition back from error to warning.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: