[improvement][helm] Update controller tolerations to use with directive for consistency (#534)

* Update controller tolerations to use `with` directive for consistency

Replace `if` with `with` directive in the controller tolerations template block to match Helm best practices and maintain consistency with other conditional blocks in the template.

* Update controller tolerations to remove NoSchedule toleration

* Move default controller tolerations from template to values.yaml

Author: komer3

helm-chart/csi-driver/templates/csi-linode-controller.yaml

@@ -210,17 +210,9 @@ spec:
       affinity:
         {{- toYaml .Values.controller.affinity | nindent 8 }}
       {{- end }}
-      {{- if .Values.controller.tolerations }}
+      {{- with .Values.controller.tolerations }}
       tolerations:
         {{- toYaml . | nindent 8 }}
-      {{- else }}
-      tolerations:
-        - effect: NoSchedule
-          operator: Exists
-        - key: CriticalAddonsOnly
-          operator: Exists
-        - effect: NoExecute
-          operator: Exists
       {{- end }}
       volumes:
         - emptyDir: {}

helm-chart/csi-driver/values.yaml

@@ -109,7 +109,11 @@ controller:
     enabled: true
   nodeSelector: {}
   affinity: {}
-  tolerations: []
+  tolerations:
+    - key: CriticalAddonsOnly
+      operator: Exists
+    - effect: NoExecute
+      operator: Exists
 
 daemonSet:
   enabled: true