address failures and pr comments

Author: ykim-akamai

tests/integration/linodes/fixtures.py

@@ -13,7 +13,9 @@
 )
 from tests.integration.linodes.helpers import (
     DEFAULT_LABEL,
+    DEFAULT_LINODE_TYPE,
     DEFAULT_RANDOM_PASS,
+    DEFAULT_REGION,
     DEFAULT_TEST_IMAGE,
     create_linode,
     create_linode_and_wait,

tests/integration/linodes/test_rebuild.py

@@ -9,7 +9,7 @@
     exec_test_command,
     retry_exec_test_command_with_delay,
 )
-from tests.integration.linodes.fixtures import (  # noqa: #401
+from tests.integration.linodes.fixtures import (  # noqa: F401
     linode_for_rebuild_tests,
 )
 from tests.integration.linodes.helpers import (

tests/integration/linodes/test_resize.py

@@ -8,7 +8,7 @@
     exec_failing_test_command,
     exec_test_command,
 )
-from tests.integration.linodes.fixtures import (  # noqa: #401
+from tests.integration.linodes.fixtures import (  # noqa: F401
     linode_instance_for_resize_tests,
 )
 from tests.integration.linodes.helpers import (

tests/integration/lke/test_clusters.py

@@ -11,7 +11,7 @@
     get_random_text,
     retry_exec_test_command_with_delay,
 )
-from tests.integration.lke.fixtures import lke_cluster, node_pool  # noqa: #401
+from tests.integration.lke.fixtures import lke_cluster, node_pool  # noqa: F401
 from tests.integration.lke.helpers import (
     get_cluster_id,
     get_lke_version_id,

tests/integration/lke/test_lke_acl.py

@@ -4,7 +4,7 @@
     exec_test_command,
     retry_exec_test_command_with_delay,
 )
-from tests.integration.lke.fixtures import lke_cluster_acl  # noqa: #401
+from tests.integration.lke.fixtures import lke_cluster_acl  # noqa: F401
 
 
 def test_cluster_acl_view(lke_cluster_acl):

tests/integration/nodebalancers/test_node_balancers.py

@@ -8,7 +8,7 @@
     exec_failing_test_command,
     exec_test_command,
 )
-from tests.integration.nodebalancers.fixtures import (  # noqa: #401
+from tests.integration.nodebalancers.fixtures import (  # noqa: F401
     linode_to_add,
     nodebalancer_w_config_and_node,
     nodebalancer_with_default_conf,

tests/integration/placements/test_placements.py

@@ -4,7 +4,7 @@
     exec_test_command,
     get_random_text,
 )
-from tests.integration.placements.fixtures import (  # noqa: #401
+from tests.integration.placements.fixtures import (  # noqa: F401
     linode_for_placement_tests,
     placement_group,
 )

tests/integration/regions/test_plugin_region_table.py

@@ -7,14 +7,11 @@
 )
 
 
-def test_output():
+def test_regions_table_output():
     output = exec_test_command(["linode-cli", "region-table"])
-    lines = output.split("\n")
-    lines = lines[3 : len(lines) - 2]
-    for line in lines:
-        assert "-" in line
-        assert "✔" in line
-        assert "│" in line
+    assert "-" in output
+    assert "✔" in output
+    assert "│" in output
 
 
 def test_regions_list():

tests/integration/ssh/test_plugin_ssh.py

@@ -1,7 +1,6 @@
 import json
-import subprocess
 from sys import platform
-from typing import Any, Dict, Optional
+from typing import Any, Dict
 
 import pytest
 
@@ -91,12 +90,10 @@ def test_ssh_instance_ready(
 ):
     pubkey, privkey = ssh_key_pair_generator
 
-    process: Optional[subprocess.CompletedProcess] = None
     instance_data = {}
 
     def instance_poll_func():
         nonlocal instance_data
-        nonlocal process
 
         output = exec_test_command(
             BASE_CMDS["linodes"]
@@ -108,7 +105,7 @@ def instance_poll_func():
         return instance_data["status"] == "running"
 
     def ssh_poll_func():
-        exec_test_command(
+        output = exec_test_command(
             BASE_CMDS["ssh"]
             + [
                 "root@" + instance_data["label"],
@@ -122,6 +119,8 @@ def ssh_poll_func():
             ]
         )
 
+        return "hello world!" in output
+
     # Wait for the instance to be ready
     wait_for_condition(
         POLL_INTERVAL, INSTANCE_WAIT_TIMEOUT_SECONDS, instance_poll_func

tests/integration/volumes/test_volumes.py

@@ -10,7 +10,7 @@
     exec_test_command,
     get_random_text,
 )
-from tests.integration.volumes.fixtures import volume_instance_id  # noqa: #401
+from tests.integration.volumes.fixtures import volume_instance_id  # noqa: F401
 
 
 def test_fail_to_create_volume_under_10gb():