[feat] Remove annotation in favor of well-known label

Author: tchinmai7

.github/copilot-instructions.md

@@ -110,7 +110,7 @@ make mockgen
 
 ## Common Gotchas
 - NodeBalancer backends require VPC configuration when `Options.VPCNames` is set
-- Node exclusion annotation: `node.k8s.linode.com/exclude-from-nb`
+- Node exclusion label: `node.kubernetes.io/exclude-from-external-load-balancers=true`
 - Port configurations must be valid JSON in annotations
 - Health check types depend on protocol (UDP vs TCP/HTTP)
 - Instance cache is global and shared across controllers

cloud/annotations/annotations.go

@@ -47,7 +47,6 @@ const (
 	AnnLinodeNodePublicIPv6 = "node.k8s.linode.com/public-ipv6"
 
 	AnnLinodeNodeIPSharingUpdated = "node.k8s.linode.com/ip-sharing-updated"
-	AnnExcludeNodeFromNb          = "node.k8s.linode.com/exclude-from-nb"
 
 	NodeBalancerBackendIPv4Range = "service.beta.kubernetes.io/linode-loadbalancer-backend-ipv4-range"
 

cloud/linode/loadbalancers.go

@@ -506,10 +506,6 @@ func (l *loadbalancers) updateNodeBalancer(
 			subnetID = id
 		}
 		for _, node := range nodes {
-			if _, ok := node.Annotations[annotations.AnnExcludeNodeFromNb]; ok {
-				klog.Infof("Node %s is excluded from NodeBalancer by annotation, skipping", node.Name)
-				continue
-			}
 			var newNodeOpts *linodego.NodeBalancerConfigRebuildNodeOptions
 			newNodeOpts, err = l.buildNodeBalancerNodeConfigRebuildOptions(node, port.NodePort, subnetID, newNBCfg.Protocol)
 			if err != nil {
@@ -1087,10 +1083,6 @@ func (l *loadbalancers) buildLoadBalancerRequest(ctx context.Context, clusterNam
 		createOpt := config.GetCreateOptions()
 
 		for _, node := range nodes {
-			if _, ok := node.Annotations[annotations.AnnExcludeNodeFromNb]; ok {
-				klog.Infof("Node %s is excluded from NodeBalancer by annotation, skipping", node.Name)
-				continue
-			}
 			newNodeOpts, err := l.buildNodeBalancerNodeConfigRebuildOptions(node, port.NodePort, subnetID, config.Protocol)
 			if err != nil {
 				sentry.CaptureError(ctx, err)

cloud/linode/loadbalancers_test.go

@@ -4711,8 +4711,8 @@ func testUpdateLoadBalancerNodeExcludedByAnnotation(t *testing.T, client *linode
 		{
 			ObjectMeta: metav1.ObjectMeta{
 				Name: "node-2",
-				Annotations: map[string]string{
-					annotations.AnnExcludeNodeFromNb: "true",
+				Labels: map[string]string{
+					v1.LabelNodeExcludeBalancers: "true",
 				},
 			},
 			Status: v1.NodeStatus{
@@ -4764,8 +4764,8 @@ func testUpdateLoadBalancerNodeExcludedByAnnotation(t *testing.T, client *linode
 		{
 			ObjectMeta: metav1.ObjectMeta{
 				Name: "node-1",
-				Annotations: map[string]string{
-					annotations.AnnExcludeNodeFromNb: "true", // Now exclude node-1
+				Labels: map[string]string{
+					v1.LabelNodeExcludeBalancers: "true",
 				},
 			},
 			Status: v1.NodeStatus{
@@ -4780,8 +4780,8 @@ func testUpdateLoadBalancerNodeExcludedByAnnotation(t *testing.T, client *linode
 		{
 			ObjectMeta: metav1.ObjectMeta{
 				Name: "node-2",
-				Annotations: map[string]string{
-					annotations.AnnExcludeNodeFromNb: "true", // Still excluded
+				Labels: map[string]string{
+					v1.LabelNodeExcludeBalancers: "true",
 				},
 			},
 			Status: v1.NodeStatus{
@@ -4833,8 +4833,8 @@ func testUpdateLoadBalancerNodeExcludedByAnnotation(t *testing.T, client *linode
 		{
 			ObjectMeta: metav1.ObjectMeta{
 				Name: "node-1",
-				Annotations: map[string]string{
-					annotations.AnnExcludeNodeFromNb: "true",
+				Labels: map[string]string{
+					v1.LabelNodeExcludeBalancers: "true",
 				},
 			},
 			Status: v1.NodeStatus{
@@ -4849,8 +4849,8 @@ func testUpdateLoadBalancerNodeExcludedByAnnotation(t *testing.T, client *linode
 		{
 			ObjectMeta: metav1.ObjectMeta{
 				Name: "node-2",
-				Annotations: map[string]string{
-					annotations.AnnExcludeNodeFromNb: "true",
+				Labels: map[string]string{
+					v1.LabelNodeExcludeBalancers: "true",
 				},
 			},
 			Status: v1.NodeStatus{
@@ -4865,8 +4865,8 @@ func testUpdateLoadBalancerNodeExcludedByAnnotation(t *testing.T, client *linode
 		{
 			ObjectMeta: metav1.ObjectMeta{
 				Name: "node-3",
-				Annotations: map[string]string{
-					annotations.AnnExcludeNodeFromNb: "true",
+				Labels: map[string]string{
+					v1.LabelNodeExcludeBalancers: "true",
 				},
 			},
 			Status: v1.NodeStatus{

docs/configuration/loadbalancer.md

@@ -255,15 +255,15 @@ metadata:
 ```
 
 ### Excluding nodes from nodebalancer
-Add the an annotation to the node object to exclude
+Add the a label to the node object to exclude
 
 ```yaml
 apiVersion: v1
 kind: Node
 metadata:
   name: node-to-exclude
-  annotations:
-    node.k8s.linode.com/exclude-from-nb: "true"
+  labels:
+    node.kubernetes.io/exclude-from-external-load-balancers: "true"
 ```
 
 ## Related Documentation