vet should be part of build and test, remove extra test in GHA

Author: AshleyDumaine

.github/workflows/build-test.yml

@@ -1,4 +1,4 @@
-name: Build Test
+name: Build
 on:
   push:
     branches:
@@ -11,7 +11,7 @@ permissions:
   actions: read
 
 concurrency:
-  group: build-test-${{ github.event.pull_request.number || github.ref_name }}
+  group: build-${{ github.event.pull_request.number || github.ref_name }}
   cancel-in-progress: true
 
 jobs:
@@ -60,29 +60,24 @@ jobs:
             ingest.codecov.io:443
             get.helm.sh:443
             golangci-lint.run:443
+            dl.k8s.io:443
+            cdn.dl.k8s.io:443
 
       - uses: actions/checkout@v5
         with:
           fetch-depth: 0
+
       - uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           check-latest: true
 
-      - name: Vet
-        run: make vet
-
-      - name: lint
-        uses: golangci/golangci-lint-action@v8
-        with:
-          version: v2.1.5
+      - name: Lint
+        run: make lint
 
       - name: Helm Lint
         run: make helm-lint
 
-      - name: Test
-        run: make test
-
       - name: Build
         run: make build
 

.github/workflows/ci.yml

@@ -60,10 +60,13 @@ jobs:
             cli.codecov.io:443
             api.codecov.io:443
             ingest.codecov.io:443
+            dl.k8s.io:443
+            cdn.dl.k8s.io:443
 
       - uses: actions/checkout@v5
         with:
           ref: ${{ github.event.pull_request.head.sha }}
+
       - uses: actions/setup-go@v6
         with:
           go-version-file: go.mod

Makefile

@@ -101,22 +101,22 @@ codegen:
 
 .PHONY: test
 # we say code is not worth testing unless it's formatted
-test: fmt codegen
+test: fmt codegen vet
 	go test -v -coverpkg=./sentry,./cloud/linode/client,./cloud/linode,./cloud/linode/utils,./cloud/linode/services,./cloud/nodeipam,./cloud/nodeipam/ipam -coverprofile ./coverage.out -cover ./sentry/... ./cloud/... $(TEST_ARGS)
 
 ## --------------------------------------
 ## Build
 ## --------------------------------------
 
 .PHONY: build-linux
-build-linux: codegen
+build-linux: codegen fmt vet
 	echo "cross compiling linode-cloud-controller-manager for linux/amd64" && \
 		GOOS=linux GOARCH=amd64 \
 		CGO_ENABLED=0 \
 		go build -o dist/linode-cloud-controller-manager-linux-amd64 .
 
 .PHONY: build
-build: codegen
+build: codegen fmt vet
 	echo "compiling linode-cloud-controller-manager" && \
 		CGO_ENABLED=0 \
 		go build -o dist/linode-cloud-controller-manager .