Add test for LoadBalancer Service with 2 ports

Author: Fahim Abrar

e2e/test/ccm_e2e_test.go

@@ -2,13 +2,13 @@ package test
 
 import (
 	"e2e_test/test/framework"
-	"fmt"
 	"github.com/appscode/go/wait"
 	"github.com/codeskyblue/go-sh"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 	core "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
+	"log"
 	"strings"
 )
 
@@ -69,7 +69,7 @@ var _ = Describe("CloudControllerManager", func() {
 		Expect(err).NotTo(HaveOccurred())
 	}
 
-	PDescribe("Test", func() {
+	Describe("Test", func() {
 		Context("Simple", func() {
 			Context("Load Balancer", func() {
 				var (
@@ -128,10 +128,10 @@ var _ = Describe("CloudControllerManager", func() {
 						}
 						stringResp := string(resp)
 						if strings.Contains(stringResp, pods[0]) {
-							fmt.Println("Got response from " + pods[0])
+							log.Println("Got response from " + pods[0])
 							counter1++
 						} else if strings.Contains(stringResp, pods[1]) {
-							fmt.Println("Got response from " + pods[1])
+							log.Println("Got response from " + pods[1])
 							counter2++
 						}
 
@@ -215,7 +215,7 @@ var _ = Describe("CloudControllerManager", func() {
 				})
 			})
 
-			Context("With Multiple TLS Port", func() {
+			Context("With Multiple TLS Ports", func() {
 				var (
 					pods        []string
 					labels      map[string]string
@@ -297,7 +297,71 @@ var _ = Describe("CloudControllerManager", func() {
 					}
 				})
 			})
+
+			Context("With Multiple HTTP Ports", func() {
+				var (
+					pods   []string
+					labels map[string]string
+				)
+
+				BeforeEach(func() {
+					pods = []string{"test-pod"}
+					ports := []core.ContainerPort{
+						{
+							Name:          "http-1",
+							ContainerPort: 8080,
+						},
+						{
+							Name:          "http-2",
+							ContainerPort: 8989,
+						},
+					}
+					servicePorts := []core.ServicePort{
+						{
+							Name:       "http-1",
+							Port:       80,
+							TargetPort: intstr.FromInt(8080),
+							Protocol:   "TCP",
+						},
+						{
+							Name:       "http-2",
+							Port:       8888,
+							TargetPort: intstr.FromInt(8989),
+							Protocol:   "TCP",
+						},
+					}
+					labels = map[string]string{
+						"app": "test-loadbalancer",
+					}
+
+					By("Creating Pods")
+					createPodWithLabel(pods, ports, framework.TestServerImage, labels, true)
+
+					By("Creating Service")
+					createServiceWithSelector(labels, servicePorts)
+				})
+
+				AfterEach(func() {
+					By("Deleting the Pods")
+					deletePods(pods)
+
+					By("Deleting the Service")
+					deleteService()
+				})
+
+				It("should reach all pods", func() {
+					By("Checking TCP Response")
+					eps, err := f.LoadBalancer.GetHTTPEndpoints()
+					Expect(err).NotTo(HaveOccurred())
+					Expect(len(eps)).Should(BeNumerically(">=", 1))
+
+					By("Waiting for Response from the LoadBalancer url: " + eps[0] + " " + eps[1])
+					for _, ep := range eps {
+						err = framework.WaitForHTTPResponse(ep, pods[0])
+						Expect(err).NotTo(HaveOccurred())
+					}
+				})
+			})
 		})
 	})
-
 })

e2e/test/framework/util.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"crypto/tls"
 	"crypto/x509"
-	"fmt"
 	"github.com/appscode/go/wait"
 	"github.com/golang/glog"
 	"io/ioutil"
@@ -115,7 +114,7 @@ func getHTTPSResponse(domain, ip, port string) (string, error) {
 	}
 	client := &http.Client{Transport: tr}
 
-	fmt.Println("Waiting for response from https://" + ip + ":" + port)
+	log.Println("Waiting for response from https://" + ip + ":" + port)
 	u := "https://" + domain + ":" + port
 	req, err := http.NewRequest(http.MethodGet, u, nil)
 	if err != nil {
@@ -136,9 +135,9 @@ func getHTTPSResponse(domain, ip, port string) (string, error) {
 	return bodyString, nil
 }
 
-func WaitForHTTPSResponse(ep string, podName string) error {
+func WaitForHTTPSResponse(link string, podName string) error {
 	return wait.PollImmediate(RetryInterval, RetryTimout, func() (bool, error) {
-		u, err := url.Parse(ep)
+		u, err := url.Parse(link)
 		if err != nil {
 			return false, nil
 		}
@@ -150,7 +149,37 @@ func WaitForHTTPSResponse(ep string, podName string) error {
 		}
 
 		if strings.Contains(resp, podName) {
-			fmt.Println("Got response from " + podName + " using url " + ep)
+			log.Println("Got response from " + podName + " using url " + link)
+			return true, nil
+		}
+
+		return false, nil
+	})
+}
+
+func getHTTPResponse(link string) (bool, string, error) {
+	resp, err := http.Get(link)
+	if err != nil {
+		return false, "", err
+	}
+	defer resp.Body.Close()
+
+	bodyBytes, err := ioutil.ReadAll(resp.Body)
+	if err != nil {
+		return false, "", err
+	}
+
+	return resp.StatusCode == 200, string(bodyBytes), nil
+}
+
+func WaitForHTTPResponse(link string, podName string) error {
+	return wait.PollImmediate(RetryInterval, RetryTimout, func() (bool, error) {
+		ok, _, err := getHTTPResponse(link)
+		if err != nil {
+			return false, nil
+		}
+		if ok {
+			log.Println("Got response from " + podName + " using url " + link)
 			return true, nil
 		}