Add warning for invalid NodeBalancer type annotation but still default to DefaultNBType

komer3 · komer3 · commit 5c9ac9e644f6 · 2025-12-29T10:49:48.000-06:00
diff --git a/cloud/linode/loadbalancers.go b/cloud/linode/loadbalancers.go
@@ -769,6 +769,9 @@ func (l *loadbalancers) GetLinodeNBType(service *v1.Service) linodego.NodeBalanc
 			return linodego.NBTypePremium
 		case linodego.NBTypePremium40GB:
 			return linodego.NBTypePremium40GB
+		default:
+			klog.Warningf("Invalid NodeBalancer type '%s' specified in annotation for service %s/%s. Valid types are: %s, %s, %s. Defaulting to %s.",
+				typeStr, service.Namespace, service.Name, linodego.NBTypeCommon, linodego.NBTypePremium, linodego.NBTypePremium40GB, options.Options.DefaultNBType)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -769,6 +769,9 @@ func (l loadbalancers) GetLinodeNBType(service v1.Service) linodego.NodeBalanc`
`769`	`769`	`return linodego.NBTypePremium`
`770`	`770`	`case linodego.NBTypePremium40GB:`
`771`	`771`	`return linodego.NBTypePremium40GB`
	`772`	`+ default:`
	`773`	`+ klog.Warningf("Invalid NodeBalancer type '%s' specified in annotation for service %s/%s. Valid types are: %s, %s, %s. Defaulting to %s.",`
	`774`	`+ typeStr, service.Namespace, service.Name, linodego.NBTypeCommon, linodego.NBTypePremium, linodego.NBTypePremium40GB, options.Options.DefaultNBType)`
`772`	`775`	`}`
`773`	`776`	`}`
`774`	`777`