Add dash after prefix

Author: adamginna-akamai

cloud/linode/cloud.go

@@ -72,7 +72,7 @@ type linodeCloud struct {
 var (
 	instanceCache     *instances
 	ipHolderCharLimit int = 23
-	LoadBalancerPrefixCharLimit int = 20
+	LoadBalancerPrefixCharLimit int = 19
 )
 
 func init() {

cloud/linode/cloud_test.go

@@ -127,14 +127,14 @@ func TestNewCloud(t *testing.T) {
 		assert.Error(t, err, "expected error if ipholdersuffix is longer than 23 chars")
 	})
 
-	t.Run("should fail if load-balancer-prefix is longer than 20 chars", func(t *testing.T) {
+	t.Run("should fail if load-balancer-prefix is longer than 19 chars", func(t *testing.T) {
 		prefix := Options.LoadBalancerPrefix
 		Options.LoadBalancerPrefix = strings.Repeat("a", 21)
 		defer func() {
 			Options.LoadBalancerPrefix = prefix
 		}()
 		_, err := newCloud()
-		assert.Error(t, err, "expected error if load-balancer-prefix is longer than 20 chars")
+		assert.Error(t, err, "expected error if load-balancer-prefix is longer than 19 chars")
 	})
 }
 

cloud/linode/loadbalancers.go

@@ -227,7 +227,7 @@ func (l *loadbalancers) cleanupOldNodeBalancer(ctx context.Context, service *v1.
 // GetLoadBalancer will not modify service.
 func (l *loadbalancers) GetLoadBalancerName(_ context.Context, _ string, _ *v1.Service) string {
 	unixNano := strconv.FormatInt(time.Now().UnixNano(), 16)
-	return fmt.Sprintf("%s%s", Options.LoadBalancerPrefix, unixNano[len(unixNano)-12:])
+	return fmt.Sprintf("%s-%s", Options.LoadBalancerPrefix, unixNano[len(unixNano)-12:])
 }
 
 // GetLoadBalancer returns the *v1.LoadBalancerStatus of service.

main.go

@@ -98,7 +98,7 @@ func main() {
 	command.Flags().IntVar(&linode.Options.NodeBalancerBackendIPv4SubnetID, "nodebalancer-backend-ipv4-subnet-id", 0, "ipv4 subnet id to use for NodeBalancer backends")
 	command.Flags().StringVar(&linode.Options.NodeBalancerBackendIPv4SubnetName, "nodebalancer-backend-ipv4-subnet-name", "", "ipv4 subnet name to use for NodeBalancer backends")
 	command.Flags().BoolVar(&linode.Options.DisableNodeBalancerVPCBackends, "disable-nodebalancer-vpc-backends", false, "disables nodebalancer backends in VPCs (when enabled, nodebalancers will only have private IPs as backends for backward compatibility)")
-	command.Flags().StringVar(&linode.Options.LoadBalancerPrefix, "load-balancer-prefix", "ccm-", "Name prefix for LoadBalancers. (max. 20 char.)")
+	command.Flags().StringVar(&linode.Options.LoadBalancerPrefix, "load-balancer-prefix", "ccm", "Name prefix for LoadBalancers. (max. 19 char.)")
 
 	// Set static flags
 	command.Flags().VisitAll(func(fl *pflag.Flag) {