add unittest to test processing older node requests

Author: Rahul Sharma

cloud/linode/node_controller.go

@@ -103,8 +103,9 @@ func (s *nodeController) Run(stopCh <-chan struct{}) {
 func (s *nodeController) addNodeToQueue(node *v1.Node) {
 	s.Lock()
 	defer s.Unlock()
-	s.nodeLastAdded[node.Name] = time.Now()
-	s.queue.Add(nodeRequest{node: node, timestamp: time.Now()})
+	currTime := time.Now()
+	s.nodeLastAdded[node.Name] = currTime
+	s.queue.Add(nodeRequest{node: node, timestamp: currTime})
 }
 
 // worker runs a worker thread that dequeues new or modified nodes and processes

cloud/linode/node_controller_test.go

@@ -100,6 +100,16 @@ func TestNodeController_processNext(t *testing.T) {
 		}
 	})
 
+	t.Run("should return no error if timestamp for node being processed is older than the most recent request", func(t *testing.T) {
+		controller.addNodeToQueue(node)
+		controller.nodeLastAdded["test"] = time.Now().Add(controller.ttl)
+		result := controller.processNext()
+		assert.True(t, result, "processNext should return true")
+		if queue.Len() != 0 {
+			t.Errorf("expected queue to be empty, got %d items", queue.Len())
+		}
+	})
+
 	t.Run("should return no error if node exists", func(t *testing.T) {
 		controller.addNodeToQueue(node)
 		publicIP := net.ParseIP("172.234.31.123")