Skip to content

Commit b632ca7

Browse files
authored
[fix] Fixed typo in Deployment template for S3 Secret reference (#234)
**What this PR does / why we need it**: Previously, when trying to use a reference to a Secret in `values.s3.secret.ref` when `values.s3.ephemeralCredentials` is set to `false`, the Secret name was not properly introduced into the Deployment template due to a typo. **Special notes for your reviewer**: See the template below https://github.com/linode/linode-cosi-driver/blob/a4fc2b520263ac798367a51082b5b887700431b3/helm/linode-cosi-driver/templates/_helpers.tpl#L114-L116 You will notice the `_helpers.tpl` file has it called `s3SecretName`. **TODOs**: - [X] squashed commits - [ ] includes documentation - [ ] adds unit tests - [ ] adds or updates e2e tests
1 parent ff740ed commit b632ca7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

helm/linode-cosi-driver/templates/Deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ spec:
6464
name: {{ include "linode-cosi-driver.secretName" . }}
6565
{{- if not .Values.s3.ephemeralCredentials }}
6666
- secretRef:
67-
name: {{ include "linode-cosi-driver.s3secretName" . }}
67+
name: {{ include "linode-cosi-driver.s3SecretName" . }}
6868
{{- end }}
6969
volumeMounts:
7070
- name: cosi-socket-dir

0 commit comments

Comments
 (0)