Skip to content

Commit 2e1fcf5

Browse files
Change types of interfaces create options slices to be pointers (#817)
* Change types of interfaces create options slices to be pointers * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
1 parent dac763f commit 2e1fcf5

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

interfaces.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ type PublicInterfaceCreateOptions struct {
132132
}
133133

134134
type PublicInterfaceIPv4CreateOptions struct {
135-
Addresses []PublicInterfaceIPv4AddressCreateOptions `json:"addresses,omitempty"`
135+
Addresses *[]PublicInterfaceIPv4AddressCreateOptions `json:"addresses,omitempty"`
136136
}
137137

138138
type PublicInterfaceIPv4AddressCreateOptions struct {
@@ -141,7 +141,7 @@ type PublicInterfaceIPv4AddressCreateOptions struct {
141141
}
142142

143143
type PublicInterfaceIPv6CreateOptions struct {
144-
Ranges []PublicInterfaceIPv6RangeCreateOptions `json:"ranges,omitempty"`
144+
Ranges *[]PublicInterfaceIPv6RangeCreateOptions `json:"ranges,omitempty"`
145145
}
146146

147147
type PublicInterfaceIPv6RangeCreateOptions struct {
@@ -155,8 +155,8 @@ type VPCInterfaceCreateOptions struct {
155155
}
156156

157157
type VPCInterfaceIPv4CreateOptions struct {
158-
Addresses []VPCInterfaceIPv4AddressCreateOptions `json:"addresses,omitempty"`
159-
Ranges []VPCInterfaceIPv4RangeCreateOptions `json:"ranges,omitempty"`
158+
Addresses *[]VPCInterfaceIPv4AddressCreateOptions `json:"addresses,omitempty"`
159+
Ranges *[]VPCInterfaceIPv4RangeCreateOptions `json:"ranges,omitempty"`
160160
}
161161

162162
type VPCInterfaceIPv4AddressCreateOptions struct {
@@ -172,9 +172,9 @@ type VPCInterfaceIPv4RangeCreateOptions struct {
172172
// VPCInterfaceIPv6CreateOptions specifies IPv6 configuration parameters for VPC creation.
173173
// NOTE: IPv6 interfaces may not currently be available to all users.
174174
type VPCInterfaceIPv6CreateOptions struct {
175-
SLAAC []VPCInterfaceIPv6SLAACCreateOptions `json:"slaac,omitempty"`
176-
Ranges []VPCInterfaceIPv6RangeCreateOptions `json:"ranges,omitempty"`
177-
IsPublic *bool `json:"is_public"`
175+
SLAAC *[]VPCInterfaceIPv6SLAACCreateOptions `json:"slaac,omitempty"`
176+
Ranges *[]VPCInterfaceIPv6RangeCreateOptions `json:"ranges,omitempty"`
177+
IsPublic *bool `json:"is_public"`
178178
}
179179

180180
// VPCInterfaceIPv6SLAACCreateOptions defines the IPv6 SLAAC configuration parameters for VPC creation.

test/integration/instance_interfaces_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ func TestInstance_CreateWithLinodeInterfaces(
102102
FirewallID: linodego.DoublePointer(firewallID),
103103
Public: &linodego.PublicInterfaceCreateOptions{
104104
IPv4: &linodego.PublicInterfaceIPv4CreateOptions{
105-
Addresses: []linodego.PublicInterfaceIPv4AddressCreateOptions{
105+
Addresses: &[]linodego.PublicInterfaceIPv4AddressCreateOptions{
106106
{
107107
Address: linodego.Pointer("auto"),
108108
Primary: linodego.Pointer(true),
@@ -117,7 +117,7 @@ func TestInstance_CreateWithLinodeInterfaces(
117117
VPC: &linodego.VPCInterfaceCreateOptions{
118118
SubnetID: vpcSubnet.ID,
119119
IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
120-
Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{
120+
Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{
121121
{
122122
Address: linodego.Pointer("auto"),
123123
Primary: linodego.Pointer(true),

test/unit/interface_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ func TestInterface_CreatePublic(t *testing.T) {
158158
opts := linodego.LinodeInterfaceCreateOptions{
159159
Public: &linodego.PublicInterfaceCreateOptions{
160160
IPv4: &linodego.PublicInterfaceIPv4CreateOptions{
161-
Addresses: []linodego.PublicInterfaceIPv4AddressCreateOptions{
161+
Addresses: &[]linodego.PublicInterfaceIPv4AddressCreateOptions{
162162
{
163163
Address: linodego.Pointer("auto"),
164164
Primary: linodego.Pointer(true),
@@ -227,13 +227,13 @@ func TestInterface_UpdateVPC(t *testing.T) {
227227
},
228228
VPC: &linodego.VPCInterfaceCreateOptions{
229229
IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
230-
Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{
230+
Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{
231231
{
232232
Address: linodego.Pointer("192.168.23.4"),
233233
Primary: linodego.Pointer(true),
234234
},
235235
},
236-
Ranges: []linodego.VPCInterfaceIPv4RangeCreateOptions{
236+
Ranges: &[]linodego.VPCInterfaceIPv4RangeCreateOptions{
237237
{
238238
Range: "192.168.23.16/28",
239239
},
@@ -243,14 +243,14 @@ func TestInterface_UpdateVPC(t *testing.T) {
243243
},
244244
},
245245
IPv6: &linodego.VPCInterfaceIPv6CreateOptions{
246-
SLAAC: []linodego.VPCInterfaceIPv6SLAACCreateOptions{
246+
SLAAC: &[]linodego.VPCInterfaceIPv6SLAACCreateOptions{
247247
{
248248
Range: "1235::/64",
249249
},
250250
},
251-
Ranges: []linodego.VPCInterfaceIPv6RangeCreateOptions{
251+
Ranges: &[]linodego.VPCInterfaceIPv6RangeCreateOptions{
252252
{
253-
"4322::/64",
253+
Range: "4322::/64",
254254
},
255255
},
256256
},

0 commit comments

Comments
 (0)