Remove AddPlacementGroups user grant (#810)

* Remove AddPlacementGroups user grant

* golangci-lint fmt

* Remove from unit test

Author: zliang-akamai

account_user_grants.go

@@ -20,7 +20,6 @@ type GlobalUserGrants struct {
 	AddLinodes           bool                  `json:"add_linodes"`
 	AddLongview          bool                  `json:"add_longview"`
 	AddNodeBalancers     bool                  `json:"add_nodebalancers"`
-	AddPlacementGroups   bool                  `json:"add_placement_groups"`
 	AddStackScripts      bool                  `json:"add_stackscripts"`
 	AddVolumes           bool                  `json:"add_volumes"`
 	AddVPCs              bool                  `json:"add_vpcs"`

test/integration/account_user_grants_test.go

@@ -23,19 +23,18 @@ func TestUserGrants_Update(t *testing.T) {
 	accessLevel := linodego.AccessLevelReadOnly
 
 	globalGrants := linodego.GlobalUserGrants{
-		AccountAccess:      &accessLevel,
-		AddDomains:         false,
-		AddDatabases:       true,
-		AddFirewalls:       true,
-		AddImages:          true,
-		AddLinodes:         false,
-		AddLongview:        true,
-		AddNodeBalancers:   false,
-		AddPlacementGroups: false,
-		AddStackScripts:    true,
-		AddVolumes:         true,
-		AddVPCs:            true,
-		CancelAccount:      false,
+		AccountAccess:    &accessLevel,
+		AddDomains:       false,
+		AddDatabases:     true,
+		AddFirewalls:     true,
+		AddImages:        true,
+		AddLinodes:       false,
+		AddLongview:      true,
+		AddNodeBalancers: false,
+		AddStackScripts:  true,
+		AddVolumes:       true,
+		AddVPCs:          true,
+		CancelAccount:    false,
 	}
 
 	grants, err := client.UpdateUserGrants(context.TODO(), username, linodego.UserGrantsUpdateOptions{

test/integration/fixtures/TestUserGrants_Update.yaml

@@ -65,7 +65,7 @@ interactions:
     code: 200
     duration: ""
 - request:
-    body: '{"global":{"account_access":"read_only","add_databases":true,"add_domains":false,"add_firewalls":true,"add_images":true,"add_linodes":false,"add_longview":true,"add_nodebalancers":false,"add_placement_groups":false,"add_stackscripts":true,"add_volumes":true,"add_vpcs":true,"cancel_account":false,"child_account_access":false,"longview_subscription":false}}'
+    body: '{"global":{"account_access":"read_only","add_databases":true,"add_domains":false,"add_firewalls":true,"add_images":true,"add_linodes":false,"add_longview":true,"add_nodebalancers":false,"add_stackscripts":true,"add_volumes":true,"add_vpcs":true,"cancel_account":false,"child_account_access":false,"longview_subscription":false}}'
     form: {}
     headers:
       Accept:

test/integration/fixtures/TestUserGrants_UpdateNoAccess.yaml

@@ -65,7 +65,7 @@ interactions:
     code: 200
     duration: ""
 - request:
-    body: '{"global":{"account_access":null,"add_databases":false,"add_domains":false,"add_firewalls":false,"add_images":false,"add_linodes":false,"add_longview":false,"add_nodebalancers":false,"add_placement_groups":false,"add_stackscripts":false,"add_volumes":false,"add_vpcs":false,"cancel_account":false,"child_account_access":false,"longview_subscription":false}}'
+    body: '{"global":{"account_access":null,"add_databases":false,"add_domains":false,"add_firewalls":false,"add_images":false,"add_linodes":false,"add_longview":false,"add_nodebalancers":false,"add_stackscripts":false,"add_volumes":false,"add_vpcs":false,"cancel_account":false,"child_account_access":false,"longview_subscription":false}}'
     form: {}
     headers:
       Accept:

test/integration/vpc_test.go

@@ -6,10 +6,9 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/stretchr/testify/require"
-
 	"github.com/linode/linodego"
 	. "github.com/linode/linodego"
+	"github.com/stretchr/testify/require"
 )
 
 type vpcModifier func(*linodego.Client, *linodego.VPCCreateOptions)

test/unit/account_user_grants_test.go

@@ -64,7 +64,6 @@ func TestAccountUserGrants_Get(t *testing.T) {
 	assert.Equal(t, true, grants.Global.AddLinodes)
 	assert.Equal(t, true, grants.Global.AddLongview)
 	assert.Equal(t, true, grants.Global.AddNodeBalancers)
-	assert.Equal(t, true, grants.Global.AddPlacementGroups)
 	assert.Equal(t, true, grants.Global.AddStackScripts)
 	assert.Equal(t, true, grants.Global.AddVolumes)
 	assert.Equal(t, true, grants.Global.AddVPCs)
@@ -135,7 +134,6 @@ func TestAccountGrants_Update(t *testing.T) {
 	assert.Equal(t, true, grants.Global.AddLinodes)
 	assert.Equal(t, true, grants.Global.AddLongview)
 	assert.Equal(t, true, grants.Global.AddNodeBalancers)
-	assert.Equal(t, true, grants.Global.AddPlacementGroups)
 	assert.Equal(t, true, grants.Global.AddStackScripts)
 	assert.Equal(t, true, grants.Global.AddVolumes)
 	assert.Equal(t, true, grants.Global.AddVPCs)

test/unit/fixtures/account_user_grants_get.json

@@ -29,7 +29,6 @@
     "add_linodes": true,
     "add_longview": true,
     "add_nodebalancers": true,
-    "add_placement_groups": true,
     "add_stackscripts": true,
     "add_volumes": true,
     "add_vpcs": true,

test/unit/fixtures/account_user_grants_update.json

@@ -29,7 +29,6 @@
     "add_linodes": true,
     "add_longview": true,
     "add_nodebalancers": true,
-    "add_placement_groups": true,
     "add_stackscripts": true,
     "add_volumes": true,
     "add_vpcs": true,

test/unit/fixtures/profile_grants_list.json

@@ -29,7 +29,6 @@
     "add_linodes": true,
     "add_longview": true,
     "add_nodebalancers": true,
-    "add_placement_groups": true,
     "add_stackscripts": true,
     "add_volumes": true,
     "add_vpcs": true,

test/unit/interface_test.go

@@ -4,10 +4,9 @@ import (
 	"context"
 	"testing"
 
-	"github.com/stretchr/testify/require"
-
 	"github.com/linode/linodego"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestInterface_Get(t *testing.T) {