Remove stale workflow; fix lint (#843)

zliang-akamai · Copilot · web-flow · commit fec54e0f24bf · 2025-11-05T13:19:45.000-05:00
* Add keep and stale label

* Update .github/labels.yml

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* Update .github/labels.yml

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;

* Fix lint

* Fix more lint issues

* Remove no effect omitempty

* Change `omitempty` to `omitzero` for `Devices` field in `FirewallCreateOptions`

* Remove stale workflow completely

---------

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
diff --git a/account_events.go b/account_events.go
@@ -339,6 +339,7 @@ func (c *Client) GetEvent(ctx context.Context, eventID int) (*Event, error) {
 }
 
 // MarkEventRead marks a single Event as read.
+//
 // Deprecated: `MarkEventRead` is a deprecated API, please consider using `MarkEventsSeen` instead.
 // Please note that the `MarkEventsSeen` API functions differently and will mark all events up to and
 // including the referenced event-id as "seen" rather than individual events.
diff --git a/account_payment_methods.go b/account_payment_methods.go
@@ -24,7 +24,7 @@ type PaymentMethod struct {
 	Type string `json:"type"`
 
 	// The detailed data for the Payment Method, which can be of varying types.
-	Data interface{} `json:"data"`
+	Data any `json:"data"`
 }
 
 // PaymentMethodDataCreditCard represents a PaymentMethodDataCreditCard object
diff --git a/client.go b/client.go
@@ -405,7 +405,7 @@ func (c *httpClient) logRequest(req *http.Request, method, url string, bodyBuffe
 
 	var logBuf bytes.Buffer
 
-	err := reqLogTemplate.Execute(&logBuf, map[string]interface{}{
+	err := reqLogTemplate.Execute(&logBuf, map[string]any{
 		"Method":  method,
 		"URL":     url,
 		"Headers": req.Header,
@@ -453,7 +453,7 @@ func (c *httpClient) logResponse(resp *http.Response) (*http.Response, error) {
 
 	var logBuf bytes.Buffer
 
-	err := respLogTemplate.Execute(&logBuf, map[string]interface{}{
+	err := respLogTemplate.Execute(&logBuf, map[string]any{
 		"Status":  resp.Status,
 		"Headers": resp.Header,
 		"Body":    respBody.String(),
@@ -468,7 +468,7 @@ func (c *httpClient) logResponse(resp *http.Response) (*http.Response, error) {
 }
 
 // nolint:unused
-func (c *httpClient) decodeResponseBody(resp *http.Response, response interface{}) error {
+func (c *httpClient) decodeResponseBody(resp *http.Response, response any) error {
 	if err := json.NewDecoder(resp.Body).Decode(response); err != nil {
 		if c.debug && c.logger != nil {
 			c.logger.Errorf("failed to decode response: %v", err)
diff --git a/errors.go b/errors.go
@@ -7,6 +7,7 @@ import (
 	"io"
 	"net/http"
 	"reflect"
+	"slices"
 	"strings"
 
 	"github.com/go-resty/resty/v2"
@@ -227,11 +228,6 @@ func ErrHasStatus(err error, code ...int) bool {
 	}
 
 	ec := e.StatusCode()
-	for _, c := range code {
-		if ec == c {
-			return true
-		}
-	}
 
-	return false
+	return slices.Contains(code, ec)
 }
diff --git a/firewalls.go b/firewalls.go
@@ -41,7 +41,7 @@ type FirewallCreateOptions struct {
 	Label   string                 `json:"label,omitempty"`
 	Rules   FirewallRuleSet        `json:"rules"`
 	Tags    []string               `json:"tags,omitempty"`
-	Devices DevicesCreationOptions `json:"devices,omitempty"`
+	Devices DevicesCreationOptions `json:"devices,omitzero"`
 }
 
 // FirewallUpdateOptions is an options struct used when Updating a Firewall
diff --git a/instances.go b/instances.go
@@ -110,7 +110,7 @@ type InstanceBackup struct {
 	Schedule       struct {
 		Day    string `json:"day,omitempty"`
 		Window string `json:"window,omitempty"`
-	} `json:"schedule,omitempty"`
+	} `json:"schedule"`
 }
 
 type InstanceDiskEncryption string
@@ -132,8 +132,9 @@ type InstanceTransfer struct {
 	Quota int `json:"quota"`
 }
 
-// MonthlyInstanceTransferStats pool stats for a Linode Instance network transfer statistics for a specific month
 // Deprecated: use MonthlyInstanceTransferStatsV2 for new implementations
+//
+// MonthlyInstanceTransferStats pool stats for a Linode Instance network transfer statistics for a specific month
 type MonthlyInstanceTransferStats struct {
 	// The amount of inbound public network traffic received by this Linode, in bytes, for a specific year/month.
 	BytesIn int `json:"bytes_in"`
diff --git a/internal/testutil/mock.go b/internal/testutil/mock.go
@@ -92,9 +92,9 @@ func CreateMockClient[T any](t *testing.T, createFunc func(*http.Client) T) *T {
 }
 
 type Logger interface {
-	Errorf(format string, v ...interface{})
-	Warnf(format string, v ...interface{})
-	Debugf(format string, v ...interface{})
+	Errorf(format string, v ...any)
+	Warnf(format string, v ...any)
+	Debugf(format string, v ...any)
 }
 
 func CreateLogger() *TestLogger {
@@ -108,19 +108,19 @@ type TestLogger struct {
 	L *log.Logger
 }
 
-func (l *TestLogger) Errorf(format string, v ...interface{}) {
+func (l *TestLogger) Errorf(format string, v ...any) {
 	l.outputf("ERROR RESTY "+format, v...)
 }
 
-func (l *TestLogger) Warnf(format string, v ...interface{}) {
+func (l *TestLogger) Warnf(format string, v ...any) {
 	l.outputf("WARN RESTY "+format, v...)
 }
 
-func (l *TestLogger) Debugf(format string, v ...interface{}) {
+func (l *TestLogger) Debugf(format string, v ...any) {
 	l.outputf("DEBUG RESTY "+format, v...)
 }
 
-func (l *TestLogger) outputf(format string, v ...interface{}) {
+func (l *TestLogger) outputf(format string, v ...any) {
 	if len(v) == 0 {
 		l.L.Print(format)
 		return
diff --git a/logger.go b/logger.go
@@ -7,9 +7,9 @@ import (
 
 //nolint:unused
 type httpLogger interface {
-	Errorf(format string, v ...interface{})
-	Warnf(format string, v ...interface{})
-	Debugf(format string, v ...interface{})
+	Errorf(format string, v ...any)
+	Warnf(format string, v ...any)
+	Debugf(format string, v ...any)
 }
 
 //nolint:unused
@@ -27,22 +27,22 @@ func createLogger() *logger {
 var _ httpLogger = (*logger)(nil)
 
 //nolint:unused
-func (l *logger) Errorf(format string, v ...interface{}) {
+func (l *logger) Errorf(format string, v ...any) {
 	l.output("ERROR RESTY "+format, v...)
 }
 
 //nolint:unused
-func (l *logger) Warnf(format string, v ...interface{}) {
+func (l *logger) Warnf(format string, v ...any) {
 	l.output("WARN RESTY "+format, v...)
 }
 
 //nolint:unused
-func (l *logger) Debugf(format string, v ...interface{}) {
+func (l *logger) Debugf(format string, v ...any) {
 	l.output("DEBUG RESTY "+format, v...)
 }
 
 //nolint:unused
-func (l *logger) output(format string, v ...interface{}) { //nolint:goprintffuncname
+func (l *logger) output(format string, v ...any) { //nolint:goprintffuncname
 	if len(v) == 0 {
 		l.l.Print(format)
 		return
diff --git a/monitor_api_services.go b/monitor_api_services.go
@@ -93,8 +93,8 @@ type MetricRelativeTimeDuration struct {
 
 // MetricAbsoluteTimeDuration specifies an absolute time range for data queries
 type MetricAbsoluteTimeDuration struct {
-	Start time.Time `json:"start,omitempty"`
-	End   time.Time `json:"end,omitempty"`
+	Start time.Time `json:"start"`
+	End   time.Time `json:"end"`
 }
 
 // FetchEntityMetrics returns metrics information for the individual entities within a specific service type
diff --git a/mysql.go b/mysql.go
@@ -431,6 +431,7 @@ type MySQLUpdateOptions struct {
 }
 
 // MySQLDatabaseBackup is information for interacting with a backup for the existing MySQL Database
+
 // Deprecated: MySQLDatabaseBackup is a deprecated struct, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 type MySQLDatabaseBackup struct {
@@ -441,6 +442,7 @@ type MySQLDatabaseBackup struct {
 }
 
 // MySQLBackupCreateOptions are options used for CreateMySQLDatabaseBackup(...)
+//
 // Deprecated: MySQLBackupCreateOptions is a deprecated struct, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 type MySQLBackupCreateOptions struct {
@@ -485,6 +487,7 @@ func (c *Client) ListMySQLDatabases(ctx context.Context, opts *ListOptions) ([]M
 }
 
 // ListMySQLDatabaseBackups lists all MySQL Database Backups associated with the given MySQL Database
+//
 // Deprecated: ListMySQLDatabaseBackups is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) ListMySQLDatabaseBackups(ctx context.Context, databaseID int, opts *ListOptions) ([]MySQLDatabaseBackup, error) {
@@ -533,6 +536,7 @@ func (c *Client) ResetMySQLDatabaseCredentials(ctx context.Context, databaseID i
 }
 
 // GetMySQLDatabaseBackup returns a specific MySQL Database Backup with the given ids
+//
 // Deprecated: GetMySQLDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) GetMySQLDatabaseBackup(ctx context.Context, databaseID int, backupID int) (*MySQLDatabaseBackup, error) {
@@ -541,6 +545,7 @@ func (c *Client) GetMySQLDatabaseBackup(ctx context.Context, databaseID int, bac
 }
 
 // RestoreMySQLDatabaseBackup returns the given MySQL Database with the given Backup
+//
 // Deprecated: RestoreMySQLDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) RestoreMySQLDatabaseBackup(ctx context.Context, databaseID int, backupID int) error {
@@ -549,6 +554,7 @@ func (c *Client) RestoreMySQLDatabaseBackup(ctx context.Context, databaseID int,
 }
 
 // CreateMySQLDatabaseBackup creates a snapshot for the given MySQL database
+//
 // Deprecated: CreateMySQLDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) CreateMySQLDatabaseBackup(ctx context.Context, databaseID int, opts MySQLBackupCreateOptions) error {
diff --git a/network_ips.go b/network_ips.go
@@ -17,6 +17,7 @@ type IPAddressUpdateOptionsV2 struct {
 }
 
 // IPAddressUpdateOptions fields are those accepted by UpdateIPAddress.
+//
 // Deprecated: Please use IPAddressUpdateOptionsV2 for all new implementations.
 type IPAddressUpdateOptions struct {
 	RDNS *string `json:"rdns"`
@@ -66,6 +67,7 @@ func (i InstanceIP) GetUpdateOptionsV2() IPAddressUpdateOptionsV2 {
 }
 
 // GetUpdateOptions converts a IPAddress to IPAddressUpdateOptions for use in UpdateIPAddress.
+//
 // Deprecated: Please use GetUpdateOptionsV2 for all new implementations.
 func (i InstanceIP) GetUpdateOptions() (o IPAddressUpdateOptions) {
 	o.RDNS = copyString(&i.RDNS)
@@ -90,6 +92,7 @@ func (c *Client) UpdateIPAddressV2(ctx context.Context, address string, opts IPA
 }
 
 // UpdateIPAddress updates the IP address with the specified id.
+//
 // Deprecated: Please use UpdateIPAddressV2 for all new implementation.
 func (c *Client) UpdateIPAddress(ctx context.Context, id string, opts IPAddressUpdateOptions) (*InstanceIP, error) {
 	e := formatAPIPath("networking/ips/%s", id)
diff --git a/object_storage_bucket_certs.go b/object_storage_bucket_certs.go
@@ -19,6 +19,7 @@ type ObjectStorageBucketCertUploadOptions struct {
 }
 
 // UploadObjectStorageBucketCert uploads a TLS/SSL Cert to be used with an Object Storage Bucket.
+//
 // Deprecated: Please use UploadObjectStorageBucketCertV2 for all new implementations.
 func (c *Client) UploadObjectStorageBucketCert(
 	ctx context.Context,
@@ -30,6 +31,7 @@ func (c *Client) UploadObjectStorageBucketCert(
 }
 
 // GetObjectStorageBucketCert gets an ObjectStorageBucketCert
+//
 // Deprecated: Please use GetObjectStorageBucketCertV2 for all new implementations.
 func (c *Client) GetObjectStorageBucketCert(ctx context.Context, clusterOrRegionID, bucket string) (*ObjectStorageBucketCert, error) {
 	e := formatAPIPath("object-storage/buckets/%s/%s/ssl", clusterOrRegionID, bucket)
diff --git a/object_storage_buckets.go b/object_storage_buckets.go
@@ -147,6 +147,7 @@ func (c *Client) CreateObjectStorageBucket(ctx context.Context, opts ObjectStora
 }
 
 // GetObjectStorageBucketAccess gets the current access config for a bucket
+//
 // Deprecated: use GetObjectStorageBucketAccessV2 for new implementations
 func (c *Client) GetObjectStorageBucketAccess(ctx context.Context, clusterOrRegionID, label string) (*ObjectStorageBucketAccess, error) {
 	e := formatAPIPath("object-storage/buckets/%s/%s/access", clusterOrRegionID, label)
diff --git a/postgres.go b/postgres.go
@@ -648,6 +648,7 @@ func (c *Client) ListPostgresDatabases(ctx context.Context, opts *ListOptions) (
 }
 
 // PostgresDatabaseBackup is information for interacting with a backup for the existing Postgres Database
+//
 // Deprecated: PostgresDatabaseBackup is a deprecated struct, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 type PostgresDatabaseBackup struct {
@@ -678,6 +679,7 @@ func (d *PostgresDatabaseBackup) UnmarshalJSON(b []byte) error {
 }
 
 // PostgresBackupCreateOptions are options used for CreatePostgresDatabaseBackup(...)
+//
 // Deprecated: PostgresBackupCreateOptions is a deprecated struct, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 type PostgresBackupCreateOptions struct {
@@ -686,6 +688,7 @@ type PostgresBackupCreateOptions struct {
 }
 
 // ListPostgresDatabaseBackups lists all Postgres Database Backups associated with the given Postgres Database
+//
 // Deprecated: ListPostgresDatabaseBackups is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) ListPostgresDatabaseBackups(ctx context.Context, databaseID int, opts *ListOptions) ([]PostgresDatabaseBackup, error) {
@@ -740,6 +743,7 @@ func (c *Client) GetPostgresDatabaseSSL(ctx context.Context, databaseID int) (*P
 }
 
 // GetPostgresDatabaseBackup returns a specific Postgres Database Backup with the given ids
+//
 // Deprecated: GetPostgresDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) GetPostgresDatabaseBackup(ctx context.Context, databaseID int, backupID int) (*PostgresDatabaseBackup, error) {
@@ -748,6 +752,7 @@ func (c *Client) GetPostgresDatabaseBackup(ctx context.Context, databaseID int,
 }
 
 // RestorePostgresDatabaseBackup returns the given Postgres Database with the given Backup
+//
 // Deprecated: RestorePostgresDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) RestorePostgresDatabaseBackup(ctx context.Context, databaseID int, backupID int) error {
@@ -756,6 +761,7 @@ func (c *Client) RestorePostgresDatabaseBackup(ctx context.Context, databaseID i
 }
 
 // CreatePostgresDatabaseBackup creates a snapshot for the given Postgres database
+//
 // Deprecated: CreatePostgresDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (c *Client) CreatePostgresDatabaseBackup(ctx context.Context, databaseID int, opts PostgresBackupCreateOptions) error {
diff --git a/profile_preferences.go b/profile_preferences.go
@@ -8,11 +8,11 @@ import (
 // ProfilePreferences represents the user's preferences.
 // The user preferences endpoints allow consumers of the API to store arbitrary JSON data,
 // such as a user's font size preference or preferred display name.
-type ProfilePreferences map[string]interface{}
+type ProfilePreferences map[string]any
 
 // UnmarshalJSON implements the json.Unmarshaler interface
 func (p *ProfilePreferences) UnmarshalJSON(b []byte) error {
-	var data map[string]interface{}
+	var data map[string]any
 	if err := json.Unmarshal(b, &data); err != nil {
 		return err
 	}
diff --git a/request_helpers.go b/request_helpers.go
@@ -297,7 +297,7 @@ func formatAPIPath(format string, args ...any) string {
 	return fmt.Sprintf(format, escapedArgs...)
 }
 
-func isNil(i interface{}) bool {
+func isNil(i any) bool {
 	if i == nil {
 		return true
 	}
diff --git a/waitfor.go b/waitfor.go
@@ -490,6 +490,7 @@ func (client Client) WaitForImageRegionStatus(ctx context.Context, imageID, regi
 }
 
 // WaitForMySQLDatabaseBackup waits for the backup with the given label to be available.
+//
 // Deprecated: WaitForMySQLDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (client Client) WaitForMySQLDatabaseBackup(ctx context.Context, dbID int, label string, timeoutSeconds int) (*MySQLDatabaseBackup, error) {
@@ -519,6 +520,7 @@ func (client Client) WaitForMySQLDatabaseBackup(ctx context.Context, dbID int, l
 }
 
 // WaitForPostgresDatabaseBackup waits for the backup with the given label to be available.
+//
 // Deprecated: WaitForPostgresDatabaseBackup is a deprecated method, as the backup endpoints are no longer supported in DBaaS V2.
 // In DBaaS V2, databases can be backed up via database forking.
 func (client Client) WaitForPostgresDatabaseBackup(ctx context.Context, dbID int, label string, timeoutSeconds int) (*PostgresDatabaseBackup, error) {

Original file line number	Diff line number	Diff line change
`@@ -339,6 +339,7 @@ func (c Client) GetEvent(ctx context.Context, eventID int) (Event, error) {`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`// MarkEventRead marks a single Event as read.`
	`342`	`+//`
`342`	`343`	// Deprecated: `MarkEventRead` is a deprecated API, please consider using `MarkEventsSeen` instead.
`343`	`344`	// Please note that the `MarkEventsSeen` API functions differently and will mark all events up to and
`344`	`345`	`// including the referenced event-id as "seen" rather than individual events.`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ type PaymentMethod struct {`
`24`	`24`	Type string `json:"type"`
`25`	`25`
`26`	`26`	`// The detailed data for the Payment Method, which can be of varying types.`
`27`		- Data interface{} `json:"data"`
	`27`	+ Data any `json:"data"`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`// PaymentMethodDataCreditCard represents a PaymentMethodDataCreditCard object`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ type FirewallCreateOptions struct {`
`41`	`41`	Label string `json:"label,omitempty"`
`42`	`42`	Rules FirewallRuleSet `json:"rules"`
`43`	`43`	Tags []string `json:"tags,omitempty"`
`44`		- Devices DevicesCreationOptions `json:"devices,omitempty"`
	`44`	+ Devices DevicesCreationOptions `json:"devices,omitzero"`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`// FirewallUpdateOptions is an options struct used when Updating a Firewall`
Original file line number	Diff line number	Diff line change
`@@ -92,9 +92,9 @@ func CreateMockClient[T any](t testing.T, createFunc func(http.Client) T) *T {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`type Logger interface {`
`95`		`- Errorf(format string, v ...interface{})`
`96`		`- Warnf(format string, v ...interface{})`
`97`		`- Debugf(format string, v ...interface{})`
	`95`	`+ Errorf(format string, v ...any)`
	`96`	`+ Warnf(format string, v ...any)`
	`97`	`+ Debugf(format string, v ...any)`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`func CreateLogger() *TestLogger {`
`@@ -108,19 +108,19 @@ type TestLogger struct {`
`108`	`108`	`L *log.Logger`
`109`	`109`	`}`
`110`	`110`
`111`		`-func (l *TestLogger) Errorf(format string, v ...interface{}) {`
	`111`	`+func (l *TestLogger) Errorf(format string, v ...any) {`
`112`	`112`	`l.outputf("ERROR RESTY "+format, v...)`
`113`	`113`	`}`
`114`	`114`
`115`		`-func (l *TestLogger) Warnf(format string, v ...interface{}) {`
	`115`	`+func (l *TestLogger) Warnf(format string, v ...any) {`
`116`	`116`	`l.outputf("WARN RESTY "+format, v...)`
`117`	`117`	`}`
`118`	`118`
`119`		`-func (l *TestLogger) Debugf(format string, v ...interface{}) {`
	`119`	`+func (l *TestLogger) Debugf(format string, v ...any) {`
`120`	`120`	`l.outputf("DEBUG RESTY "+format, v...)`
`121`	`121`	`}`
`122`	`122`
`123`		`-func (l *TestLogger) outputf(format string, v ...interface{}) {`
	`123`	`+func (l *TestLogger) outputf(format string, v ...any) {`
`124`	`124`	`if len(v) == 0 {`
`125`	`125`	`l.L.Print(format)`
`126`	`126`	`return`
Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,8 @@ type MetricRelativeTimeDuration struct {`
`93`	`93`
`94`	`94`	`// MetricAbsoluteTimeDuration specifies an absolute time range for data queries`
`95`	`95`	`type MetricAbsoluteTimeDuration struct {`
`96`		- Start time.Time `json:"start,omitempty"`
`97`		- End time.Time `json:"end,omitempty"`
	`96`	+ Start time.Time `json:"start"`
	`97`	+ End time.Time `json:"end"`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`// FetchEntityMetrics returns metrics information for the individual entities within a specific service type`