Skip to content

data getter for processes shouldn't assume that every uid has pwd entry #24

New issue
New issue
Open
#42
Open
data getter for processes shouldn't assume that every uid has pwd entry#24
#42
@arkadini

Description

@arkadini
arkadini
opened on Apr 21, 2016

Processes can run (e.g. inside docker containers) with user ids that don't have valid pwd entries on the host system. The code at

longview/Linode/Longview/DataGetter/Processes.pm

Line 68 in 240db8f

$proc{user} = ( getpwuid( $proc{uid} ) )[0];
seems to assume otherwise:

$proc{user} = ( getpwuid( $proc{uid} ) )[0];

$proc{user} is later used in

longview/Linode/Longview/DataGetter/Processes.pm

Lines 101 to 108 in 240db8f

$dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.count"}++;
$dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.mem"} += $info{mem} + 0;
$dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.cpu"} += $info{cpu} if (defined $info{cpu});
$dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.ioreadkbytes"} += $info{ioreadkbytes} if (defined $info{ioreadkbytes});
$dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.iowritekbytes"} += $info{iowritekbytes} if (defined $info{iowritekbytes});
$dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.zz_age"} = $info{age}
if ((!defined($dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.zz_age"} )) ||
$info{age} > $dataref->{LONGTERM}->{"Processes.${info{name}}.${info{user}}.zz_age"} );
and results in hundreds of warning in the log file, repeated every 5 minutes:

04/21 09:51:35 WARN Longview[6907] - Use of uninitialized value $info{"user"} in concatenation (.) or string at /opt/linode/longview/Linode/Longview/DataGetter/Processes.pm line 101.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions