upcoming: [DI-28506] - Filter linode resources based on associated aclp alerts (#13163)

* upcoming: [DI-28506] - filter linode resources based on alerts

* upcoming: [DI-28506] - Update comment

* upcoming: [DI-28506] - move utils from shared to alerting specific file

* upcoming: [DI-28506] - Update mock

* upcoming: [DI-28506] - Add changeset

* upcoming: [DI-28506] - add copilot suggestion

Author: ankita-akamai

packages/manager/.changeset/pr-13163-upcoming-features-1764838845229.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+CloudPulse-Alerts: Filter linode resources based on associated aclp alerts ([#13163](https://github.com/linode/manager/pull/13163))

packages/manager/src/features/CloudPulse/Alerts/AlertRegions/AlertRegions.tsx

@@ -15,6 +15,7 @@ import {
 import { AlertListNoticeMessages } from '../Utils/AlertListNoticeMessages';
 import { scrollToElement } from '../Utils/AlertResourceUtils';
 import { AlertSelectedInfoNotice } from '../Utils/AlertSelectedInfoNotice';
+import { getFilterFn } from '../Utils/utils';
 import { getFilteredRegions } from '../Utils/utils';
 import { DisplayAlertRegions } from './DisplayAlertRegions';
 
@@ -65,7 +66,9 @@ export const AlertRegions = React.memo((props: AlertRegionsProps) => {
     Boolean(serviceType && regions?.length),
     serviceType === null ? undefined : serviceType,
     {},
-    { ...(RESOURCE_FILTER_MAP[serviceType ?? ''] ?? {}) }
+    { ...(RESOURCE_FILTER_MAP[serviceType ?? ''] ?? {}) },
+    undefined,
+    getFilterFn(serviceType)
   );
 
   const titleRef = React.useRef<HTMLDivElement>(null); // Reference to the component title, used for scrolling to the title when the table's page size or page number changes.

packages/manager/src/features/CloudPulse/Alerts/AlertsResources/AlertsResources.tsx

@@ -7,7 +7,6 @@ import EntityIcon from 'src/assets/icons/entityIcons/alertsresources.svg';
 import { DebouncedSearchTextField } from 'src/components/DebouncedSearchTextField';
 import { useResourcesQuery } from 'src/queries/cloudpulse/resources';
 
-import { filterFirewallResources } from '../../Utils/utils';
 import { StyledPlaceholder } from '../AlertsDetail/AlertDetail';
 import { MULTILINE_ERROR_SEPARATOR } from '../constants';
 import { AlertListNoticeMessages } from '../Utils/AlertListNoticeMessages';
@@ -22,6 +21,7 @@ import {
   scrollToElement,
 } from '../Utils/AlertResourceUtils';
 import { AlertSelectedInfoNotice } from '../Utils/AlertSelectedInfoNotice';
+import { getFilterFn } from '../Utils/utils';
 import { AlertResourcesFilterRenderer } from './AlertsResourcesFilterRenderer';
 import {
   databaseTypeClassMap,
@@ -42,7 +42,6 @@ import type {
   AlertDefinitionType,
   CloudPulseServiceType,
   Filter,
-  Firewall,
   Region,
 } from '@linode/api-v4';
 
@@ -192,6 +191,9 @@ export const AlertResources = React.memo((props: AlertResourcesProp) => {
     return { ...platformFilter, '+and': [typeFilter, regionFilter] };
   }, [alertClass, alertType, serviceType, supportedRegionIds]);
 
+  // Get the filter function for the service type and entity type if applicable
+  const filterFn = getFilterFn(serviceType, entityType);
+
   const {
     data: resources,
     isError: isResourcesError,
@@ -204,10 +206,7 @@ export const AlertResources = React.memo((props: AlertResourcesProp) => {
     {},
     xFilterToBeApplied,
     serviceType === 'firewall' && entityType ? entityType : undefined,
-    serviceType === 'firewall' && entityType
-      ? (resources: Firewall[]) =>
-          filterFirewallResources(resources, entityType)
-      : undefined
+    filterFn
   );
 
   const regionFilteredResources = React.useMemo(() => {

packages/manager/src/features/CloudPulse/Alerts/Utils/utils.test.ts

@@ -1,4 +1,8 @@
-import { regionFactory } from '@linode/utilities';
+import {
+  linodeAlertsFactory,
+  linodeFactory,
+  regionFactory,
+} from '@linode/utilities';
 import { act, renderHook } from '@testing-library/react';
 
 import { alertFactory, notificationChannelFactory, serviceTypesFactory } from 'src/factories';
@@ -13,6 +17,7 @@ import {
   convertSecondsToMinutes,
   convertSecondsToOptions,
   filterAlerts,
+  filterLinodeResources,
   filterRegionByServiceType,
   getSchemaWithEntityIdValidation,
   getServiceTypeLabel,
@@ -547,3 +552,18 @@ describe('shouldUseContentsForEmail', () => {
     expect(shouldUseContentsForEmail(notificationChannel)).toBe(true);
   });
 });
+
+describe('filterLinodeResources', () => {
+  it('should return the filtered linode resources', () => {
+    const linodes = [
+      linodeFactory.build({
+        alerts: {
+          system_alerts: [1, 2, 3, 4, 5],
+          user_alerts: [6, 7, 8, 9, 10],
+        },
+      }),
+      linodeFactory.build({ alerts: linodeAlertsFactory.build() }),
+    ];
+    expect(filterLinodeResources(linodes)).toEqual([linodes[0]]);
+  });
+});

packages/manager/src/features/CloudPulse/Alerts/Utils/utils.ts

@@ -13,13 +13,15 @@ import {
 import type { FieldPath, FieldValues, UseFormSetError } from 'react-hook-form';
 import { array, object, string } from 'yup';
 
+import { filterFirewallResources } from '../../Utils/utils';
 import { aggregationTypeMap, metricOperatorTypeMap } from '../constants';
 
 import type { CloudPulseResources } from '../../shared/CloudPulseResourcesSelect';
+import type { AssociatedEntityType } from '../../shared/types';
 import type { AlertRegion } from '../AlertRegions/DisplayAlertRegions';
 import type { AlertDimensionsProp } from '../AlertsDetail/DisplayAlertDetailChips';
 import type { CreateAlertDefinitionForm } from '../CreateAlert/types';
-import type { MonitoringCapabilities } from '@linode/api-v4';
+import type { Firewall, Linode, MonitoringCapabilities } from '@linode/api-v4';
 import type { Theme } from '@mui/material';
 import type {
   AclpAlertServiceTypeConfig,
@@ -622,3 +624,37 @@ export const alertsFromEnabledServices = (
     (alert) => aclpServices?.[alert.service_type]?.alerts?.enabled ?? false
   );
 };
+
+/**
+ * @param serviceType The service type
+ * @param entityType The entity type
+ * @returns The filter function for the service type and entity type if applicable
+ */
+export const getFilterFn = (
+  serviceType?: CloudPulseServiceType | null,
+  entityType?: AssociatedEntityType
+) => {
+  if (!serviceType) {
+    return undefined;
+  }
+  if (serviceType === 'firewall' && entityType) {
+    return (resources: Firewall[]) =>
+      filterFirewallResources(resources, entityType);
+  }
+  if (serviceType === 'linode') {
+    return (resources: Linode[]) => filterLinodeResources(resources);
+  }
+  return undefined;
+};
+
+/**
+ * @param linodes The list of linodes
+ * @returns The filtered list of linodes that have ACLP alerts
+ */
+export const filterLinodeResources = (linodes: Linode[]): Linode[] => {
+  return linodes.filter(
+    (linode) =>
+      (linode.alerts.system_alerts?.length ?? 0) > 0 ||
+      (linode.alerts.user_alerts?.length ?? 0) > 0
+  );
+};

packages/manager/src/mocks/serverHandlers.ts

@@ -897,6 +897,13 @@ export const handlers = [
     const linodesWithFirewalls = linodeFactory.buildList(10, {
       region: 'ap-west',
     });
+    const linodesWithAclpAlerts = linodeFactory.buildList(10, {
+      region: 'ap-west',
+      alerts: {
+        system_alerts: [1, 2, 3, 4, 5],
+        user_alerts: [6, 7, 8, 9, 10],
+      },
+    });
     const metadataLinodeWithCompatibleImage = linodeFactory.build({
       image: 'metadata-test-image',
       label: 'metadata-test-image',
@@ -984,6 +991,7 @@ export const handlers = [
     });
     const linodes = [
       ...linodesWithFirewalls,
+      ...linodesWithAclpAlerts,
       ...mtcLinodes,
       ...aclpSupportedRegionLinodes,
       nonMTCPlanInMTCSupportedRegionsLinode,

packages/utilities/src/__data__/regionsData.ts

@@ -29,7 +29,7 @@ export const regions: Region[] = [
     site_type: 'core',
     status: 'ok',
     monitors: {
-      alerts: ['Cloud Firewall', 'Object Storage', 'Block Storage'],
+      alerts: ['Linodes', 'Cloud Firewall', 'Object Storage', 'Block Storage'],
       metrics: [
         'Object Storage',
         'Cloud Firewall',