Skip to content

Commit 261781e

Browse files
Added changeset
1 parent f7568b4 commit 261781e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Changed
3+
---
4+
5+
Make firewall selection mandatory while creating linode and its interfaces ([#13410](https://github.com/linode/manager/pull/13410))

packages/manager/src/features/Linodes/LinodeCreate/resolvers.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ export const getLinodeCreateResolver = (
3838
values.linodeInterfaces = values.linodeInterfaces.map(
3939
getCleanedLinodeInterfaceValues
4040
);
41-
if (tab === 'Clone Linode' && !values.firewall_id) {
42-
// The Clone Linode flow does not have the firewall_id field under interfaces object, so we set firewall_id to -1 to bypass the firewall requirement in the validation schema.
43-
values.firewall_id = -1;
44-
}
4541
if (
4642
values.interface_generation === 'legacy_config' ||
4743
tab === 'Clone Linode'

packages/validation/src/linodes.schema.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,7 @@ export const CreateLinodeSchema = object({
872872
}),
873873
}),
874874
metadata: MetadataSchema.notRequired().default(undefined),
875-
firewall_id: number().nullable(),
875+
firewall_id: number().nullable().notRequired(),
876876
placement_group: PlacementGroupPayloadSchema.notRequired().default(undefined),
877877
disk_encryption: DiskEncryptionSchema,
878878
maintenance_policy: string()

0 commit comments

Comments
 (0)