Revert "Merge branch 'develop' into M3-8777-refactor-CreateCluster-component-to-use-react-hook-form"

This reverts commit 955ed0a, reversing
changes made to 84676ad.

Author: mjac0bs

.github/workflows/ci.yml

@@ -16,11 +16,9 @@ jobs:
           [
             "linode-manager",
             "@linode/api-v4",
-            "@linode/queries",
-            "@linode/shared",
+            "@linode/validation",
             "@linode/ui",
             "@linode/utilities",
-            "@linode/validation",
           ]
     runs-on: ubuntu-latest
     steps:
@@ -195,7 +193,6 @@ jobs:
       - run: pnpm run --filter @linode/ui test
 
   test-utilities:
-    needs: build-sdk
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -207,57 +204,9 @@ jobs:
         with:
           node-version: "20.17"
           cache: "pnpm"
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-api-v4-lib
-          path: packages/api-v4/lib
       - run: pnpm install --frozen-lockfile
       - run: pnpm run --filter @linode/utilities test
 
-  test-queries:
-    runs-on: ubuntu-latest
-    needs: build-sdk
-    steps:
-      - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          run_install: false
-          version: 10
-      - uses: actions/setup-node@v4
-        with:
-          node-version: "20.17"
-          cache: "pnpm"
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-api-v4-lib
-          path: packages/api-v4/lib
-      - run: pnpm install --frozen-lockfile
-      - run: pnpm run --filter @linode/queries test
-
-  test-shared:
-    runs-on: ubuntu-latest
-    needs: build-sdk
-    steps:
-      - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          run_install: false
-          version: 10
-      - uses: actions/setup-node@v4
-        with:
-          node-version: "20.17"
-          cache: "pnpm"
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-api-v4-lib
-          path: packages/api-v4/lib
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-validation-lib
-          path: packages/validation/lib
-      - run: pnpm install --frozen-lockfile
-      - run: pnpm run --filter @linode/shared test
-
   typecheck-ui:
     runs-on: ubuntu-latest
     needs: build-sdk
@@ -287,57 +236,9 @@ jobs:
         with:
           node-version: "20.17"
           cache: "pnpm"
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-api-v4-lib
-          path: packages/api-v4/lib
       - run: pnpm install --frozen-lockfile
       - run: pnpm run --filter @linode/utilities typecheck
 
-  typecheck-queries:
-    runs-on: ubuntu-latest
-    needs: build-sdk
-    steps:
-      - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          run_install: false
-          version: 10
-      - uses: actions/setup-node@v4
-        with:
-          node-version: "20.17"
-          cache: "pnpm"
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-api-v4-lib
-          path: packages/api-v4/lib
-      - run: pnpm install --frozen-lockfile
-      - run: pnpm run --filter @linode/queries typecheck
-    
-  typecheck-shared:
-    runs-on: ubuntu-latest
-    needs: build-sdk
-    steps:
-      - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-        with:
-          run_install: false
-          version: 10
-      - uses: actions/setup-node@v4
-        with:
-          node-version: "20.17"
-          cache: "pnpm"
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-api-v4-lib
-          path: packages/api-v4/lib
-      - uses: actions/download-artifact@v4
-        with:
-          name: packages-validation-lib
-          path: packages/validation/lib
-      - run: pnpm install --frozen-lockfile
-      - run: pnpm run --filter @linode/shared typecheck
-    
   typecheck-manager:
     runs-on: ubuntu-latest
     needs: build-sdk
@@ -391,7 +292,7 @@ jobs:
       - run: pnpm install --frozen-lockfile
       - run: npm config set //registry.npmjs.org/:_authToken ${NPM_TOKEN}
         env:
-          NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
       - run: pnpm publish -r --filter @linode/api-v4 --filter @linode/validation --no-git-checks --access public
       - name: slack-notify
         uses: rtCamp/action-slack-notify@master

.github/workflows/coverage.yml

@@ -0,0 +1,102 @@
+name: Code Coverage
+
+on: [pull_request]
+
+jobs:
+  base_branch:
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.base_ref }} # The base branch of the PR (develop)
+
+      - uses: pnpm/action-setup@v4
+        with:
+          run_install: false
+          version: 10
+
+      - name: Use Node.js v20.17 LTS
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20.17"
+          cache: "pnpm"
+
+      - name: Install Dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Build @linode/validation
+        run: pnpm build:validation
+
+      - name: Build @linode/api-v4
+        run: pnpm build:sdk
+
+      - name: Run Base Branch Coverage
+        run: pnpm coverage:summary
+
+      - name: Write Base Coverage to an Artifact
+        run: |
+          coverage_json=$(cat ./packages/manager/coverage/coverage-summary.json)
+          pct=$(echo "$coverage_json" | jq -r '.total.statements.pct')
+          echo "$pct" > ref_code_coverage.txt
+
+      - name: Upload Base Coverage Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: ref_code_coverage
+          path: ref_code_coverage.txt
+
+  current_branch:
+    # We want to make sure we only run on open PRs (not drafts), but also should run even if the base branch coverage job fails.
+    # If the base branch coverage job fails to create a report, the current branch coverage job will fail as well, but this may help us debug the CI on the current branch.
+    if: ${{ always() && github.event.pull_request.draft == false }}
+    runs-on: ubuntu-latest
+    needs: base_branch
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: pnpm/action-setup@v4
+        with:
+          run_install: false
+          version: 10
+
+      - name: Use Node.js v20.17 LTS
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20.17"
+          cache: "pnpm"
+
+      - name: Install Dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Build @linode/validation
+        run: pnpm build:validation
+
+      - name: Build @linode/api-v4
+        run: pnpm build:sdk
+
+      - name: Run Current Branch Coverage
+        run: pnpm coverage:summary
+
+      - name: Write PR Number to an Artifact
+        run: |
+          echo "${{ github.event.number }}" > pr_number.txt
+
+      - name: Write Current Coverage to an Artifact
+        run: |
+          coverage_json=$(cat ./packages/manager/coverage/coverage-summary.json)
+          pct=$(echo "$coverage_json" | jq -r '.total.statements.pct')
+          echo "$pct" > current_code_coverage.txt
+
+      - name: Upload PR Number Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: pr_number
+          path: pr_number.txt
+
+      - name: Upload Current Coverage Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: current_code_coverage
+          path: current_code_coverage.txt

.github/workflows/coverage_comment.yml

@@ -0,0 +1,68 @@
+name: Coverage Comment
+
+on:
+  workflow_run:
+    workflows: ["Code Coverage"]
+    types:
+      - completed
+
+permissions:
+  pull-requests: write
+
+jobs:
+  comment:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+
+      - name: Use Node.js v20.17 LTS
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20.17"
+
+      - name: Download PR Number Artifact
+        uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e #v2.28.0
+        with:
+          workflow: "coverage.yml"
+          run_id: ${{ github.event.workflow_run.id }}
+          name: pr_number
+
+      - name: Download Base Coverage Artifact
+        uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e #v2.28.0
+        with:
+          workflow: "coverage.yml"
+          run_id: ${{ github.event.workflow_run.id }}
+          name: ref_code_coverage
+
+      - name: Download Current Coverage Artifact
+        uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e #v2.28.0
+        with:
+          workflow: "coverage.yml"
+          run_id: ${{ github.event.workflow_run.id }}
+          name: current_code_coverage
+
+      - name: Set PR Number Environment Variables
+        run: |
+          echo "PR_NUMBER=$(cat pr_number.txt)" >> $GITHUB_ENV
+
+      - name: Generate Coverage Comment
+        run: |
+          base_coverage=$(cat ref_code_coverage.txt)
+          current_coverage=$(cat current_code_coverage.txt)
+          if (( $(echo "$current_coverage < $base_coverage" | bc -l) )); then
+            icon="❌" # Error icon
+          else
+            icon="✅" # Check mark icon
+          fi
+          comment_message="**Coverage Report:** $icon<br>Base Coverage: $base_coverage%<br>Current Coverage: $current_coverage%"
+          echo "Coverage: $comment_message"
+          echo "$comment_message" > updated_comment.txt
+
+      - name: Post Comment
+        uses: mshick/add-pr-comment@7c0890544fb33b0bdd2e59467fbacb62e028a096 #v2.8.1
+        with:
+          issue: ${{ env.PR_NUMBER }}
+          message-path: updated_comment.txt

.github/workflows/e2e_schedule_and_push.yml

@@ -8,8 +8,6 @@ env:
   CLIENT_ID: ${{ secrets.REACT_APP_CLIENT_ID }}
   CY_TEST_FAIL_ON_MANAGED: 1
   CY_TEST_RESET_PREFERENCES: 1
-  CY_TEST_SPLIT_RUN: 1
-  CY_TEST_SPLIT_RUN_TOTAL: 4
 on:
   schedule:
     - cron: "0 13 * * 1-5"
@@ -21,17 +19,14 @@ on:
 
 jobs:
   run-cypress-e2e:
-    name: Cypress Tests (User ${{ matrix.user.index }})
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        user:
-          - { index: 1, name: 'USER_1' }
-          - { index: 2, name: 'USER_2' }
-          - { index: 3, name: 'USER_3' }
-          - { index: 4, name: 'USER_4' }
+        user: ["USER_1", "USER_2", "USER_3", "USER_4"]
     steps:
+      - name: install command line utilities
+        run: sudo apt-get install -y expect
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4
         with:
@@ -41,16 +36,23 @@ jobs:
         with:
           node-version: "20.17"
       - run: |
+          echo "CYPRESS_RECORD_KEY=${{ secrets.CYPRESS_RECORD_KEY }}" >> $GITHUB_ENV
           echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
+      - run: echo "MANAGER_OAUTH=$USER_1" >> ./packages/manager/.env
+        if: matrix['user'] == 'USER_1'
+      - run: echo "MANAGER_OAUTH=$USER_2" >> ./packages/manager/.env
+        if: matrix['user'] == 'USER_2'
+      - run: echo "MANAGER_OAUTH=$USER_3" >> ./packages/manager/.env
+        if: matrix['user'] == 'USER_3'
+      - run: echo "MANAGER_OAUTH=$USER_4" >> ./packages/manager/.env
+        if: matrix['user'] == 'USER_4'
       - run: |
           echo "REACT_APP_LAUNCH_DARKLY_ID=${{ secrets.REACT_APP_LAUNCH_DARKLY_ID }}" >> ./packages/manager/.env
           echo "REACT_APP_CLIENT_ID=$CLIENT_ID" >> ./packages/manager/.env
           echo "REACT_APP_LOGIN_ROOT=${{ secrets.REACT_APP_LOGIN_ROOT }}" >> ./packages/manager/.env
           echo "REACT_APP_API_ROOT=${{ secrets.REACT_APP_API_ROOT }}" >> ./packages/manager/.env
           echo "REACT_APP_APP_ROOT=${{ secrets.REACT_APP_APP_ROOT }}" >> ./packages/manager/.env
           echo "REACT_APP_DISABLE_NEW_RELIC=1" >> ./packages/manager/.env
-          echo "MANAGER_OAUTH=${{ secrets[matrix.user.name] }}" >> ./packages/manager/.env
-          echo "CY_TEST_SPLIT_RUN_INDEX=${{ matrix.user.index }}" >> ./packages/manager/.env
       - run: pnpm install --frozen-lockfile
       - run: pnpm run --filter @linode/validation build
       - run: pnpm run --filter @linode/api-v4 build
@@ -64,5 +66,5 @@ jobs:
           build: pnpm run build
           start: pnpm start:ci
           browser: chrome
-          record: false
-          parallel: false
+          record: true
+          parallel: true