upcoming: [DI-28395] - Added enabling, disabling and provisioning statuses and updated messages in CloudPulse alerts (#13127)

* upcoming: [DI-28395] - Added enabling, disabling and provisioning statuses in alerts

* upcoming: [DI-28395] - Updated server handlers

* upcoming: [DI-28395] - Code refactoring

* upcoming: [DI-28395] - Add changeset

* upcoming: [DI-28395] - Update status messages on enable, disable , create and update

* upcoming: [DI-28395] - Code refactoring

* upcoming: [DI-28395] - Cypress fixes

* upcoming: [DI-28395] - Lint issue fix

---------

Co-authored-by: nikhagra-akamai <[email protected]>

Author: venkymano-akamai

packages/api-v4/.changeset/pr-13127-upcoming-features-1763979506001.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Upcoming Features
+---
+
+Add additional status types `enabling`, `disabling`, `provisioning` in CloudPulse alerts ([#13127](https://github.com/linode/manager/pull/13127))

packages/api-v4/src/cloudpulse/types.ts

@@ -19,8 +19,15 @@ export type DimensionFilterOperatorType =
   | 'neq'
   | 'startswith';
 export type AlertDefinitionType = 'system' | 'user';
-export type AlertStatusType = 'disabled' | 'enabled' | 'failed' | 'in progress';
 export type AlertDefinitionScope = 'account' | 'entity' | 'region';
+export type AlertStatusType =
+  | 'disabled'
+  | 'disabling'
+  | 'enabled'
+  | 'enabling'
+  | 'failed'
+  | 'in progress'
+  | 'provisioning';
 export type CriteriaConditionType = 'ALL';
 export type MetricUnitType =
   | 'bit_per_second'

packages/manager/.changeset/pr-13127-upcoming-features-1763979546789.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add support for additional status types and handle action menu accordingly in CloudPulse alerts ([#13127](https://github.com/linode/manager/pull/13127))

packages/manager/cypress/e2e/core/cloudpulse/alerts-listing-page.spec.ts

@@ -29,7 +29,8 @@ import {
 import {
   alertStatuses,
   DELETE_ALERT_SUCCESS_MESSAGE,
-  UPDATE_ALERT_SUCCESS_MESSAGE,
+  DISABLE_ALERT_SUCCESS_MESSAGE,
+  ENABLE_ALERT_SUCCESS_MESSAGE,
 } from 'src/features/CloudPulse/Alerts/constants';
 import { formatDate } from 'src/utilities/formatDate';
 
@@ -426,7 +427,10 @@ describe('Integration Tests for CloudPulse Alerts Listing Page', () => {
         alertName,
         alias,
         confirmationText: `Are you sure you want to ${action.toLowerCase()} this alert definition?`,
-        successMessage: UPDATE_ALERT_SUCCESS_MESSAGE,
+        successMessage:
+          action === 'Disable'
+            ? DISABLE_ALERT_SUCCESS_MESSAGE
+            : ENABLE_ALERT_SUCCESS_MESSAGE,
       });
     });
   });

packages/manager/cypress/support/constants/alert.ts

@@ -44,4 +44,7 @@ export const statusMap: Record<AlertStatusType, string> = {
   enabled: 'Enabled',
   failed: 'Failed',
   'in progress': 'In Progress',
+  disabling: 'Disabling',
+  enabling: 'Enabling',
+  provisioning: 'Provisioning',
 };

packages/manager/src/factories/featureFlags.ts

@@ -24,6 +24,13 @@ export const flagsFactory = Factory.Sync.makeFactory<Partial<Flags>>({
     alertDefinitions: true,
     recentActivity: false,
     notificationChannels: false,
+    editDisabledStatuses: [
+      'in progress',
+      'failed',
+      'provisioning',
+      'enabling',
+      'disabling',
+    ],
   },
   aclpServices: {
     linode: {

packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListTable.test.tsx

@@ -8,7 +8,8 @@ import { renderWithTheme } from 'src/utilities/testHelpers';
 
 import {
   DELETE_ALERT_SUCCESS_MESSAGE,
-  UPDATE_ALERT_SUCCESS_MESSAGE,
+  DISABLE_ALERT_SUCCESS_MESSAGE,
+  ENABLE_ALERT_SUCCESS_MESSAGE,
 } from '../constants';
 import { AlertsListTable } from './AlertListTable';
 
@@ -117,7 +118,7 @@ describe('Alert List Table test', () => {
 
     await userEvent.click(getByRole('button', { name: 'Enable' }));
 
-    expect(getByText(UPDATE_ALERT_SUCCESS_MESSAGE)).toBeInTheDocument(); // validate whether snackbar is displayed properly
+    expect(getByText(ENABLE_ALERT_SUCCESS_MESSAGE)).toBeVisible(); // validate whether snackbar is displayed properly
   });
 
   it('should show success snackbar when disabling alert succeeds', async () => {
@@ -140,7 +141,7 @@ describe('Alert List Table test', () => {
 
     await userEvent.click(getByRole('button', { name: 'Disable' }));
 
-    expect(getByText(UPDATE_ALERT_SUCCESS_MESSAGE)).toBeInTheDocument(); // validate whether snackbar is displayed properly
+    expect(getByText(DISABLE_ALERT_SUCCESS_MESSAGE)).toBeVisible(); // validate whether snackbar is displayed properly
   });
 
   it('should show error snackbar when enabling alert fails', async () => {

packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListTable.tsx

@@ -23,7 +23,10 @@ import { getAPIErrorOrDefault } from 'src/utilities/errorUtils';
 import { AlertConfirmationDialog } from '../AlertsLanding/AlertConfirmationDialog';
 import {
   DELETE_ALERT_SUCCESS_MESSAGE,
-  UPDATE_ALERT_SUCCESS_MESSAGE,
+  DISABLE_ALERT_FAILED_MESSAGE,
+  DISABLE_ALERT_SUCCESS_MESSAGE,
+  ENABLE_ALERT_FAILED_MESSAGE,
+  ENABLE_ALERT_SUCCESS_MESSAGE,
 } from '../constants';
 import { AlertsTable } from './AlertsTable';
 import { AlertListingTableLabelMap } from './constants';
@@ -126,7 +129,6 @@ export const AlertsListTable = React.memo((props: AlertsListTableProps) => {
   const handleConfirm = React.useCallback(
     (alert: Alert, currentStatus: boolean) => {
       const toggleStatus = currentStatus ? 'disabled' : 'enabled';
-      const errorStatus = currentStatus ? 'Disabling' : 'Enabling';
       setIsUpdating(true);
       editAlertDefinition({
         alertId: alert.id,
@@ -135,15 +137,22 @@ export const AlertsListTable = React.memo((props: AlertsListTableProps) => {
       })
         .then(() => {
           // Handle success
-          enqueueSnackbar(UPDATE_ALERT_SUCCESS_MESSAGE, {
-            variant: 'success',
-          });
+          enqueueSnackbar(
+            currentStatus
+              ? DISABLE_ALERT_SUCCESS_MESSAGE
+              : ENABLE_ALERT_SUCCESS_MESSAGE,
+            {
+              variant: 'success',
+            }
+          );
         })
         .catch((updateError: APIError[]) => {
           // Handle error
           const errorResponse = getAPIErrorOrDefault(
             updateError,
-            `${errorStatus} alert failed`
+            currentStatus
+              ? DISABLE_ALERT_FAILED_MESSAGE
+              : ENABLE_ALERT_FAILED_MESSAGE
           );
           enqueueSnackbar(errorResponse[0].reason, {
             variant: 'error',

packages/manager/src/features/CloudPulse/Alerts/AlertsListing/constants.ts

@@ -35,6 +35,9 @@ export const statusToActionMap: Record<AlertStatusType, AlertStatusUpdateType> =
     enabled: 'Disable',
     failed: 'Disable',
     'in progress': 'Disable',
+    provisioning: 'Disable',
+    disabling: 'Enable',
+    enabling: 'Disable',
   };
 
 export const AlertContextualViewTableHeaderMap: TableColumnHeader[] = [

packages/manager/src/features/CloudPulse/Alerts/Utils/AlertsActionMenu.ts

@@ -40,7 +40,12 @@ export const getAlertTypeToActionsList = (
       title: 'Edit',
     },
     {
-      disabled: alertStatus === 'in progress' || alertStatus === 'failed',
+      disabled:
+        alertStatus === 'in progress' ||
+        alertStatus === 'failed' ||
+        alertStatus === 'provisioning' ||
+        alertStatus === 'enabling' ||
+        alertStatus === 'disabling',
       onClick: handleStatusChange,
       title: getTitleForStatusChange(alertStatus),
     },