Fixed e2e test cases

grevanak-akamai · grevanak-akamai · commit 3926c9e2f7b9 · 2026-02-20T22:31:50.000+05:30
diff --git a/packages/manager/cypress/e2e/core/general/gdpr-agreement.spec.ts b/packages/manager/cypress/e2e/core/general/gdpr-agreement.spec.ts
@@ -1,9 +1,12 @@
 import { linodeFactory, regionFactory } from '@linode/utilities';
+import { firewallFactory } from '@src/factories';
 import { mockGetAccountAgreements } from 'support/intercepts/account';
+import { mockGetFirewalls } from 'support/intercepts/firewalls';
 import { mockCreateLinode } from 'support/intercepts/linodes';
 import { mockGetRegions } from 'support/intercepts/regions';
 import { ui } from 'support/ui';
-import { randomLabel, randomString } from 'support/util/random';
+import { linodeCreatePage } from 'support/ui/pages';
+import { randomLabel, randomNumber, randomString } from 'support/util/random';
 
 import type { Region } from '@linode/api-v4';
 
@@ -100,6 +103,11 @@ describe('GDPR agreement', () => {
   });
 
   it('needs the agreement checked to submit the form', () => {
+    const mockFirewall = firewallFactory.build({
+      id: randomNumber(),
+      label: randomLabel(),
+    });
+    mockGetFirewalls([mockFirewall]).as('getFirewalls');
     mockGetRegions(mockRegions).as('getRegions');
     mockGetAccountAgreements({
       billing_agreement: false,
@@ -127,6 +135,12 @@ describe('GDPR agreement', () => {
 
     cy.findByLabelText('Root Password').type(rootpass);
 
+    // Select a firewall
+    linodeCreatePage.selectFirewall(
+      mockFirewall.label,
+      'Public Interface Firewall'
+    );
+
     cy.get('[data-testid="eu-agreement-checkbox"]')
       .as('euAgreement')
       .scrollIntoView();
diff --git a/packages/manager/cypress/e2e/core/helpAndSupport/open-support-ticket.spec.ts b/packages/manager/cypress/e2e/core/helpAndSupport/open-support-ticket.spec.ts
@@ -6,6 +6,7 @@ import 'cypress-file-upload';
 import { mockGetAccount } from 'support/intercepts/account';
 import { mockGetDomains } from 'support/intercepts/domains';
 import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
+import { mockGetFirewalls } from 'support/intercepts/firewalls';
 import {
   mockCreateLinodeAccountLimitError,
   mockGetLinodeDetails,
@@ -31,6 +32,7 @@ import {
 } from 'support/util/random';
 import { chooseRegion } from 'support/util/regions';
 
+import { firewallFactory } from 'src/factories';
 import {
   accountFactory,
   domainFactory,
@@ -378,6 +380,10 @@ describe('open support tickets', () => {
       planLabel: 'Nanode 1 GB',
       planId: 'g6-nanode-1',
     };
+    const mockFirewall = firewallFactory.build({
+      id: randomNumber(),
+      label: randomLabel(),
+    });
 
     const mockLinode = linodeFactory.build();
 
@@ -393,6 +399,7 @@ describe('open support tickets', () => {
     mockGetSupportTicket(mockAccountLimitTicket);
     mockGetSupportTicketReplies(mockAccountLimitTicket.id, []);
     mockGetLinodes([mockLinode]);
+    mockGetFirewalls([mockFirewall]).as('getFirewalls');
 
     cy.visitWithLogin('/linodes/create');
 
@@ -401,6 +408,8 @@ describe('open support tickets', () => {
     linodeCreatePage.selectRegionById(mockRegion.id);
     linodeCreatePage.selectPlan(mockPlan.planType, mockPlan.planLabel);
     linodeCreatePage.setRootPassword(randomString(32));
+    // Select a firewall
+    linodeCreatePage.selectFirewall(mockFirewall.label, 'Assign Firewall');
 
     // Attempt to create Linode and confirm mocked account limit error with support link is present.
     ui.button
diff --git a/packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts b/packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts
@@ -62,6 +62,12 @@ describe('Create Linode', () => {
   describe('End-to-end', () => {
     // Run an end-to-end test to create a basic Linode for each plan type described below.
     describe('By plan type', () => {
+      beforeEach(() => {
+        mockAppendFeatureFlags({
+          linodeInterfaces: { enabled: false },
+          iam: { enabled: false },
+        });
+      });
       [
         {
           planId: 'g6-nanode-1',
diff --git a/packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts b/packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts
@@ -1,4 +1,5 @@
 import { linodeFactory } from '@linode/utilities';
+import { mockGetFirewalls } from 'support/intercepts/firewalls';
 import { mockGetAllImages } from 'support/intercepts/images';
 import { mockCreateLinode } from 'support/intercepts/linodes';
 import {
@@ -7,11 +8,12 @@ import {
   mockGetStackScripts,
 } from 'support/intercepts/stackscripts';
 import { ui } from 'support/ui';
+import { linodeCreatePage } from 'support/ui/pages';
 import { getRandomOCAId } from 'support/util/one-click-apps';
-import { randomLabel, randomString } from 'support/util/random';
+import { randomLabel, randomNumber, randomString } from 'support/util/random';
 import { chooseRegion } from 'support/util/regions';
 
-import { imageFactory } from 'src/factories';
+import { firewallFactory, imageFactory } from 'src/factories';
 import { stackScriptFactory } from 'src/factories/stackscripts';
 import { getMarketplaceAppLabel } from 'src/features/Linodes/LinodeCreate/Tabs/Marketplace/utilities';
 import { oneClickApps } from 'src/features/OneClickApps/oneClickApps';
@@ -166,10 +168,15 @@ describe('OneClick Apps (OCA)', () => {
     const linode = linodeFactory.build({
       label: linodeLabel,
     });
+    const mockFirewall = firewallFactory.build({
+      id: randomNumber(),
+      label: randomLabel(),
+    });
 
     mockGetAllImages(images);
     mockGetStackScripts([stackscript]).as('getStackScripts');
     mockGetStackScript(stackscript.id, stackscript);
+    mockGetFirewalls([mockFirewall]).as('getFirewalls');
 
     cy.visitWithLogin(`/linodes/create/marketplace`);
 
@@ -242,6 +249,12 @@ describe('OneClick Apps (OCA)', () => {
     // Create the Linode
     mockCreateLinode(linode).as('createLinode');
 
+    // Select a firewall
+    linodeCreatePage.selectFirewall(
+      mockFirewall.label,
+      'Public Interface Firewall'
+    );
+
     ui.button
       .findByTitle('Create Linode')
       .should('be.visible')
diff --git a/packages/manager/cypress/e2e/core/stackscripts/create-stackscripts.spec.ts b/packages/manager/cypress/e2e/core/stackscripts/create-stackscripts.spec.ts
@@ -2,13 +2,15 @@ import { createImage, getLinodeDisks, resizeLinodeDisk } from '@linode/api-v4';
 import { createLinodeRequestFactory } from '@linode/utilities';
 import { authenticate } from 'support/api/authentication';
 import { interceptGetAccountAvailability } from 'support/intercepts/account';
+import { mockGetFirewalls } from 'support/intercepts/firewalls';
 import { interceptGetAllImages } from 'support/intercepts/images';
 import { interceptCreateLinode } from 'support/intercepts/linodes';
 import {
   interceptCreateStackScript,
   interceptGetStackScripts,
 } from 'support/intercepts/stackscripts';
 import { ui } from 'support/ui';
+import { linodeCreatePage } from 'support/ui/pages';
 import { SimpleBackoffMethod } from 'support/util/backoff';
 import { cleanUp } from 'support/util/cleanup';
 import { chooseImage } from 'support/util/images';
@@ -18,10 +20,16 @@ import {
   pollLinodeDiskSize,
   pollLinodeStatus,
 } from 'support/util/polling';
-import { randomLabel, randomPhrase, randomString } from 'support/util/random';
+import {
+  randomLabel,
+  randomNumber,
+  randomPhrase,
+  randomString,
+} from 'support/util/random';
 import { chooseRegion, getRegionByLabel } from 'support/util/regions';
 
 import { getFilteredImagesForImageSelect } from 'src/components/ImageSelect/utilities';
+import { firewallFactory } from 'src/factories';
 
 import type { Image } from '@linode/api-v4';
 
@@ -179,13 +187,19 @@ const createLinodeAndImage = async () => {
   return image;
 };
 
+const mockFirewall = firewallFactory.build({
+  id: randomNumber(),
+  label: randomLabel(),
+});
+
 authenticate();
 describe('Create stackscripts', () => {
   before(() => {
     cleanUp(['linodes', 'images', 'stackscripts']);
   });
   beforeEach(() => {
     cy.tag('method:e2e', 'purpose:dcTesting');
+    mockGetFirewalls([mockFirewall]).as('getFirewalls');
   });
 
   /*
@@ -288,6 +302,11 @@ describe('Create stackscripts', () => {
     cy.findByLabelText('Example Title').should('be.visible').click();
     cy.focused().type('{selectall}{backspace}');
     cy.focused().type(randomString(12));
+    // Select a firewall
+    linodeCreatePage.selectFirewall(
+      mockFirewall.label,
+      'Public Interface Firewall'
+    );
 
     ui.button
       .findByTitle('Create Linode')
@@ -389,6 +408,11 @@ describe('Create stackscripts', () => {
       cy.findByText(privateImage.label).as('qaPrivateImage').scrollIntoView();
       cy.get('@qaPrivateImage').should('be.visible').click();
 
+      // Select a firewall
+      linodeCreatePage.selectFirewall(
+        mockFirewall.label,
+        'Public Interface Firewall'
+      );
       interceptCreateLinode().as('createLinode');
       fillOutLinodeForm(
         linodeLabel,
diff --git a/packages/manager/cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts b/packages/manager/cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts
@@ -1,5 +1,6 @@
 import { getProfile } from '@linode/api-v4';
 import { authenticate } from 'support/api/authentication';
+import { mockGetFirewalls } from 'support/intercepts/firewalls';
 import { interceptCreateLinode } from 'support/intercepts/linodes';
 import { mockGetUserPreferences } from 'support/intercepts/profile';
 import {
@@ -8,11 +9,12 @@ import {
   mockGetStackScripts,
 } from 'support/intercepts/stackscripts';
 import { ui } from 'support/ui';
+import { linodeCreatePage } from 'support/ui/pages';
 import { cleanUp } from 'support/util/cleanup';
-import { randomLabel, randomString } from 'support/util/random';
+import { randomLabel, randomNumber, randomString } from 'support/util/random';
 import { chooseRegion } from 'support/util/regions';
 
-import { stackScriptFactory } from 'src/factories';
+import { firewallFactory, stackScriptFactory } from 'src/factories';
 import { formatDate } from 'src/utilities/formatDate';
 
 import type { Profile, StackScript } from '@linode/api-v4';
@@ -284,11 +286,16 @@ describe('Community Stackscripts integration tests', () => {
     const image = 'AlmaLinux 9';
     const region = chooseRegion({ capabilities: ['Linodes', 'Vlans'] });
     const linodeLabel = randomLabel();
+    const mockFirewall = firewallFactory.build({
+      id: randomNumber(),
+      label: randomLabel(),
+    });
 
     // Ensure that the Primary Nav is open
     mockGetUserPreferences({ desktop_sidebar_open: false }).as(
       'getPreferences'
     );
+    mockGetFirewalls([mockFirewall]).as('getFirewalls');
     interceptGetStackScripts().as('getStackScripts');
     cy.visitWithLogin('/stackscripts/community');
     cy.wait(['@getStackScripts', '@getPreferences']);
@@ -422,6 +429,11 @@ describe('Community Stackscripts integration tests', () => {
     cy.get('[id="root-password"]').type(rootPassword);
     interceptCreateLinode().as('createLinode');
 
+    // Select a firewall
+    linodeCreatePage.selectFirewall(
+      mockFirewall.label,
+      'Public Interface Firewall'
+    );
     ui.button
       .findByTitle('Create Linode')
       .should('be.visible')

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,12 @@ describe('Create Linode', () => {`
`62`	`62`	`describe('End-to-end', () => {`
`63`	`63`	`// Run an end-to-end test to create a basic Linode for each plan type described below.`
`64`	`64`	`describe('By plan type', () => {`
	`65`	`+ beforeEach(() => {`
	`66`	`+ mockAppendFeatureFlags({`
	`67`	`+ linodeInterfaces: { enabled: false },`
	`68`	`+ iam: { enabled: false },`
	`69`	`+ });`
	`70`	`+ });`
`65`	`71`	`[`
`66`	`72`	`{`
`67`	`73`	`planId: 'g6-nanode-1',`