Skip to content

Commit 640d7a6

Browse files
authored
change: Update PULL_REQUEST_TEMPLATE (Part 3) (#11325)
* Address feedback from cafe * Added changeset: Further improvements to PR template author checklist sections
1 parent 8a6d1ca commit 640d7a6

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

docs/PULL_REQUEST_TEMPLATE.md

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,20 +48,23 @@ Please specify a release date (and environment, if applicable) to guarantee time
4848
- [ ] ...
4949
- [ ] ...
5050

51-
## As an Author, I have considered 🤔
52-
53-
- 👀 Doing a self review
54-
- ❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md)
55-
- 🤏 Splitting feature into small PRs
56-
- ➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset)
57-
- 🧪 Providing/improving test coverage
58-
- 🔐 Removing all sensitive information from the code and PR description
59-
- 🚩 Using a feature flag to protect the release
60-
- 👣 Providing comprehensive reproduction steps
61-
- 📑 Providing or updating our documentation
62-
- 🕛 Scheduling a pair reviewing session
63-
- 📱 Providing mobile support
64-
- ♿ Providing accessibility support
51+
<details>
52+
<summary> Author Checklists </summary>
53+
54+
## As an Author, to speed up the review process, I considered 🤔
55+
56+
👀 Doing a self review
57+
❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md)
58+
🤏 Splitting feature into small PRs
59+
➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset)
60+
🧪 Providing/improving test coverage
61+
🔐 Removing all sensitive information from the code and PR description
62+
🚩 Using a feature flag to protect the release
63+
👣 Providing comprehensive reproduction steps
64+
📑 Providing or updating our documentation
65+
🕛 Scheduling a pair reviewing session
66+
📱 Providing mobile support
67+
♿ Providing accessibility support
6568

6669
<br/>
6770

@@ -73,6 +76,8 @@ Please specify a release date (and environment, if applicable) to guarantee time
7376
- [ ] TypeScript compilation succeeded without errors
7477
- [ ] Code passes all linting rules
7578

79+
</details>
80+
7681
---
7782

7883
## Commit message and pull request title format standards
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Tech Stories
3+
---
4+
5+
Further improvements to PR template author checklist sections ([#11325](https://github.com/linode/manager/pull/11325))

0 commit comments

Comments
 (0)