Skip to content

Commit 6588e54

Browse files
refactor: STORIF-335 - Test fixed.
1 parent 998134e commit 6588e54

File tree

6 files changed

+58
-20
lines changed

6 files changed

+58
-20
lines changed

packages/manager/cypress/e2e/core/objectStorage/access-key.e2e.spec.ts

Lines changed: 29 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ describe('object storage access key end-to-end tests', () => {
4242

4343
mockGetAccount(accountFactory.build({ capabilities: ['Object Storage'] }));
4444
mockAppendFeatureFlags({
45-
objMultiCluster: false,
46-
objectStorageGen2: { enabled: false },
45+
objMultiCluster: true,
46+
objectStorageGen2: { enabled: true },
4747
});
4848

4949
cy.visitWithLogin('/object-storage/access-keys');
@@ -59,8 +59,14 @@ describe('object storage access key end-to-end tests', () => {
5959
.findByTitle('Create Access Key')
6060
.should('be.visible')
6161
.within(() => {
62-
cy.findByText('Label').click();
63-
cy.focused().type(keyLabel);
62+
cy.findByLabelText('Label', { exact: false })
63+
.should('be.visible')
64+
.type(keyLabel);
65+
66+
cy.findByLabelText('Regions', { exact: false })
67+
.should('be.visible')
68+
.type('Atlanta, {enter}');
69+
6470
ui.buttonGroup
6571
.findButtonByTitle('Create Access Key')
6672
.should('be.visible')
@@ -124,6 +130,7 @@ describe('object storage access key end-to-end tests', () => {
124130
const bucketClusterObj = chooseCluster();
125131
const bucketRequest = createObjectStorageBucketFactoryLegacy.build({
126132
cluster: bucketClusterObj.id,
133+
cors_enabled: true,
127134
label: bucketLabel,
128135
// Default factory sets `cluster` and `region`, but API does not accept `region` yet.
129136
region: undefined,
@@ -140,8 +147,8 @@ describe('object storage access key end-to-end tests', () => {
140147
accountFactory.build({ capabilities: ['Object Storage'] })
141148
);
142149
mockAppendFeatureFlags({
143-
objMultiCluster: false,
144-
objectStorageGen2: { enabled: false },
150+
objMultiCluster: true,
151+
objectStorageGen2: { enabled: true },
145152
});
146153

147154
interceptGetAccessKeys().as('getKeys');
@@ -160,10 +167,20 @@ describe('object storage access key end-to-end tests', () => {
160167
.findByTitle('Create Access Key')
161168
.should('be.visible')
162169
.within(() => {
163-
cy.findByText('Label').click();
164-
cy.focused().type(keyLabel);
165-
cy.findByLabelText('Limited Access').click();
166-
cy.findByLabelText('Select read-only for all').click();
170+
cy.findByLabelText('Label', { exact: false })
171+
.should('be.visible')
172+
.type(keyLabel);
173+
174+
cy.findByLabelText('Regions', { exact: false })
175+
.should('be.visible')
176+
.type('Atlanta, {enter}');
177+
178+
cy.focused().click();
179+
180+
cy.findByLabelText('Limited Access', { exact: false }).click();
181+
cy.findByLabelText('Select read-only for all', {
182+
exact: false,
183+
}).click();
167184

168185
ui.buttonGroup
169186
.findButtonByTitle('Create Access Key')
@@ -209,8 +226,8 @@ describe('object storage access key end-to-end tests', () => {
209226
});
210227
});
211228

212-
const permissionLabel = `This token has read-only access for ${bucketClusterObj.id}-${bucketLabel}`;
213-
cy.findByLabelText(permissionLabel).should('be.visible');
229+
const permissionLabel = `This access key has the following permissions:`;
230+
cy.findByText(permissionLabel).should('be.visible');
214231
});
215232
});
216233
});

packages/manager/cypress/e2e/core/objectStorage/access-keys.smoke.spec.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,19 @@ describe('object storage access keys smoke tests', () => {
5050
.findByTitle('Create Access Key')
5151
.should('be.visible')
5252
.within(() => {
53-
cy.findByLabelText('Label').click();
54-
cy.focused().type(mockAccessKey.label);
53+
cy.findByLabelText('Label', { exact: false })
54+
.should('be.visible')
55+
.type(mockAccessKey.label);
56+
57+
cy.findByLabelText('Regions', { exact: false })
58+
.should('be.visible')
59+
.type('Atlanta, {enter}');
60+
5561
ui.buttonGroup
5662
.findButtonByTitle('Create Access Key')
5763
.as('qaCreateAccessKey')
5864
.scrollIntoView();
65+
5966
cy.get('@qaCreateAccessKey')
6067
.should('be.visible')
6168
.should('be.enabled')

packages/manager/cypress/e2e/core/objectStorage/enable-object-storage.spec.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,14 @@ describe('Object Storage enrollment', () => {
298298
.findByTitle('Create Access Key')
299299
.should('be.visible')
300300
.within(() => {
301-
cy.findByLabelText('Label')
301+
cy.findByLabelText('Label', { exact: false })
302302
.should('be.visible')
303303
.type(mockAccessKey.label);
304304

305+
cy.findByLabelText('Regions', { exact: false })
306+
.should('be.visible')
307+
.type('Jakarta, ID{enter}');
308+
305309
ui.buttonGroup
306310
.findButtonByTitle('Create Access Key')
307311
.should('be.visible')
@@ -360,7 +364,13 @@ describe('Object Storage enrollment', () => {
360364
.findByTitle('Create Access Key')
361365
.should('be.visible')
362366
.within(() => {
363-
cy.findByLabelText('Label').should('be.visible').type(randomLabel());
367+
cy.findByLabelText('Label', { exact: false })
368+
.should('be.visible')
369+
.type(randomLabel());
370+
371+
cy.findByLabelText('Regions', { exact: false })
372+
.should('be.visible')
373+
.type('Jakarta, ID{enter}');
364374

365375
ui.buttonGroup
366376
.findButtonByTitle('Create Access Key')

packages/manager/cypress/e2e/core/objectStorage/object-storage.smoke.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('object storage smoke tests', () => {
4343
mockAppendFeatureFlags({
4444
gecko2: false,
4545
objMultiCluster: true,
46-
objectStorageGen2: { enabled: false },
46+
objectStorageGen2: { enabled: true },
4747
}).as('getFeatureFlags');
4848

4949
mockGetBuckets([]).as('getBuckets');
@@ -65,7 +65,7 @@ describe('object storage smoke tests', () => {
6565
cy.findByLabelText('Bucket Name (required)').click();
6666
cy.focused().type(bucketLabel);
6767
ui.regionSelect.find().click();
68-
cy.focused().type(`${mockCluster.id}{enter}`);
68+
cy.focused().type(`${mockRegion.label}{enter}`);
6969
ui.buttonGroup
7070
.findButtonByTitle('Create Bucket')
7171
.should('be.visible')

packages/manager/cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const emptyFolderMessage = 'This folder is empty.';
2727
* @returns Non-empty bucket error message.
2828
*/
2929
const getNonEmptyBucketMessage = (bucketLabel: string) => {
30-
return `Bucket ${bucketLabel} is not empty. Please delete all objects and try again.`;
30+
return `The specified bucket '${bucketLabel}' is not empty. Please delete all objects before retrying.`;
3131
};
3232

3333
/**

packages/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyTable/HostNameTableCell.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@ export const HostNameTableCell = (props: Props) => {
5050
{showMultipleRegions ? (
5151
<>
5252
| + {pluralize('region', 'regions', regions.length - 1)} |&nbsp;
53-
<LinkButton onClick={() => openDrawer('access-key-hostnames')}>
53+
<LinkButton
54+
onClick={() =>
55+
openDrawer('access-key-hostnames', storageKeyData.id)
56+
}
57+
>
5458
Show All
5559
</LinkButton>
5660
<StyledCopyIcon text={allEndpoints} />

0 commit comments

Comments
 (0)