fix: [UIE-9840] - IAM: Remove Role filter (already assigned roles) in ChangeRoleDrawer (#13212)

* remove role filtering in change role drawer

* Added changeset: IAM: Remove Role filter (already assigned roles) in ChangeRoleDrawer

* fix test

Author: abailly-akamai

packages/manager/.changeset/pr-13212-fixed-1766134000452.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+IAM: Remove Role filter (already assigned roles) in ChangeRoleDrawer ([#13212](https://github.com/linode/manager/pull/13212))

packages/manager/src/features/IAM/Shared/AssignedRolesTable/ChangeRoleDrawer.test.tsx

@@ -196,32 +196,4 @@ describe('ChangeRoleDrawer', () => {
       mockAccountAccessRole.name
     );
   });
-
-  it('should not list roles that the user already has', async () => {
-    queryMocks.useUserRoles.mockReturnValue({
-      data: {
-        account_access: ['account_linode_admin', 'account_viewer'],
-        entity_access: [],
-      },
-    });
-
-    queryMocks.useAccountRoles.mockReturnValue({
-      data: accountRolesFactory.build(),
-    });
-
-    renderWithTheme(<ChangeRoleDrawer {...props} mode="change-role" />);
-
-    const autocomplete = screen.getByRole('combobox');
-
-    await userEvent.click(autocomplete);
-
-    // expect select not to have the current role as one of the options
-    const options = screen.getAllByRole('option');
-    expect(options.map((option) => option.textContent)).not.toContain(
-      'account_linode_admin'
-    );
-    expect(options.map((option) => option.textContent)).not.toContain(
-      'account_viewer'
-    );
-  });
 });

packages/manager/src/features/IAM/Shared/AssignedRolesTable/ChangeRoleDrawer.tsx

@@ -92,22 +92,15 @@ export const ChangeRoleDrawer = ({ mode, onClose, open, role }: Props) => {
         el.value !== role?.name;
       // Exclude account roles already assigned to the user
       if (isAccountRole(el)) {
-        return (
-          !assignedRoles?.account_access.includes(el.value) &&
-          matchesRoleContext
-        );
+        return matchesRoleContext;
       }
       // Exclude entity roles already assigned to the user
       if (isEntityRole(el)) {
-        return (
-          !assignedRoles?.entity_access.some((entity) =>
-            entity.roles.includes(el.value)
-          ) && matchesRoleContext
-        );
+        return matchesRoleContext;
       }
       return true;
     });
-  }, [accountRoles, assignedRoles, role]);
+  }, [accountRoles, role]);
 
   const {
     control,