Commit 79bd9e4
authored
fix: [M3-9360] - Collapsible Node Pool overflow bug (#11699)
## Description 📝
1. Fix y-axis overflow when a Node Pool with a table is collapsed by setting the `PaginationFooter` position to be relative
- This was caused due to the `visually-hidden` style we're applying to the footer label which has `position: absolute`, so it didn't follow the outer div's `overflow: hidden` rule
- https://stackoverflow.com/questions/4605715/position-absolute-and-overflow-hidden
2. Unmount accordion content if there are more than 25 nodes for [performance](https://mui.com/material-ui/react-accordion/#performance)
## Target release date 🗓️
2/25
## How to test 🧪
### Reproduction steps
(How to reproduce the issue, if applicable)
- [ ] On a different branch, go to a cluster's details page with the MSW on
- [ ] Observe the y-axis overflow when the node pool with a table is collapsed
### Verification steps
(How to verify changes)
- [ ] Checkout this branch or preview link, go to a cluster's details page with the MSW on
- [ ] Observe that there is **no** y-axis overflow when the node pool with a table is collapsed
- [ ] Collapsed Accordion content should not exist in the DOM if the pool has more than 25 nodes1 parent 36a3a6b commit 79bd9e4
File tree
3 files changed
+8
-0
lines changed- packages/manager
- src/features/Kubernetes/KubernetesClusterDetail/NodePoolsDisplay
3 files changed
+8
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| 219 | + | |
| 220 | + | |
219 | 221 | | |
220 | 222 | | |
221 | 223 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
251 | 256 | | |
252 | 257 | | |
253 | 258 | | |
| |||
0 commit comments