change: [DPS-35650] Logs: minor UI fixes and improvements (#13166)

Author: mduda-akamai

packages/manager/.changeset/pr-13166-changed-1764854054943.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Changed
+---
+
+Logs: Many minor UI fixes and improvements ([#13166](https://github.com/linode/manager/pull/13166))

packages/manager/cypress/e2e/core/delivery/create-stream.spec.ts

@@ -166,7 +166,7 @@ describe('Create Stream', () => {
     });
   });
 
-  describe('given Kubernetes Audit Logs Stream Type', () => {
+  describe('given Kubernetes API Audit Logs Stream Type', () => {
     it('selects clusters and creates new stream', () => {
       // Mock API responses
       mockGetDestinations([mockDestination]);

packages/manager/cypress/e2e/core/delivery/edit-stream.spec.ts

@@ -143,7 +143,7 @@ describe('Edit Stream', () => {
     });
   });
 
-  describe('given Kubernetes Audit Logs Stream Type', () => {
+  describe('given Kubernetes API Audit Logs Stream Type', () => {
     it('edits stream label and clusters and saves', () => {
       // Mock API responses
       mockGetDestinations([mockDestination]);
@@ -192,7 +192,7 @@ describe('Edit Stream', () => {
       cy.findByLabelText('Stream Type')
         .should('be.visible')
         .should('be.disabled')
-        .should('have.attr', 'value', 'Kubernetes Audit Logs');
+        .should('have.attr', 'value', 'Kubernetes API Audit Logs');
 
       // Clusters table should be visible
       cy.findByText('Clusters').should('be.visible');

packages/manager/cypress/support/constants/delivery.ts

@@ -15,7 +15,7 @@ export const mockDestinationPayload: CreateDestinationPayload = {
   type: destinationType.AkamaiObjectStorage,
   details: {
     host: randomString(),
-    bucket_name: randomString(),
+    bucket_name: randomLabel(),
     access_key_id: randomString(),
     access_key_secret: randomString(),
     path: '/',

packages/manager/src/components/PrimaryNav/PrimaryNav.tsx

@@ -248,16 +248,16 @@ export const PrimaryNav = (props: PrimaryNavProps) => {
                 to: '/alerts',
                 isBeta: flags.aclpAlerting?.beta,
               },
-              {
-                display: 'Longview',
-                to: '/longview',
-              },
               {
                 display: 'Logs',
                 hide: !isACLPLogsEnabled,
                 to: '/logs/delivery',
                 isBeta: isACLPLogsBeta,
               },
+              {
+                display: 'Longview',
+                to: '/longview',
+              },
             ],
             name: 'Monitor',
           },

packages/manager/src/factories/delivery.ts

@@ -6,7 +6,7 @@ import type { Destination } from '@linode/api-v4';
 export const destinationFactory = Factory.Sync.makeFactory<Destination>({
   details: {
     access_key_id: 'Access Id',
-    bucket_name: 'Bucket Name',
+    bucket_name: 'destinations-bucket-name',
     host: '3000',
     path: 'file',
   },

packages/manager/src/features/Delivery/DeliveryLanding.tsx

@@ -30,6 +30,7 @@ export const DeliveryLanding = React.memo(() => {
     breadcrumbProps: {
       pathname: '/logs/delivery',
     },
+    docsLink: 'https://techdocs.akamai.com/cloud-computing/docs/log-delivery',
     removeCrumbX: 1,
     entity: 'Delivery',
     title: 'Logs', // TODO: Change to "Delivery" all "Logs" occurrences after adding LogsLanding page

packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx

@@ -47,9 +47,9 @@ describe('DestinationCreate', () => {
       const destinationNameInput = screen.getByLabelText('Destination Name');
       await userEvent.type(destinationNameInput, 'Test');
       const hostInput = screen.getByLabelText('Host');
-      await userEvent.type(hostInput, 'Test');
+      await userEvent.type(hostInput, 'test');
       const bucketInput = screen.getByLabelText('Bucket');
-      await userEvent.type(bucketInput, 'Test');
+      await userEvent.type(bucketInput, 'test');
       const accessKeyIDInput = screen.getByLabelText('Access Key ID');
       await userEvent.type(accessKeyIDInput, 'Test');
       const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
@@ -58,8 +58,8 @@ describe('DestinationCreate', () => {
       await userEvent.type(logPathPrefixInput, 'Test');
 
       expect(destinationNameInput).toHaveValue('Test');
-      expect(hostInput).toHaveValue('Test');
-      expect(bucketInput).toHaveValue('Test');
+      expect(hostInput).toHaveValue('test');
+      expect(bucketInput).toHaveValue('test');
       expect(accessKeyIDInput).toHaveValue('Test');
       expect(secretAccessKeyInput).toHaveValue('Test');
       expect(logPathPrefixInput).toHaveValue('Test');
@@ -114,9 +114,9 @@ describe('DestinationCreate', () => {
       const destinationNameInput = screen.getByLabelText('Destination Name');
       await userEvent.type(destinationNameInput, 'Test');
       const hostInput = screen.getByLabelText('Host');
-      await userEvent.type(hostInput, 'Test');
+      await userEvent.type(hostInput, 'test');
       const bucketInput = screen.getByLabelText('Bucket');
-      await userEvent.type(bucketInput, 'Test');
+      await userEvent.type(bucketInput, 'test');
       const accessKeyIDInput = screen.getByLabelText('Access Key ID');
       await userEvent.type(accessKeyIDInput, 'Test');
       const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');

packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.tsx

@@ -32,6 +32,7 @@ export const DestinationCreate = () => {
         },
       ],
     },
+    docsLink: 'https://techdocs.akamai.com/cloud-computing/docs/log-delivery',
     removeCrumbX: [1, 2],
     title: 'Create Destination',
   };

packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationEdit.test.tsx

@@ -52,7 +52,7 @@ describe('DestinationEdit', () => {
       assertInputHasValue('Destination Name', 'Destination 123');
     });
     assertInputHasValue('Host', '3000');
-    assertInputHasValue('Bucket', 'Bucket Name');
+    assertInputHasValue('Bucket', 'destinations-bucket-name');
     assertInputHasValue('Access Key ID', 'Access Id');
     assertInputHasValue('Secret Access Key', '');
     assertInputHasValue('Log Path Prefix', 'file');