Skip to content

Commit 8ee5281

Browse files
feat: [M3-6941]- Uniform Spacing b/w Resource Link Columns In Empty State Landing Pages (#11213)
* Fix spacing for empty state landing pages * Fix styling for mobile and empty youtube resource sections * Add changeset
1 parent d52d108 commit 8ee5281

File tree

8 files changed

+20
-8
lines changed

8 files changed

+20
-8
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Tech Stories
3+
---
4+
5+
Uniform Spacing b/w Resource Link Columns in Empty State Landing Pages ([#11213](https://github.com/linode/manager/pull/11213))

packages/manager/src/components/EmptyLandingPageResources/ResourcesLinksSection.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,16 @@ const StyledResourcesLinksSection = styled('div', {
1818
display: 'grid',
1919
gridAutoColumns: '1fr',
2020
gridAutoFlow: 'column',
21-
justifyItems: 'center',
22-
maxWidth: props.wide === false ? 762 : '100%',
21+
[theme.breakpoints.between('md', 'lg')]: {
22+
width: 'auto',
23+
},
2324
[theme.breakpoints.down(props.wide ? 'lg' : 'md')]: {
2425
gridAutoFlow: 'row',
2526
justifyItems: 'start',
27+
maxWidth: props.wide === false ? 361 : '100%',
2628
rowGap: theme.spacing(8),
2729
},
30+
width: props.wide === false ? 762 : '100%',
2831
}));
2932

3033
export const ResourcesLinksSection = ({

packages/manager/src/components/EmptyLandingPageResources/ResourcesLinksSubSection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const StyledResourcesLinksSubSection = styled('div', {
1717
'& > a': {
1818
display: 'inline-block',
1919
fontFamily: theme.font.bold,
20+
width: '100%',
2021
},
2122
'& > h2': {
2223
color: theme.palette.text.primary,
@@ -34,7 +35,6 @@ const StyledResourcesLinksSubSection = styled('div', {
3435
fontSize: '0.875rem',
3536
gridTemplateRows: `22px minmax(${theme.spacing(3)}, 100%) 1.125rem`,
3637
rowGap: theme.spacing(2),
37-
width: '100%',
3838
}));
3939

4040
export const ResourcesLinksSubSection = (

packages/manager/src/components/Placeholder/Placeholder.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,15 @@ import { styled, useTheme } from '@mui/material/styles';
22
import * as React from 'react';
33

44
import LinodeIcon from 'src/assets/addnewmenu/linode.svg';
5-
import { Button, ButtonProps } from 'src/components/Button/Button';
5+
import { Button } from 'src/components/Button/Button';
66
import { H1Header } from 'src/components/H1Header/H1Header';
77
import { Typography } from 'src/components/Typography';
88
import { fadeIn } from 'src/styles/keyframes';
99

1010
import { TransferDisplay } from '../TransferDisplay/TransferDisplay';
1111

12+
import type { ButtonProps } from 'src/components/Button/Button';
13+
1214
export interface ExtendedButtonProps extends ButtonProps {
1315
target?: string;
1416
}

packages/manager/src/features/Kubernetes/KubernetesLanding/KubernetesLanding.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,5 +286,3 @@ export const kubernetesLandingLazyRoute = createLazyRoute(
286286
)({
287287
component: KubernetesLanding,
288288
});
289-
290-
export default KubernetesLanding;

packages/manager/src/features/Kubernetes/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ import { Redirect, Route, Switch } from 'react-router-dom';
44
import { ProductInformationBanner } from 'src/components/ProductInformationBanner/ProductInformationBanner';
55
import { SuspenseLoader } from 'src/components/SuspenseLoader';
66

7-
const KubernetesLanding = React.lazy(
8-
() => import('./KubernetesLanding/KubernetesLanding')
7+
const KubernetesLanding = React.lazy(() =>
8+
import('./KubernetesLanding/KubernetesLanding').then((module) => ({
9+
default: module.KubernetesLanding,
10+
}))
911
);
1012

1113
const ClusterCreate = React.lazy(() =>

packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsLandingEmptyState.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ export const PlacementGroupsLandingEmptyState = ({
3939
headers={headers}
4040
icon={LinodeIcon}
4141
linkAnalyticsEvent={linkAnalyticsEvent}
42+
wide
4243
/>
4344
);
4445
};

packages/manager/src/features/VPCs/VPCLanding/VPCEmptyState.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ export const VPCEmptyState = () => {
4242
headers={headers}
4343
icon={NodeBalancerIcon}
4444
linkAnalyticsEvent={linkAnalyticsEvent}
45+
wide
4546
/>
4647
);
4748
};

0 commit comments

Comments
 (0)