tech-story - [UIE-9306]: Improve user seeding (follow up) (#12978)

* distinctive seeding

* handle dupe records

* Update packages/manager/src/mocks/presets/crud/seeds/utils.ts

Co-authored-by: Copilot <[email protected]>

* lint

---------

Co-authored-by: Copilot <[email protected]>

Author: abailly-akamai

packages/manager/src/mocks/presets/crud/seeds/index.ts

@@ -7,7 +7,7 @@ import { ipAddressSeeder } from './networking';
 import { nodeBalancerSeeder } from './nodebalancers';
 import { placementGroupSeeder } from './placementGroups';
 import { supportTicketsSeeder } from './supportTickets';
-import { usersSeeder } from './users';
+import { defaultUsersSeeder, parentUsersSeeder } from './users';
 import { volumesSeeder } from './volumes';
 import { vpcSeeder } from './vpcs';
 
@@ -21,7 +21,8 @@ export const dbSeeders = [
   nodeBalancerSeeder,
   placementGroupSeeder,
   supportTicketsSeeder,
-  usersSeeder,
+  defaultUsersSeeder,
+  parentUsersSeeder,
   volumesSeeder,
   vpcSeeder,
 ];

packages/manager/src/mocks/presets/crud/seeds/users.ts

@@ -1,4 +1,3 @@
-import { getProfile } from '@linode/api-v4';
 import { childAccountFactory } from '@linode/utilities';
 
 import { getSeedsCountMap } from 'src/dev-tools/utils';
@@ -17,26 +16,108 @@ import type {
   UserRolesEntry,
 } from 'src/mocks/types';
 
-export const usersSeeder: MockSeeder = {
+export const defaultUsersSeeder: MockSeeder = {
   canUpdateCount: true,
   desc: 'Users Seeds with Permissions',
   group: { id: 'Users' },
-  id: 'users:crud',
-  label: 'Users',
+  id: 'users(default):crud',
+  label: 'Default Users',
 
   seeder: async (mockState: MockState) => {
     const seedsCountMap = getSeedsCountMap();
-    const count = seedsCountMap[usersSeeder.id] ?? 0;
-    const profile = await getProfile();
+    const count = seedsCountMap[defaultUsersSeeder.id] ?? 0;
 
     const userSeeds = seedWithUniqueIds<'users'>({
       dbEntities: await mswDB.getAll('users'),
       seedEntities: accountUserFactory.buildList(count, {
-        user_type: profile?.user_type,
-        restricted: profile?.restricted,
+        user_type: 'default',
+        restricted: true,
       }),
     });
 
+    const userRolesEntries: UserRolesEntry[] = [];
+    const userAccountPermissionsEntries: UserAccountPermissionsEntry[] = [];
+    const userEntityPermissionsEntries: UserEntityPermissionsEntry[] = [];
+
+    userSeeds.forEach((user) => {
+      const userRoles = userDefaultRolesFactory.build();
+      userRolesEntries.push({
+        username: user.username,
+        roles: userRoles,
+      });
+
+      if (userRoles.account_access) {
+        userAccountPermissionsEntries.push({
+          username: user.username,
+          permissions: userRoles.account_access,
+        });
+      }
+
+      if (userRoles.entity_access) {
+        for (const entityAccess of userRoles.entity_access) {
+          userEntityPermissionsEntries.push({
+            username: user.username,
+            entityType: entityAccess.type,
+            entityId: entityAccess.id,
+            permissions: entityAccess.roles,
+          });
+        }
+      }
+    });
+
+    const updatedMockState = {
+      ...mockState,
+      users: (mockState.users ?? []).concat(userSeeds),
+      userRoles: (mockState.userRoles ?? []).concat(userRolesEntries),
+      userAccountPermissions: (mockState.userAccountPermissions ?? []).concat(
+        userAccountPermissionsEntries
+      ),
+      userEntityPermissions: (mockState.userEntityPermissions ?? []).concat(
+        userEntityPermissionsEntries
+      ),
+    };
+
+    await mswDB.saveStore(updatedMockState, 'seedState');
+
+    return updatedMockState;
+  },
+};
+
+/**
+ * This way, when you seed 10 parent users, you'll get:
+ * 10 parent users
+ * 30 child accounts (3 per parent)
+ * 60 child users (2 per child account)
+ * 10 delegate users (1 per parent)
+ * All the proper relationships and permissions
+ */
+export const parentUsersSeeder: MockSeeder = {
+  canUpdateCount: true,
+  desc: 'Parent Users (with child accounts and delegations)',
+  group: { id: 'Users' },
+  id: 'users(parent):crud',
+  label: 'Parent Users (with child accounts and delegations)',
+
+  seeder: async (mockState: MockState) => {
+    const seedsCountMap = getSeedsCountMap();
+    const count = seedsCountMap[parentUsersSeeder.id] ?? 0;
+
+    const existingUsers = await mswDB.getAll('users');
+    const existingUsernames = existingUsers?.map((u) => u.username) || [];
+
+    // Only create users that don't already exist
+    const newUsers = accountUserFactory
+      .buildList(count, {
+        user_type: 'parent',
+        restricted: false,
+      })
+      .filter((user) => !existingUsernames.includes(user.username));
+
+    const userSeeds = seedWithUniqueIds<'users'>({
+      dbEntities: existingUsers,
+      seedEntities: newUsers,
+    });
+
     const userRolesEntries: UserRolesEntry[] = [];
     const userAccountPermissionsEntries: UserAccountPermissionsEntry[] = [];
     const userEntityPermissionsEntries: UserEntityPermissionsEntry[] = [];
@@ -69,26 +150,56 @@ export const usersSeeder: MockSeeder = {
       }
 
       // Create child accounts and delegations for parent users
-      if (user.user_type === 'parent') {
-        const delegateUser = accountUserFactory.build({
-          username: `${user.username}_delegate`,
-          user_type: 'delegate',
-          email: `${user.username}[email protected]`,
-          restricted: false,
+      const childAccounts = childAccountFactory.buildList(3);
+      for (const childAccount of childAccounts) {
+        childAccountsToAdd.push(childAccount);
+        delegationsToAdd.push({
+          username: user.username,
+          childAccountEuuid: childAccount.euuid,
+          id: Math.floor(Math.random() * 1000000),
         });
-        userSeeds.push(delegateUser);
 
-        const childAccounts = childAccountFactory.buildList(3);
+        // Create child users for each child account
+        const childUsers = accountUserFactory
+          .buildList(2, {
+            user_type: 'child',
+            restricted: true,
+          })
+          .map((user, index) => ({
+            ...user,
+            username: `child-user-${childAccount.euuid}-${index}`,
+            email: `child-user-${childAccount.euuid}-${index}@example.com`,
+          }));
 
-        for (const childAccount of childAccounts) {
-          childAccountsToAdd.push(childAccount);
-          delegationsToAdd.push({
-            username: user.username,
-            childAccountEuuid: childAccount.euuid,
-            id: Math.floor(Math.random() * 1000000),
+        for (const childUser of childUsers) {
+          userSeeds.push(childUser);
+
+          // Add roles for child users
+          const childUserRoles = userDefaultRolesFactory.build();
+          userRolesEntries.push({
+            username: childUser.username,
+            roles: childUserRoles,
           });
+
+          // Add permissions if needed
+          if (childUserRoles.account_access) {
+            userAccountPermissionsEntries.push({
+              username: childUser.username,
+              permissions: childUserRoles.account_access,
+            });
+          }
         }
       }
+
+      // Create delegate users for each parent user
+      const delegateUsers = accountUserFactory.build({
+        user_type: 'delegate',
+        username: `delegateuser-${user.username}-${Math.floor(Math.random() * 100000)}-${Math.floor(Math.random() * 1000000)}`,
+        email: `${user.username}[email protected]`,
+        restricted: false,
+      });
+
+      userSeeds.push(delegateUsers);
     });
 
     const updatedMockState = {

packages/manager/src/mocks/presets/crud/seeds/utils.ts

@@ -42,6 +42,8 @@ export const removeSeeds = async (seederId: MockSeeder['id']) => {
     case 'support-tickets:crud':
       await mswDB.deleteAll('supportTickets', mockState, 'seedState');
       break;
+    case 'users(default):crud':
+    case 'users(parent):crud':
     case 'users:crud':
       await mswDB.deleteAll('users', mockState, 'seedState');
       await mswDB.deleteAll('userRoles', mockState, 'seedState');

packages/manager/src/mocks/types.ts

@@ -162,6 +162,8 @@ export type MockPresetCrudId =
   | 'placement-groups:crud'
   | 'quotas:crud'
   | 'support-tickets:crud'
+  | 'users(default):crud'
+  | 'users(parent):crud'
   | 'users:crud'
   | 'volumes:crud'
   | 'vpcs:crud';