diff --git a/packages/manager/.changeset/pr-13449-tests-1772265280573.md b/packages/manager/.changeset/pr-13449-tests-1772265280573.md new file mode 100644 index 00000000000..77c72eea0fd --- /dev/null +++ b/packages/manager/.changeset/pr-13449-tests-1772265280573.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Tests +--- + +Adding spec for show details notification channel ([#13449](https://github.com/linode/manager/pull/13449)) diff --git a/packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts b/packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts new file mode 100644 index 00000000000..3825322f158 --- /dev/null +++ b/packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts @@ -0,0 +1,573 @@ +/** + * @file Integration Tests for the CloudPulse Alerts Notification Channel Show Detail Page. + * + * This file contains Cypress tests that validate the display and content of the Alerts Notification channel Show Detail Page in the CloudPulse application. + * It ensures that all alert details, criteria, and entity information are displayed correctly. + */ +import { profileFactory } from '@linode/utilities'; +import { cloudPulseServiceMap } from 'support/constants/cloudpulse'; +import { mockGetAccount } from 'support/intercepts/account'; +import { + mockGetAlertChannelById, + mockGetAlertChannelByIdError, + mockGetAlertChannels, + mockGetAlertDefinitions, + mockGetAlertsForChannelId, + mockGetAlertsForChannelIdError, + mockGetCloudPulseServices, +} from 'support/intercepts/cloudpulse'; +import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags'; +import { mockGetProfile } from 'support/intercepts/profile'; +import { ui } from 'support/ui'; + +import { notificationChannelAlertsFactory } from 'src/factories'; +import { + accountFactory, + alertFactory, + flagsFactory, + notificationChannelFactory, +} from 'src/factories'; +import { formatDate } from 'src/utilities/formatDate'; + +// Define mock data for the test. + +const mockAccount = accountFactory.build(); +const mockProfile = profileFactory.build({ + restricted: false, + timezone: 'gmt', +}); + +const notificationChannelDetails = notificationChannelFactory.buildList(1, { + label: 'Notification channel 1', + channel_type: 'email', + type: 'user', + details: { + email: { + recipient_type: 'user', + usernames: ['admin-user', 'john-doe', 'jane-smith'], + }, + }, + created_by: 'user1', + updated_by: 'user2', + created: '2026-01-27T06:18:00Z', + updated: new Date().toISOString(), +}); +const { + label, + id, + type, + channel_type, + details, + created_by, + created, + updated, + updated_by, +} = notificationChannelDetails[0]; + +const mockAlerts = [ + ...notificationChannelAlertsFactory.buildList(2, { + service_type: 'linode', + }), + ...notificationChannelAlertsFactory.buildList(2, { + service_type: 'dbaas', + }), + ...notificationChannelAlertsFactory.buildList(2, { + service_type: 'nodebalancer', + }), + ...notificationChannelAlertsFactory.buildList(2, { + service_type: 'lke', + }), + ...notificationChannelAlertsFactory.buildList(2, { + service_type: 'firewall', + }), + ...notificationChannelAlertsFactory.buildList(2, { + service_type: 'objectstorage', + }), + ...notificationChannelAlertsFactory.buildList(2, { + service_type: 'blockstorage', + }), +]; +/** + * Verifies that alert rows are displayed in the expected order. + * @param expectedAlerts - Alerts sorted into their expected display order. + */ +const verifyAlertOrder = (expectedAlerts: { id: number }[]): void => { + cy.get('[data-qa-alert-cell]').then(($cells) => { + const alertRowIds = $cells + .map((_, cell) => + parseInt(cell.getAttribute('data-qa-alert-cell') || '0', 10) + ) + .get(); + expectedAlerts.forEach((alert, index) => { + expect(alertRowIds[index]).to.equal(alert.id); + }); + }); +}; + +describe('CloudPulse Alerting - Notification Channel Show details Validation', () => { + beforeEach(() => { + // Setup all mock APIs - tests will navigate directly to detail page + const mockflags = flagsFactory.build({ + aclpAlerting: { + notificationChannels: true, + }, + aclpServices: { + linode: { + alerts: { beta: true, enabled: true }, + metrics: { beta: true, enabled: true }, + }, + dbaas: { + alerts: { beta: true, enabled: true }, + metrics: { beta: true, enabled: true }, + }, + nodebalancer: { + alerts: { beta: true, enabled: true }, + metrics: { beta: true, enabled: true }, + }, + firewall: { + alerts: { beta: true, enabled: true }, + metrics: { beta: true, enabled: true }, + }, + lke: { + alerts: { beta: true, enabled: true }, + metrics: { beta: true, enabled: true }, + }, + objectstorage: { + alerts: { beta: true, enabled: true }, + metrics: { beta: true, enabled: true }, + }, + blockstorage: { + alerts: { beta: true, enabled: true }, + metrics: { beta: true, enabled: true }, + }, + }, + }); + mockAppendFeatureFlags(mockflags); + mockGetAccount(mockAccount); + mockGetProfile(mockProfile); + mockGetAlertChannels(notificationChannelDetails).as( + 'getAlertNotificationChannels' + ); + mockGetAlertChannelById(id, notificationChannelDetails[0]).as( + 'getAlertNotificationChannelById' + ); + mockGetAlertsForChannelId(id, mockAlerts).as('getAlertsForChannelId'); + mockGetCloudPulseServices(Object.keys(cloudPulseServiceMap)).as( + 'getCloudPulseServices' + ); + }); + + it('should navigate to the Show Details page from the notification channels list page', () => { + // Navigate to the notification channels list page with login + cy.visitWithLogin('/alerts/notification-channels'); + + // Wait for the notification channels list API call to complete + cy.wait('@getAlertNotificationChannels'); + + // Locate the notification channel with the specified label in the table + cy.findByText(label).should('be.visible'); + cy.findByText(label) + .closest('tr') + .within(() => { + ui.actionMenu + .findByTitle(`Action menu for Notification Channel ${label}`) + .should('be.visible') + .click(); + // Select the "Show Details" option from the action menu + ui.actionMenuItem + .findByTitle('Show Details') + .should('be.visible') + .click(); + }); + + // Verify the URL navigates to the correct details page + cy.url().should('include', `/alerts/notification-channels/detail/${id}`); + }); + + it('should display correct notification channel details', () => { + // Navigate directly to the notification channel detail page + cy.visitWithLogin(`/alerts/notification-channels/detail/${id}`); + cy.wait('@getAlertNotificationChannelById'); + cy.wait('@getAlertsForChannelId'); + cy.wait('@getCloudPulseServices'); + // Verify breadcrumb heading + ui.breadcrumb.find().within(() => { + cy.contains('Notification Channels').should('be.visible'); + cy.contains('Details').should('be.visible'); + }); + + // Verify url correctness + cy.url().should('include', `/alerts/notification-channels/detail/${id}`); + + // Validating contents of Overview Section + cy.get('[data-qa-section="Overview"]').within(() => { + // Validate Name field + cy.findByText('Name:').should('be.visible'); + cy.findByText(label).should('be.visible'); + + // Validate Description field + cy.findByText('Channel Type:').should('be.visible'); + cy.findByText( + `${channel_type[0].toUpperCase()}${channel_type.slice(1)}` + ).should('be.visible'); + + // Validate Created By field + cy.findByText('Created by:').should('be.visible'); + cy.findByText(created_by).should('be.visible'); + + // Validate Created Time field + cy.findByText('Creation Time:').should('be.visible'); + + cy.findByText( + formatDate(created, { + format: 'MMM dd, yyyy, h:mm a', + timezone: 'GMT', + }) + ).should('be.visible'); + + // Validate Last Modified field + cy.findByText('Last Modified:').should('be.visible'); + + cy.findByText( + formatDate(updated, { + format: 'MMM dd, yyyy, h:mm a', + timezone: 'GMT', + }) + ).should('be.visible'); + + cy.findByText('Last Modified by:').should('be.visible'); + cy.findByText(updated_by).should('be.visible'); + }); + cy.get('[data-qa-section="Details"]').within(() => { + // Validate Recipient type field + cy.findByText('Recipient Type:').should('be.visible'); + cy.get('[data-qa-chip="user"]').should('have.text', type); + + // Validate Recipients field + if (channel_type === 'email' && details && 'email' in details) { + const usernames = details.email.usernames; + usernames.forEach((username) => { + cy.get(`[data-qa-chip="${username}"]`) + .should('have.text', username) + .should('be.visible'); + }); + } + }); + + cy.get('[data-qa-section="Associated Alerts"]').within(() => { + // Validate for search box + cy.findByPlaceholderText('Search for Alerts').should('be.visible'); + + // Validate for search a service type + cy.findByPlaceholderText('Select a Service').should('be.visible'); + + const expectedHeaders = ['Alert Name', 'Service']; + + // Validate table headers + cy.get('[data-qa="associated-alerts-table"]').within(() => { + expectedHeaders.forEach((header) => { + cy.findByText(header).should('have.text', header); + }); + }); + + // Validate alert details + mockAlerts.forEach((alert) => { + cy.get(`[data-qa-alert-cell="${alert.id}"]`) + .contains(cloudPulseServiceMap[alert.service_type]) + .should('be.visible') + .and('have.text', `${cloudPulseServiceMap[alert.service_type]} beta`); + }); + }); + }); + + it('should verify search and sort functionality in Associated Alerts table', () => { + // Navigate directly to the notification channel detail page + cy.visitWithLogin(`/alerts/notification-channels/detail/${id}`); + cy.wait('@getAlertNotificationChannelById'); + cy.wait('@getAlertsForChannelId'); + cy.wait('@getCloudPulseServices'); + cy.get('[data-qa-section="Associated Alerts"]').within(() => { + cy.findByPlaceholderText('Search for Alerts').as('searchInput'); + cy.get('@searchInput').clear(); + cy.get('@searchInput').type(mockAlerts[0].label); + // Dynamically get the length based on filtered results + const filteredAlertsLen = mockAlerts.filter((alert) => + alert.label.toLowerCase().includes(mockAlerts[0].label.toLowerCase()) + ).length; + cy.get('[data-qa="associated-alerts-table"]') + .find('tbody') + .last() + .find('tr') + .should('have.length', filteredAlertsLen); + cy.get(`[data-qa-alert-cell="${mockAlerts[0].id}"]`).should('be.visible'); + cy.get('@searchInput').clear(); + // Validate for search a service type + cy.findByPlaceholderText('Select a Service').as('searchServiceType'); + cy.get('@searchServiceType').type('Databases'); + cy.get('[data-qa-option="true"]').contains('Databases').click(); + + // Verify that the table displays only alerts related to 'dbaas' service type + const dbaasAlerts = mockAlerts.filter( + (alert) => alert.service_type === 'dbaas' + ); + cy.get('[data-qa="associated-alerts-table"]') + .find('tbody') + .last() + .find('tr') + .should('have.length', dbaasAlerts.length); + dbaasAlerts.forEach((alert) => { + cy.get(`[data-qa-alert-cell="${alert.id}"]`).should('be.visible'); + }); + + // Clear the service filter + ui.button + .findByAttribute('aria-label', 'Clear') + .should('be.visible') + .click(); + + // Validate the sorting functionality for Alert Name + cy.get('[data-qa="associated-alerts-table"]').within(() => { + // Click on the 'Alert Name' header to sort + ui.heading.findByText('label').click(); + + // Get the sort order and verify data matches + const AlertNameHeading = ui.heading.findByText('label'); + AlertNameHeading.should('have.attr', 'aria-sort').then((sortOrder) => { + let expectedAlerts; + if (sortOrder === 'ascending') { + expectedAlerts = [...mockAlerts].sort((a, b) => + a.label.localeCompare(b.label) + ); + } else { + expectedAlerts = [...mockAlerts].sort((a, b) => + b.label.localeCompare(a.label) + ); + } + verifyAlertOrder(expectedAlerts); + }); + + // Click again to toggle sort order + ui.heading.findByText('label').click(); + + // Get the new sort order and verify data matches + const AlertNameHeadingAfterToggle = ui.heading.findByText('label'); + AlertNameHeadingAfterToggle.should('have.attr', 'aria-sort').then( + (sortOrder) => { + let expectedAlerts; + if (sortOrder === 'ascending') { + expectedAlerts = [...mockAlerts].sort((a, b) => + a.label.localeCompare(b.label) + ); + } else { + expectedAlerts = [...mockAlerts].sort((a, b) => + b.label.localeCompare(a.label) + ); + } + verifyAlertOrder(expectedAlerts); + } + ); + }); + + // Validate the sorting functionality for service Type + cy.get('[data-qa="associated-alerts-table"]').within(() => { + // Click on the 'Service' header to sort + ui.heading.findByText('service_type_label').click(); + + // Get the sort order and verify data matches + const serviceHeading = ui.heading.findByText('service_type_label'); + serviceHeading.should('have.attr', 'aria-sort').then((sortOrder) => { + let expectedAlerts; + if (sortOrder === 'ascending') { + expectedAlerts = [...mockAlerts].sort((a, b) => + cloudPulseServiceMap[a.service_type].localeCompare( + cloudPulseServiceMap[b.service_type] + ) + ); + } else { + expectedAlerts = [...mockAlerts].sort((a, b) => + cloudPulseServiceMap[b.service_type].localeCompare( + cloudPulseServiceMap[a.service_type] + ) + ); + } + verifyAlertOrder(expectedAlerts); + }); + + // Click again to toggle sort order + ui.heading.findByText('service_type_label').click(); + + // Get the new sort order and verify data matches + const serviceHeadingAfterToggle = + ui.heading.findByText('service_type_label'); + serviceHeadingAfterToggle + .should('have.attr', 'aria-sort') + .then((sortOrder) => { + let expectedAlerts; + if (sortOrder === 'ascending') { + expectedAlerts = [...mockAlerts].sort((a, b) => + cloudPulseServiceMap[a.service_type].localeCompare( + cloudPulseServiceMap[b.service_type] + ) + ); + } else { + expectedAlerts = [...mockAlerts].sort((a, b) => + cloudPulseServiceMap[b.service_type].localeCompare( + cloudPulseServiceMap[a.service_type] + ) + ); + } + verifyAlertOrder(expectedAlerts); + }); + }); + }); + }); + + it('should verify the pagination functionality in Associated Alerts table', () => { + // Add additional alerts for pagination testing without mutating shared data + const paginationAlerts = [ + ...mockAlerts, + ...notificationChannelAlertsFactory.buildList(36, { + service_type: 'linode', + }), + ]; + mockGetAlertsForChannelId(id, paginationAlerts).as('getAlertsForChannelId'); + // Navigate directly to the notification channel detail page + cy.visitWithLogin(`/alerts/notification-channels/detail/${id}`); + cy.wait('@getAlertNotificationChannelById'); + cy.wait('@getAlertsForChannelId'); + cy.wait('@getCloudPulseServices'); + cy.get('[data-qa-section="Associated Alerts"]').within(() => { + // Verify the initial state of the page size + ui.pagination.findPageSizeSelect().click(); + + // Verify the page size options are visible + cy.get('[data-qa-pagination-page-size-option="25"]') + .should('exist') + .click(); + + const pages = [1, 2]; + + // Confirm that pagination controls list exactly 2 pages. + ui.pagination.findControls().should('be.visible'); + pages.forEach((page: number) => + ui.pagination.findControls().contains(`${page}`).should('be.visible') + ); + ui.pagination.findControls().contains('3').should('not.exist'); + + // Validate pagination from length of paginationAlerts (ex : 26 total: page 1 has 25, page 2 has 1) + pages.forEach((page: number) => { + const pageSize = 25; + const startIndex = pageSize * (page - 1); + const endIndex = Math.min(pageSize * page, paginationAlerts.length); + const alertSubset = paginationAlerts.slice(startIndex, endIndex); + const expectedRowCount = alertSubset.length + 1; // +1 for header row + + ui.pagination + .findControls() + .contains(`${page}`) + .should('be.visible') + .click(); + + // Verify the correct number of rows (alerts + header) + cy.get('[data-qa="associated-alerts-table"]') + .find('tr') + .should('have.length', expectedRowCount); + }); + // Change pagination page size to 100 + ui.pagination.findPageSizeSelect().click(); + + cy.get('[data-qa-pagination-page-size-option="100"]') + .should('exist') + .click(); + }); + }); + + it('should display appropriate message when associated alerts call fails with 500', () => { + // Mock the alerts fetch to return an error + mockGetAlertsForChannelIdError(notificationChannelDetails[0].id).as( + 'getAlertsForChannelIdError500' + ); + // Navigate directly to the notification channel detail page + cy.visitWithLogin(`/alerts/notification-channels/detail/${id}`); + cy.wait('@getAlertNotificationChannelById'); + cy.wait('@getAlertsForChannelIdError500'); + // Verify that the URL is correct + cy.url().should('include', `/alerts/notification-channels/detail/${id}`); + // Verify that the appropriate message is displayed + cy.get('[data-qa-section="Associated Alerts"]').within(() => { + cy.findByText('Error in fetching the alerts.').should('be.visible'); + }); + }); + + it('should display appropriate message when no alerts are associated with the channel', () => { + // Mock empty alerts response + mockGetAlertsForChannelId(id, []).as('getAlertsForChannelIdEmpty'); + // Navigate directly to the notification channel detail page + cy.visitWithLogin(`/alerts/notification-channels/detail/${id}`); + cy.wait('@getAlertNotificationChannelById'); + cy.wait('@getAlertsForChannelIdEmpty'); + // Verify that the URL is correct + cy.url().should('include', `/alerts/notification-channels/detail/${id}`); + // Verify that the appropriate message is displayed + cy.get('[data-qa-section="Associated Alerts"]').within(() => { + cy.findByText( + 'No alerts are associated with this notification channel.Add or assign alerts to start receiving notifications through this channel.' + ).should('be.visible'); + }); + }); + + it('should display error message when API returns an error during fetching notification channel details', () => { + // Mock the channel fetch to return an error + mockGetAlertChannelByIdError(id).as('getAlertNotificationChannelByIdError'); + // Navigate directly to the notification channel detail page + cy.visitWithLogin(`/alerts/notification-channels/detail/${id}`); + cy.wait('@getAlertNotificationChannelByIdError'); + // Verify that the URL is correct + cy.url().should('include', `/alerts/notification-channels/detail/${id}`); + // Verify that the appropriate error message is displayed + cy.findByText( + 'An error occurred while loading the notification channel. Please try again later.' + ).should('be.visible'); + }); + + it('should verify clicking on the alert name navigates to the alert detail page', () => { + // Navigate directly to the notification channel detail page + cy.visitWithLogin(`/alerts/notification-channels/detail/${id}`); + cy.wait('@getAlertNotificationChannelById'); + cy.wait('@getAlertsForChannelId'); + cy.wait('@getCloudPulseServices'); + // Get the first visible alert's ID from the table, then click it + cy.get('[data-qa-alert-cell]') + .first() + .invoke('attr', 'data-qa-alert-cell') + .then((cellAttr) => { + // Extract the alert ID from the data-qa-alert-cell attribute + const alertId = parseInt(cellAttr || '0', 10); + + // Find the corresponding alert from mockAlerts + const clickedAlert = mockAlerts.find((alert) => alert.id === alertId); + const serviceType = clickedAlert?.service_type || 'dbaas'; // Default to 'dbaas' if undefined + + const alertDetails = alertFactory.build({ + service_type: serviceType, + status: 'failed', + type: 'user', + id: alertId, + }); + + mockGetAlertDefinitions(serviceType, alertId, alertDetails).as( + 'getAlertDefinitions' + ); + + // Click the alert link + cy.get('[data-qa-alert-link="true"]').first().click(); + + // Verify that the URL navigates to the correct alert detail page + cy.wait('@getAlertDefinitions'); + cy.url().should( + 'include', + `/alerts/definitions/detail/${serviceType}/${alertId}` + ); + }); + }); +}); diff --git a/packages/manager/cypress/e2e/core/cloudpulse/alerting-notification-channel-permission-tests.spec.ts b/packages/manager/cypress/e2e/core/cloudpulse/alerting-notification-channel-permission-tests.spec.ts index ad08eabc340..e90e7524412 100644 --- a/packages/manager/cypress/e2e/core/cloudpulse/alerting-notification-channel-permission-tests.spec.ts +++ b/packages/manager/cypress/e2e/core/cloudpulse/alerting-notification-channel-permission-tests.spec.ts @@ -37,7 +37,10 @@ describe('Notification Channel Listing Page — Access Control', () => { mockAppendFeatureFlags(flags); cy.visitWithLogin('/linodes'); - ui.nav.findItemByTitle('Alerts').should('be.visible').click(); + ui.nav.findItemByTitle('Alerts').as('alertsNav'); + cy.get('@alertsNav').scrollIntoView(); + cy.get('@alertsNav').should('be.visible').click(); + ui.tabList .findTabByTitle('Notification Channels') .should('be.visible') @@ -62,7 +65,9 @@ describe('Notification Channel Listing Page — Access Control', () => { mockAppendFeatureFlags(flags); cy.visitWithLogin('/linodes'); - ui.nav.findItemByTitle('Alerts').should('be.visible').click(); + ui.nav.findItemByTitle('Alerts').as('alertsNav'); + cy.get('@alertsNav').scrollIntoView(); + cy.get('@alertsNav').should('be.visible').click(); // Tab should not render at all ui.tabList.findTabByTitle('Notification Channels').should('not.exist'); diff --git a/packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts b/packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts index 1c0a8b6cb9f..aaed233fc2e 100644 --- a/packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts +++ b/packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts @@ -57,7 +57,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { cy.get('@serviceInput').click(); cy.get('[data-qa-id="linode"]') - .should('have.text', 'Linode') + .should('have.text', 'Linodes') .parent() .as('linodeBetaServiceOption'); @@ -66,8 +66,8 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { .should('be.visible') .and('have.text', 'beta'); - cy.get('@serviceInput').should('be.visible').type('Linode'); - ui.autocompletePopper.findByTitle('Linode').should('be.visible').click(); + cy.get('@serviceInput').should('be.visible').type('Linodes'); + ui.autocompletePopper.findByTitle('Linodes').should('be.visible').click(); }); it('should exclude Linode beta in Service dropdown when alerts.beta is false', () => { // Mock feature flags with alerts beta disabled @@ -92,7 +92,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { cy.get('[data-qa-autocomplete-popper]') .should('be.visible') .and('have.text', NO_OPTIONS_TEXT) - .and('not.contain.text', 'Linode beta'); + .and('not.contain.text', 'Linodes beta'); }); it('should show no available services in the Service dropdown when Linode alerts are disabled but beta is true', () => { @@ -115,7 +115,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { cy.get('[data-qa-autocomplete-popper]') .should('be.visible') .and('have.text', NO_OPTIONS_TEXT) - .and('not.contain.text', 'Linode beta'); + .and('not.contain.text', 'Linodes beta'); }); it('should show no options and exclude Linode beta in Service dropdown when alerts are disabled but beta is true', () => { @@ -138,7 +138,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { cy.get('[data-qa-autocomplete-popper]') .should('be.visible') .and('contain.text', 'You have no options to choose from') - .and('not.contain.text', 'Linode beta'); + .and('not.contain.text', 'Linodes beta'); }); it('should show Linode without beta tag in Service dropdown when alerts are enabled but not in beta', () => { @@ -156,7 +156,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { // ---------- Assert ---------- cy.get('[data-qa-id="linode"]') - .should('have.text', 'Linode') + .should('have.text', 'Linodes') .parent() .as('linodeBetaServiceOption'); diff --git a/packages/manager/cypress/e2e/core/cloudpulse/metrics-service-ld-flags.spec.ts b/packages/manager/cypress/e2e/core/cloudpulse/metrics-service-ld-flags.spec.ts index 031178cd3e4..f8763928c6b 100644 --- a/packages/manager/cypress/e2e/core/cloudpulse/metrics-service-ld-flags.spec.ts +++ b/packages/manager/cypress/e2e/core/cloudpulse/metrics-service-ld-flags.spec.ts @@ -88,7 +88,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { mockGetCloudPulseServices([serviceType]).as('fetchServices'); mockGetUserPreferences({}); }); - it('should display "Linode" with a beta tag in the Service dropdown on the Metrics page when metrics.beta is enabled and the service is enabled', () => { + it('should display "Linodes" with a beta tag in the Service dropdown on the Metrics page when metrics.beta is enabled and the service is enabled', () => { mockAppendFeatureFlags(flagsFactory.build()); mockGetCloudPulseDashboard(id, dashboard); mockGetCloudPulseDashboards(serviceType, [dashboard]).as('fetchDashboard'); @@ -102,7 +102,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { cy.get('@dashboardInput').click(); cy.get('[data-qa-id="linode"]') // Selects the Linode label - .should('have.text', 'Linode') + .should('have.text', 'Linodes') .parent() // Moves up to the
  • containing both label and chip .as('linodeBetaServiceOption'); // Alias for reuse @@ -122,7 +122,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { .click(); }); - it('should display "Linode" without a beta tag in the Service dropdown on the Metrics page when metrics.beta is false and the service is enabled', () => { + it('should display "Linodes" without a beta tag in the Service dropdown on the Metrics page when metrics.beta is false and the service is enabled', () => { const mockflags = flagsFactory.build({ aclpServices: { linode: { @@ -145,7 +145,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { // Verify "Linode" is present without a beta chip ui.autocompletePopper - .findByTitle('Linode') + .findByTitle('Linodes') .should('be.visible') .within(() => { cy.get('[data-testid="betaChip"]').should('not.exist'); @@ -160,7 +160,7 @@ describe('Linode ACLP Metrics and Alerts Flag Behavior', () => { .click(); }); - it('should not display "Linode" with a beta tag in the Service dropdown on the Metrics page when metrics.beta is true and enabled is false', () => { + it('should not display "Linodes" with a beta tag in the Service dropdown on the Metrics page when metrics.beta is true and enabled is false', () => { // Mock the feature flags to disable metrics for Linode const mockflags = flagsFactory.build({ diff --git a/packages/manager/cypress/support/constants/cloudpulse.ts b/packages/manager/cypress/support/constants/cloudpulse.ts index e7c02ccc832..45ea912363e 100644 --- a/packages/manager/cypress/support/constants/cloudpulse.ts +++ b/packages/manager/cypress/support/constants/cloudpulse.ts @@ -4,10 +4,14 @@ */ export const cloudPulseServiceMap: Record = { + blockstorage: 'Volumes', dbaas: 'Databases', - linode: 'Linode', - nodebalancer: 'NodeBalancer', - firewall: 'Firewall', + firewall: 'Firewalls', + linode: 'Linodes', + lke: 'Kubernetes', + nodebalancer: 'NodeBalancers', + objectstorage: 'Object Storage', + netloadbalancer: 'Netloadbalancer', }; /** * Descriptions used in the Create/Edit Alert form to guide users diff --git a/packages/manager/cypress/support/intercepts/cloudpulse.ts b/packages/manager/cypress/support/intercepts/cloudpulse.ts index fd4c7a8165e..b307d22a947 100644 --- a/packages/manager/cypress/support/intercepts/cloudpulse.ts +++ b/packages/manager/cypress/support/intercepts/cloudpulse.ts @@ -17,6 +17,7 @@ import type { Dashboard, MetricDefinition, NotificationChannel, + NotificationChannelAlerts, Service, } from '@linode/api-v4'; @@ -709,3 +710,71 @@ export const mockCreateAlertChannelError = ( makeErrorResponse(errorPayload, statusCode) ); }; + +/** + * Mocks get call for a specific alert channel by ID. + * + * @param {number} id - The ID of the alert channel to retrieve. + * @param {NotificationChannel} channel - The notification channel object to return in the response. + * @returns {Cypress.Chainable} - A Cypress chainable used to continue the test flow. + */ +export const mockGetAlertChannelById = ( + id: number, + channel: NotificationChannel +): Cypress.Chainable => { + return cy.intercept( + 'GET', + apiMatcher(`/monitor/alert-channels/${id}`), + makeResponse(channel) + ); +}; + +/** + * Mocks an error response for getting a specific alert channel by ID. + * + * @param {number} id - The ID of the alert channel for which to mock an error response. + * @returns {Cypress.Chainable} - A Cypress chainable used to continue the test flow. + * + */ +export const mockGetAlertChannelByIdError = ( + id: number +): Cypress.Chainable => { + return cy.intercept( + 'GET', + apiMatcher(`/monitor/alert-channels/${id}`), + makeErrorResponse('Error fetching alerts for channel', 500) + ); +}; + +/** + * Intercepts GET request to retrieve alerts associated with a notification channel + * + * @param channelId - The ID of the notification channel + * @param alerts - Mock alert data to return + * @returns Cypress chainable + */ +export const mockGetAlertsForChannelId = ( + channelId: number, + alerts: NotificationChannelAlerts[] +) => { + return cy.intercept( + 'GET', + apiMatcher(`/monitor/alert-channels/${channelId}/alerts*`), + paginateResponse(alerts) + ); +}; + +/** + * Intercepts GET request for alerts associated with a notification channel and + * mocks an error response instead of returning alert data. + * + * @param channelId - The ID of the notification channel for which to mock an error. + * @returns Cypress chainable that yields an error response for the alerts request. + */ +export const mockGetAlertsForChannelIdError = (channelId: number) => { + return cy.intercept( + 'GET', + apiMatcher(`/monitor/alert-channels/${channelId}/alerts*`), + makeErrorResponse('Error in fetching the alerts.', 500) + ); +}; diff --git a/packages/manager/src/features/CloudPulse/Alerts/NotificationChannels/NotificationChannelDetail/NotificationChannelDetail.tsx b/packages/manager/src/features/CloudPulse/Alerts/NotificationChannels/NotificationChannelDetail/NotificationChannelDetail.tsx index 96488bd684a..bcd26536652 100644 --- a/packages/manager/src/features/CloudPulse/Alerts/NotificationChannels/NotificationChannelDetail/NotificationChannelDetail.tsx +++ b/packages/manager/src/features/CloudPulse/Alerts/NotificationChannels/NotificationChannelDetail/NotificationChannelDetail.tsx @@ -43,6 +43,9 @@ export const NotificationChannelDetail = () => { return ( <> @@ -57,6 +60,9 @@ export const NotificationChannelDetail = () => { return ( <> @@ -71,6 +77,9 @@ export const NotificationChannelDetail = () => { return ( <> @@ -89,6 +98,9 @@ export const NotificationChannelDetail = () => {