Issue/321 (#322)

* add test

* bad fix

* Excluded linq2db methods from evaluation.

* use modern blob types in tests

---------

Co-authored-by: Svyatoslav Danyliv <[email protected]>

Author: MaceWindu

Source/LinqToDB.EntityFrameworkCore/LinqToDBForEFToolsImplDefault.cs

@@ -916,7 +916,7 @@ TransformInfo LocalTransform(Expression e)
 							break;
 						}
 
-						if (typeof(IQueryable<>).IsSameOrParentOf(methodCall.Type))
+						if (typeof(IQueryable<>).IsSameOrParentOf(methodCall.Type) && methodCall.Type.Assembly != typeof(LinqExtensions).Assembly)
 						{
 							if (null == methodCall.Find(nonEvaluatableParameters,
 								    (c, t) => t.NodeType == ExpressionType.Parameter && c.Contains(t)))

Tests/LinqToDB.EntityFrameworkCore.SqlServer.Tests/IssueTests.cs

@@ -1,6 +1,7 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using FluentAssertions;
+using LinqToDB.DataProvider.SqlServer;
 using LinqToDB.EntityFrameworkCore.BaseTests;
 using LinqToDB.EntityFrameworkCore.SqlServer.Tests.Models.IssueModel;
 using Microsoft.EntityFrameworkCore;
@@ -81,5 +82,12 @@ from p in ctx.Patents.Include(p => p.Assessment)
 			Assert.That(db.LastQuery, Does.Not.Contain("INNER"));
 		}
 
+		[Test]
+		public void Issue321Test()
+		{
+			using var ctx = CreateContext();
+
+			var _ = ctx.Patents.AsSqlServer().ToLinqToDB().ToArray();
+		}
 	}
 }

Tests/LinqToDB.EntityFrameworkCore.SqlServer.Tests/Models/Northwind.Mapping/CategoriesMap.cs

@@ -22,9 +22,9 @@ public override void Configure(EntityTypeBuilder<Category> builder)
 				.IsRequired()
 				.HasMaxLength(15);
 
-			builder.Property(e => e.Description).HasColumnType("ntext");
+			builder.Property(e => e.Description).HasColumnType("nvarchar(max)");
 
-			builder.Property(e => e.Picture).HasColumnType("image");
+			builder.Property(e => e.Picture).HasColumnType("varbinary(max)");
 		}
 	}
 }

Tests/LinqToDB.EntityFrameworkCore.SqlServer.Tests/Models/Northwind.Mapping/CustomerDemographicsMap.cs

@@ -18,7 +18,7 @@ public override void Configure(EntityTypeBuilder<CustomerDemographics> builder)
 				.HasMaxLength(10)
 				.ValueGeneratedNever();
 
-			builder.Property(e => e.CustomerDesc).HasColumnType("ntext");
+			builder.Property(e => e.CustomerDesc).HasColumnType("nvarchar(max)");
 		}
 	}
 }

Tests/LinqToDB.EntityFrameworkCore.SqlServer.Tests/Models/Northwind.Mapping/EmployeesMap.cs

@@ -43,9 +43,9 @@ public override void Configure(EntityTypeBuilder<Employee> builder)
 				.IsRequired()
 				.HasMaxLength(20);
 
-			builder.Property(e => e.Notes).HasColumnType("ntext");
+			builder.Property(e => e.Notes).HasColumnType("nvarchar(max)");
 
-			builder.Property(e => e.Photo).HasColumnType("image");
+			builder.Property(e => e.Photo).HasColumnType("varbinary(max)");
 
 			builder.Property(e => e.PhotoPath).HasMaxLength(255);
 

Tests/LinqToDB.EntityFrameworkCore.SqlServer.Tests/Models/Northwind.Mapping/SuppliersMap.cs

@@ -37,7 +37,7 @@ public override void Configure(EntityTypeBuilder<Supplier> builder)
 
 			builder.Property(e => e.Fax).HasMaxLength(24);
 
-			builder.Property(e => e.HomePage).HasColumnType("ntext");
+			builder.Property(e => e.HomePage).HasColumnType("nvarchar(max)");
 
 			builder.Property(e => e.Phone).HasMaxLength(24);