Fix for #179. Ambiguous exception when working with properties.

Author: sdanyliv

Source/LinqToDB.EntityFrameworkCore/EFCoreMetadataReader.cs

@@ -495,12 +495,23 @@ public override int GetHashCode()
 			return found;
 		}
 
+		private static PropertyInfo GetPropertyInfoForType(Type type, PropertyInfo propInfo)
+		{
+			if (propInfo.DeclaringType == type)
+				return propInfo;
+
+			var found = type.GetProperties()
+				.FirstOrDefault(x => x.Module == propInfo.Module && x.MetadataToken == propInfo.MetadataToken);
+
+			return found ?? propInfo;
+		}
+
 		private Sql.ExpressionAttribute? GetDbFunctionFromProperty(Type type, PropertyInfo propInfo)
 		{
 			if (_dependencies == null || _model == null)
 				return null;
 
-			propInfo = (PropertyInfo?) type.GetMemberEx(propInfo) ?? propInfo;
+			propInfo = GetPropertyInfoForType(type, propInfo);
 
 			var found = _calculatedExtensions.GetOrAdd(propInfo, mi =>
 			{

Tests/LinqToDB.EntityFrameworkCore.BaseTests/ForMappingTestsBase.cs

@@ -108,5 +108,14 @@ public virtual async Task TestUIntTable()
 			var item = await context.UIntTable.FirstOrDefaultAsyncLinqToDB(e => e.Field64 == field64);
 		}
 
+		[Test]
+		public virtual void TestAmbiguousProperties()
+		{
+			using var context = CreateContext();
+
+			FluentActions.Awaiting(() => context.WithDuplicateProperties.Where(x => x.Value == 1)
+				.ToArrayAsyncLinqToDB()).Should().NotThrow();
+		}
+
 	}
 }

Tests/LinqToDB.EntityFrameworkCore.BaseTests/Models/ForMapping/ForMappingContextBase.cs

@@ -12,5 +12,7 @@ protected ForMappingContextBase(DbContextOptions options) : base(options)
 		public DbSet<NoIdentity> NoIdentity { get; set; } = null!;
 		public DbSet<UIntTable> UIntTable { get; set; } = null!;
 		public DbSet<StringTypes> StringTypes { get; set; } = null!;
+
+		public DbSet<WithDuplicateProperties> WithDuplicateProperties { get; set; } = null!;
 	}
 }

Tests/LinqToDB.EntityFrameworkCore.BaseTests/Models/ForMapping/WithDuplicateProperties.cs

@@ -0,0 +1,18 @@
+using System.ComponentModel.DataAnnotations;
+
+namespace LinqToDB.EntityFrameworkCore.BaseTests.Models.ForMapping
+{
+
+	public class WithDuplicatePropertiesBase
+	{
+		[Key]
+		public int Id { get; set; }
+
+		public virtual string? Value { get; set; }
+	}
+
+	public class WithDuplicateProperties : WithDuplicatePropertiesBase
+	{
+		public new int? Value { get; set; }
+	}
+}