Invalid magic number on remote reply leaves connection open

In recv_msg_tcp, encountering a bad magic number only logs an error and
returns, leaving the socket open even though the comment notes it should
be closed and restarted.

When recv_msg_tcp encounters an invalid magic number it now shuts down
the existing connection with stop_transport(), attempts to re-establish
it immediately, and returns a failure if reconnection fails.

Author: stevegrubb

audisp/plugins/remote/audisp-remote.c

@@ -1454,10 +1454,12 @@ static int recv_msg_tcp (unsigned char *header, char *msg, uint32_t *mlen)
 	}
 
 	if (! AUDIT_RMW_IS_MAGIC (header, AUDIT_RMW_HEADER_SIZE)) {
-		/* FIXME: the right thing to do here is close the socket
-		 *  and start a new one.  */
+		/* close the socket and start a new one.  */
 		sync_error_handler ("bad magic number");
+		stop_transport();
+		init_transport();
 		return -1;
+
 	}
 
 	AUDIT_RMW_UNPACK_HEADER (header, hver, mver, type, rlen, seq);