Add warning for unused results for plist_append

Author: stevegrubb

audisp/audispd-llist.h

@@ -53,7 +53,7 @@ unsigned int plist_count_active(const conf_llist *l) __nonnull ((1));
 void plist_last(conf_llist *l) __nonnull ((1));
 lnode *plist_next(conf_llist *l) __nonnull ((1));
 static inline lnode *plist_get_cur(conf_llist *l) __nonnull ((1));
-int plist_append(conf_llist *l, plugin_conf_t *p) __nonnull ((1));
+int plist_append(conf_llist *l, plugin_conf_t *p) __wur __nonnull ((1));
 void plist_clear(conf_llist* l) __nonnull ((1));
 void plist_mark_all_unchecked(conf_llist* l) __nonnull ((1));
 lnode *plist_find_unchecked(conf_llist* l) __nonnull ((1));

audisp/audispd.c

@@ -131,16 +131,23 @@ static void load_plugin_conf(conf_llist *plugin)
 				reason = "file without .conf suffix";
 
 			if (reason) {
-				audit_msg(LOG_DEBUG, "Skipping %s plugin due to %s", e->d_name, reason);
+				audit_msg(LOG_DEBUG,
+					  "Skipping %s plugin due to %s",
+					  e->d_name, reason);
 				continue;
 			}
 
 			clear_pconfig(&config);
 			if (load_pconfig(&config, dfd, e->d_name) == 0) {
 				/* Push onto config list only if active */
-				if (config.active == A_YES)
-					plist_append(plugin, &config);
-				else
+				if (config.active == A_YES) {
+					if (plist_append(plugin, &config) != 0) {
+						audit_msg(LOG_ERR,
+					    "Failed adding %s plugin to list",
+								e->d_name);
+						free_pconfig(&config);
+					}
+				} else
 					free_pconfig(&config);
 			} else
 				audit_msg(LOG_ERR,
@@ -257,10 +264,17 @@ static int reconfigure(void)
 			if (tpconf->p->active == A_YES) {
 				tpconf->p->checked = 1;
 				plist_last(&plugin_conf);
-				plist_append(&plugin_conf, tpconf->p);
-				free(tpconf->p);
+				if (plist_append(&plugin_conf,
+						tpconf->p) != 0) {
+					audit_msg(LOG_ERR,
+						"Failed adding %s plugin to list",
+						tpconf->p->name);
+					free(tpconf->p);
+				} else {
+					free(tpconf->p);
+					start_one_plugin(plist_get_cur(&plugin_conf));
+				}
 				tpconf->p = NULL;
-				start_one_plugin(plist_get_cur(&plugin_conf));
 			}
 		} else {
 			if (opconf->p->active == tpconf->p->active) {

audisp/test/test-audispd-llist.c

@@ -252,9 +252,12 @@ test_plugin_hup_signal_handling(void)
 	if (!old_config1 || !old_config2 || !old_config3)
 		TEST_FAIL("failed to create old plugin configs");
 
-	plist_append(&old_plugin_list, old_config1);
-	plist_append(&old_plugin_list, old_config2);
-	plist_append(&old_plugin_list, old_config3);
+	if (plist_append(&old_plugin_list, old_config1) != 0)
+		TEST_FAIL("failed to append old_config1");
+	if (plist_append(&old_plugin_list, old_config2) != 0)
+		TEST_FAIL("failed to append old_config2");
+	if (plist_append(&old_plugin_list, old_config3) != 0)
+		TEST_FAIL("failed to append old_config3");
 
 	// Create new configuration (remove audit-af_unix, add audit-custom-plugin, keep others)
 	new_config1 = create_test_plugin("audit-remote", A_YES, "/usr/sbin/audit-remote");
@@ -264,9 +267,12 @@ test_plugin_hup_signal_handling(void)
 	if (!new_config1 || !new_config2 || !new_config4)
 		TEST_FAIL("failed to create new plugin configs");
 
-	plist_append(&new_plugin_list, new_config1);
-	plist_append(&new_plugin_list, new_config2);
-	plist_append(&new_plugin_list, new_config4);
+	if (plist_append(&new_plugin_list, new_config1) != 0)
+		TEST_FAIL("failed to append new_config1");
+	if (plist_append(&new_plugin_list, new_config2) != 0)
+		TEST_FAIL("failed to append new_config2");
+	if (plist_append(&new_plugin_list, new_config4) != 0)
+		TEST_FAIL("failed to append new_config4");
 
 	// Simulate HUP signal handling: mark all old plugins as unchecked
 	plist_mark_all_unchecked(&old_plugin_list);
@@ -283,17 +289,21 @@ test_plugin_hup_signal_handling(void)
 			// Plugin exists in old list, mark as checked
 			old_node->p->checked = 1;
 
-			// Verify configuration update (audit-syslog changed from A_YES to A_NO)
+			// Verify configuration update (audit-syslog changed
+			// from A_YES to A_NO)
 			if (strcmp(new_node->p->name, "audit-syslog") == 0) {
-				if (old_node->p->active == A_YES && new_node->p->active == A_NO) {
-					// This simulates updating the configuration
+				if (old_node->p->active ==
+				    A_YES && new_node->p->active == A_NO) {
+					// This simulates updating the
+					// configuration
 					old_node->p->active = A_NO;
 				}
 			}
 		} else {
 			// New plugin, add to old list
 			plist_last(&old_plugin_list);
-			plist_append(&old_plugin_list, new_node->p);
+			if (plist_append(&old_plugin_list, new_node->p) != 0)
+			   TEST_FAIL("failed to append new plugin to old list");
 		}
 
 		new_node = plist_next(&new_plugin_list);
@@ -374,7 +384,8 @@ test_plugin_iteration_and_startup(void)
 	for (i = 0; i < 5; i++) {
 		if (!configs[i])
 			TEST_FAIL("failed to create plugin config");
-		plist_append(&plugin_list, configs[i]);
+		if (plist_append(&plugin_list, configs[i]) != 0)
+			TEST_FAIL("failed to append plugin config");
 	}
 
 	// Simulate plugin startup iteration (like start_plugins in audispd.c)
@@ -413,7 +424,8 @@ test_plugin_iteration_and_startup(void)
 		TEST_FAIL("failed to create new plugin config");
 
 	plist_last(&plugin_list);
-	plist_append(&plugin_list, config_new);
+	if (plist_append(&plugin_list, config_new) != 0)
+		TEST_FAIL("failed to append new plugin");
 
 	if (plist_count(&plugin_list) != 6)
 		TEST_FAIL("should have 6 plugins after append");