Skip to content

Commit c8b88fd

Browse files
committed
Readability issue in compare_values()
The extended timestamp branch accesses timestamp members instead of timestamp_ex. The union layout makes this work, but using the correct member would clarify intent
1 parent 1a483c7 commit c8b88fd

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

auparse/expression.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1079,13 +1079,13 @@ compare_values(const auparse_state_t *au, const rnode *record,
10791079
break;
10801080

10811081
case EF_TIMESTAMP_EX:
1082-
if (au->le->e.sec < expr->v.p.value.timestamp.sec)
1082+
if (au->le->e.sec < expr->v.p.value.timestamp_ex.sec)
10831083
res = -1;
1084-
else if (au->le->e.sec > expr->v.p.value.timestamp.sec)
1084+
else if (au->le->e.sec > expr->v.p.value.timestamp_ex.sec)
10851085
res = 1;
1086-
else if (au->le->e.milli < expr->v.p.value.timestamp.milli)
1086+
else if (au->le->e.milli < expr->v.p.value.timestamp_ex.milli)
10871087
res = -1;
1088-
else if (au->le->e.milli > expr->v.p.value.timestamp.milli)
1088+
else if (au->le->e.milli > expr->v.p.value.timestamp_ex.milli)
10891089
res = 1;
10901090
else if (au->le->e.serial < expr->v.p.value.timestamp_ex.serial)
10911091
res = -1;

0 commit comments

Comments
 (0)