Skip to content

Commit 153c9cb

Browse files
committed
web: prettier: explicitly specify version to use
Our CI jobs started failing due to the release of prettier 3.0, which changed the formatting rules. Specifying a version in `package.json` does not seem to do the trick, so just specify the version to use when calling prettier via npx. Signed-off-by: Leonard Göhrs <[email protected]>
1 parent f621974 commit 153c9cb

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.github/workflows/tacd-webui.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
- uses: actions/setup-node@v3
3030
with:
3131
node-version: latest
32-
- run: npx prettier --check .
32+
- run: npx prettier@=2.8.8 --check .
3333

3434
license:
3535
name: npx license-checker

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,5 +131,5 @@ guidelines:
131131
- Use `cargo fmt` after every change to the rust codebase
132132
- Use `cargo deny check license` if you have introduced new dependencies to
133133
check if they (or their dependencies) introduce license issues.
134-
- Use `npx prettier --write .` (in the web directory) after every change to the
135-
web codebase.
134+
- Use `npx prettier@=2.8.8 --write .` (in the web directory) after every
135+
change to the web codebase.

web/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
"@types/swagger-ui-react": "^4.11.0",
1818
"ace-builds": "^1.9.6",
1919
"paho-mqtt": "^1.1.0",
20-
"prettier": "^2.7.1",
2120
"react": "^18.2.0",
2221
"react-dom": "^18.2.0",
2322
"react-router-dom": "^6.3.0",

0 commit comments

Comments
 (0)