Skip to content

Conversation

hnez
Copy link
Member

@hnez hnez commented Aug 8, 2025

This feels like something where clippy suggested the exact opposite in the past, but I am not in the mood to argue.

Fixes the following warnings:

 error: hiding a lifetime that's elided elsewhere is confusing
  --> src/ui/buttons.rs:41:29
   |
41 |         pub fn fetch_events(&mut self) -> Result<FetchEventsSynced, ()> {
   |                             ^^^^^^^^^            ----------------- the same lifetime is hidden here
   |                             |
   |                             the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
   = note: `-D mismatched-lifetime-syntaxes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(mismatched_lifetime_syntaxes)]`
help: use `'_` for type paths
   |
41 |         pub fn fetch_events(&mut self) -> Result<FetchEventsSynced<'_>, ()> {
   |                                                                   ++++

This fixes the failed scheduled CI runs.

This feels like something where clippy suggested the exact opposite in the
past, but I am not in the mood to argue.

Fixes the following warnings:

     error: hiding a lifetime that's elided elsewhere is confusing
      --> src/ui/buttons.rs:41:29
       |
    41 |         pub fn fetch_events(&mut self) -> Result<FetchEventsSynced, ()> {
       |                             ^^^^^^^^^            ----------------- the same lifetime is hidden here
       |                             |
       |                             the lifetime is elided here
       |
       = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
       = note: `-D mismatched-lifetime-syntaxes` implied by `-D warnings`
       = help: to override `-D warnings` add `#[allow(mismatched_lifetime_syntaxes)]`
    help: use `'_` for type paths
       |
    41 |         pub fn fetch_events(&mut self) -> Result<FetchEventsSynced<'_>, ()> {
       |                                                                   ++++

Signed-off-by: Leonard Göhrs <[email protected]>
@hnez
Copy link
Member Author

hnez commented Aug 22, 2025

I get weekly mails about the failing tests. And I can not merge here without approval.
Can someone else have a look at this, maybe @SmithChart?

Copy link
Member

@SmithChart SmithChart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. Clippy will probably know what it is doing :-)

@SmithChart SmithChart merged commit 8a0cbd4 into linux-automation:main Aug 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants