Skip to content

Commit 35a4e21

Browse files
committed
block/042: add description and fix shellcheck warnings
Based on the commit message of the commit 57edc10 ("blktests: test direct io offsets"), add description comment to the test case block/042. Also, fix several shellcheck warnings. Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent ed7e482 commit 35a4e21

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

tests/block/042

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#!/bin/bash
22
# SPDX-License-Identifier: GPL-2.0
33
# Copyright 2025 Keith Busch <[email protected]>
4+
#
5+
# Tests various direct IO memory and length alignments against the device's
6+
# queue limits reported from sysfs.
47

58
. tests/block/rc
69

@@ -20,7 +23,9 @@ test_device() {
2023
sys_logical_block_size=$(cat "${TEST_DEV_SYSFS}/queue/logical_block_size")
2124
sys_max_sectors_kb=$(cat "${TEST_DEV_SYSFS}/queue/max_sectors_kb")
2225

23-
if ! src/dio-offsets ${TEST_DEV} $sys_max_segments $sys_max_sectors_kb $sys_dma_alignment $sys_virt_boundary_mask $sys_logical_block_size; then
26+
if ! src/dio-offsets "${TEST_DEV}" "$sys_max_segments" \
27+
"$sys_max_sectors_kb" "$sys_dma_alignment" \
28+
"$sys_virt_boundary_mask" "$sys_logical_block_size"; then
2429
echo "src/dio-offsets failed"
2530
fi
2631

0 commit comments

Comments
 (0)