Skip to content

Commit 69591d9

Browse files
ChaitanayaKulkarnikawasaki
authored andcommitted
nvme: convert tests to use _have_kernel_options
Convert multiple _have_kernel_option calls in nvme tests to use the new _have_kernel_options helper function for more concise code. Modified tests: nvme/039: FAULT_INJECTION, FAULT_INJECTION_DEBUG_FS nvme/041: NVME_AUTH, NVME_TARGET_AUTH nvme/042: NVME_AUTH, NVME_TARGET_AUTH nvme/043: NVME_AUTH, NVME_TARGET_AUTH nvme/044: NVME_AUTH, NVME_TARGET_AUTH nvme/045: NVME_AUTH, NVME_TARGET_AUTH nvme/050: FAIL_IO_TIMEOUT, FAULT_INJECTION_DEBUG_FS nvme/062: NVME_TCP_TLS, NVME_TARGET_TCP_TLS nvme/063: NVME_AUTH, NVME_TCP_TLS, NVME_TARGET_AUTH, NVME_TARGET_TCP_TLS Signed-off-by: Chaitanya Kulkarni <[email protected]> Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent 1f74eb9 commit 69591d9

File tree

9 files changed

+10
-20
lines changed

9 files changed

+10
-20
lines changed

tests/nvme/039

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ QUICK=1
1414

1515
requires() {
1616
_have_program nvme
17-
_have_kernel_option FAULT_INJECTION
18-
_have_kernel_option FAULT_INJECTION_DEBUG_FS
17+
_have_kernel_options FAULT_INJECTION FAULT_INJECTION_DEBUG_FS
1918
}
2019

2120
device_requires() {

tests/nvme/041

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ QUICK=1
1212
requires() {
1313
_nvme_requires
1414
_have_loop
15-
_have_kernel_option NVME_AUTH
16-
_have_kernel_option NVME_TARGET_AUTH
15+
_have_kernel_options NVME_AUTH NVME_TARGET_AUTH
1716
_require_kernel_nvme_fabrics_feature dhchap_ctrl_secret
1817
_require_nvme_trtype_is_fabrics
1918
_require_nvme_cli_auth

tests/nvme/042

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ QUICK=1
1212
requires() {
1313
_nvme_requires
1414
_have_loop
15-
_have_kernel_option NVME_AUTH
16-
_have_kernel_option NVME_TARGET_AUTH
15+
_have_kernel_options NVME_AUTH NVME_TARGET_AUTH
1716
_require_kernel_nvme_fabrics_feature dhchap_ctrl_secret
1817
_require_nvme_trtype_is_fabrics
1918
_require_nvme_cli_auth

tests/nvme/043

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ QUICK=1
1212
requires() {
1313
_nvme_requires
1414
_have_loop
15-
_have_kernel_option NVME_AUTH
16-
_have_kernel_option NVME_TARGET_AUTH
15+
_have_kernel_options NVME_AUTH NVME_TARGET_AUTH
1716
_require_kernel_nvme_fabrics_feature dhchap_ctrl_secret
1817
_require_nvme_trtype_is_fabrics
1918
_require_nvme_cli_auth

tests/nvme/044

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ QUICK=1
1212
requires() {
1313
_nvme_requires
1414
_have_loop
15-
_have_kernel_option NVME_AUTH
16-
_have_kernel_option NVME_TARGET_AUTH
15+
_have_kernel_options NVME_AUTH NVME_TARGET_AUTH
1716
_require_kernel_nvme_fabrics_feature dhchap_ctrl_secret
1817
_require_nvme_trtype_is_fabrics
1918
_require_nvme_cli_auth

tests/nvme/045

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ requires() {
1313
_nvme_requires
1414
_have_fio
1515
_have_loop
16-
_have_kernel_option NVME_AUTH
17-
_have_kernel_option NVME_TARGET_AUTH
16+
_have_kernel_options NVME_AUTH NVME_TARGET_AUTH
1817
_require_kernel_nvme_fabrics_feature dhchap_ctrl_secret
1918
_require_nvme_trtype_is_fabrics
2019
_require_nvme_cli_auth

tests/nvme/050

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ nvme_trtype=pci
1616
requires() {
1717
_have_fio
1818
_nvme_requires
19-
_have_kernel_option FAIL_IO_TIMEOUT
20-
_have_kernel_option FAULT_INJECTION_DEBUG_FS
19+
_have_kernel_options FAIL_IO_TIMEOUT FAULT_INJECTION_DEBUG_FS
2120
}
2221

2322
test_device() {

tests/nvme/062

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ QUICK=1
1212
requires() {
1313
_nvme_requires
1414
_have_loop
15-
_have_kernel_option NVME_TCP_TLS
16-
_have_kernel_option NVME_TARGET_TCP_TLS
15+
_have_kernel_options NVME_TCP_TLS NVME_TARGET_TCP_TLS
1716
_require_kernel_nvme_fabrics_feature tls
1817
_require_nvme_trtype tcp
1918
_require_nvme_cli_tls

tests/nvme/063

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@ QUICK=1
1212
requires() {
1313
_nvme_requires
1414
_have_loop
15-
_have_kernel_option NVME_AUTH
16-
_have_kernel_option NVME_TCP_TLS
17-
_have_kernel_option NVME_TARGET_AUTH
18-
_have_kernel_option NVME_TARGET_TCP_TLS
15+
_have_kernel_options NVME_AUTH NVME_TCP_TLS NVME_TARGET_AUTH \
16+
NVME_TARGET_TCP_TLS
1917
_require_kernel_nvme_fabrics_feature dhchap_ctrl_secret
2018
_require_kernel_nvme_fabrics_feature concat
2119
_require_nvme_trtype tcp

0 commit comments

Comments
 (0)