Skip to content

ublk: introduce UBLK_CMD_TRY_STOP_DEV #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
blktests-ci wants to merge 4 commits into
base: linus-master_base
Choose a base branch
from
Open

ublk: introduce UBLK_CMD_TRY_STOP_DEV #448

blktests-ci wants to merge 4 commits into from

Conversation

@blktests-ci
Copy link

@blktests-ci blktests-ci bot commented Jan 4, 2026

Pull request for series with
subject: ublk: introduce UBLK_CMD_TRY_STOP_DEV
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1037344

@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 4, 2026

Upstream branch: d26143b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1037344
version: 1

@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 4a5ddea to 0ab4e8c Compare January 4, 2026 08:37
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 4, 2026

Upstream branch: aacb0a6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1037344
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from 3aa004a to c2f932f Compare January 4, 2026 08:42
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 4, 2026

Upstream branch: aacb0a6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1038171
version: 2

@blktests-ci blktests-ci bot added V2 and removed V1 labels Jan 4, 2026
@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from c2f932f to a63aad3 Compare January 4, 2026 08:53
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 6, 2026

Upstream branch: aacb0a6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1038171
version: 2

@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from a63aad3 to 8722d70 Compare January 6, 2026 14:21
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 6, 2026

Upstream branch: aacb0a6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1039116
version: 3

@blktests-ci blktests-ci bot added V3 and removed V2 V2-ci-pass labels Jan 6, 2026
@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from 8722d70 to f7a28b3 Compare January 6, 2026 19:04
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 6, 2026

Upstream branch: aacb0a6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1039134
version: 4

@blktests-ci blktests-ci bot added V4 and removed V3 V3-ci-pass labels Jan 6, 2026
@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from f7a28b3 to 674694c Compare January 6, 2026 20:39
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 7, 2026

Upstream branch: aacb0a6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1039134
version: 4

@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from 674694c to cd119a2 Compare January 7, 2026 13:24
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 0ab4e8c to a2a6d78 Compare January 8, 2026 00:54
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 8, 2026

Upstream branch: aacb0a6
series: https://patchwork.kernel.org/project/linux-block/list/?series=1039134
version: 4

@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from cd119a2 to 5875293 Compare January 8, 2026 00:56
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from a2a6d78 to f962a4d Compare January 9, 2026 04:56
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 9, 2026

Upstream branch: 623fb99
series: https://patchwork.kernel.org/project/linux-block/list/?series=1039134
version: 4

@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from 5875293 to d701cb4 Compare January 9, 2026 04:56
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 11, 2026

Upstream branch: 623fb99
series: https://patchwork.kernel.org/project/linux-block/list/?series=1040827
version: 5

@blktests-ci blktests-ci bot added V5 and removed V4 V4-ci-fail labels Jan 11, 2026
@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from d701cb4 to 408a6a3 Compare January 11, 2026 09:48
yoavcoh and others added 3 commits January 12, 2026 22:44
@yoavcoh @kawasaki
ublk: make ublk_ctrl_stop_dev return void
aae2b88 
This function always returns 0, so there is no need to return a value.

Signed-off-by: Yoav Cohen <[email protected]>
Reviewed-by: Ming Lei <[email protected]>
@yoavcoh @kawasaki
ublk: add UBLK_CMD_TRY_STOP_DEV command
0b53c8b 
Add a best-effort stop command, UBLK_CMD_TRY_STOP_DEV, which only stops a
ublk device when it has no active openers.

Unlike UBLK_CMD_STOP_DEV, this command does not disrupt existing users.
New opens are blocked only after disk_openers has reached zero; if the
device is busy, the command returns -EBUSY and leaves it running.

The ub->block_open flag is used only to close a race with an in-progress
open and does not otherwise change open behavior.

Advertise support via the UBLK_F_SAFE_STOP_DEV feature flag.

Signed-off-by: Yoav Cohen <[email protected]>
Reviewed-by: Ming Lei <[email protected]>
@kawasaki
selftests: ublk: add stop command with --safe option
036fda2 
Add 'stop' subcommand to kublk utility that uses the new
UBLK_CMD_TRY_STOP_DEV command when --safe option is specified.
This allows stopping a device only if it has no active openers,
returning -EBUSY otherwise.

Also add test_generic_16.sh to test the new functionality.

Signed-off-by: Ming Lei <[email protected]>
@blktests-ci
Copy link
Author

blktests-ci bot commented Jan 12, 2026

Upstream branch: 623fb99
series: https://patchwork.kernel.org/project/linux-block/list/?series=1041208
version: 6

@blktests-ci blktests-ci bot added V6 and removed V5 V5-ci-pass labels Jan 12, 2026
@blktests-ci blktests-ci bot force-pushed the series/1037344=>linus-master branch from 408a6a3 to 036fda2 Compare January 12, 2026 13:44
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from f962a4d to 06634b5 Compare January 13, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V6-ci-pass V6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kawasaki @yoavcoh