Commit 8c606aa
authored
Update solo clone with build fix (#122)
Updates the `solo` clone to include
AlfioEmanueleFresta/solo@c12e6c7.
Fixes an occasional build error building `solo`:
```
make failed: Output { status: ExitStatus(unix_wait_status(512)), stdout: "cc -O2 -fdata-sections -ffunction-sections -fcommon -g -I../ -I./fido2/ -I./pc -I../pc -I./tinycbor/src -DAES256=1 -DSOLO_EXPERIMENTAL=1 -DDEBUG_LEVEL=1 -c -o pc/device.o pc/device.c\n", stderr: "pc/device.c: In function ‘device_init’:\npc/device.c:256:5: error: too many arguments to function ‘ctap_init’; expected 0, have 1\n 256 | ctap_init(1);\n | ^~~~~~~~~ ~\nIn file included from ./fido2/storage.h:10,\n from ./fido2/device.h:10,\n from pc/device.c:20:\n./fido2/ctap.h:389:6: note: declared here\n 389 | void ctap_init();\n | ^~~~~~~~~\nmake: *** [<builtin>: pc/device.o] Error 1\n" }
```
The root cause is commit
[e8d0ad5e7cf2f8bd5a57aae8e5e8b69d3816474c](AlfioEmanueleFresta/solo@e8d0ad5),
part of solokeys/solo1#121, which removes an
extra argument from `ctap_init` but didn't update `pc/device.c`.
Note upstreaming PR has been blocked for a while -
solokeys/solo1#577. IMO we should eventually
migrate to Solo2, with FIDO2 support, rather than spend more time on
solo1.1 parent 2199511 commit 8c606aa
1 file changed
+1
-1
lines changed- Dockerfile+3-3
- README.md+6-6
- SECURITY.md+3-3
- STABLE_VERSION+1-1
- docs/application-ideas.md+1-1
- docs/bootloader-mode.md+1-1
- docs/building.md+8-8
- docs/images/nucleo_board_connection.png
- docs/nucleo32-board.md+25
- docs/programming.md+11-11
- docs/solo-extras.md+3-3
- docs/tutorial-getting-started.md+21-21
- docs/udev.md+1-1
- fido2/ctap.c+3
- mkdocs.yml+1-1
- pc/device.c+1-1
- tools/requirements.txt+1-1
0 commit comments