guestfs: fix locale warnings in VM deployments

Fix "cannot change locale" SSH warnings by configuring locales
comprehensively across both new and existing VM deployments.

New VMs (virt-builder template):
- Add locales-all package for comprehensive locale support
- Configure en_US.UTF-8 during both image build and first boot
- Remove problematic dpkg-reconfigure command

Existing VMs (devconfig tasks):
- Install locales-all package if missing
- Configure /etc/default/locale and /etc/locale.gen files
- Generate and update locales with locale-gen and update-locale

This ensures en_US.UTF-8 locale is available at boot, eliminating
SSH warnings across all VM deployment scenarios.

Generated-by: Claude AI
Link: https://lore.kernel.org/r/20250820-guestfs-custom-image-fixes-v1-9-0fe1d69c3f33@samsung.com
Signed-off-by: Daniel Gomez <[email protected]>
Reviewed-by: Chuck Lever <[email protected]>

Author: dkruces

playbooks/roles/base_image/templates/virt-builder.j2

@@ -11,7 +11,7 @@ mkdir {{ target_dir }}
 copy-in {{ guestfs_distro_source_and_dest_file }}:{{ target_dir }}
 {% endif %}
 
-install sudo,qemu-guest-agent,python3,bash
+install sudo,qemu-guest-agent,python3,bash,locales-all
 run-command useradd {{ kdevops_uid }} -s /bin/bash -m kdevops
 append-line /etc/sudoers.d/kdevops:kdevops   ALL=(ALL)       NOPASSWD: ALL
 edit /etc/default/grub:s/^GRUB_CMDLINE_LINUX_DEFAULT=.*/GRUB_CMDLINE_LINUX_DEFAULT="console=ttyS0"/
@@ -63,9 +63,10 @@ uninstall cloud-init
 write /etc/default/locale:LANG=en_US.UTF-8
 append-line /etc/default/locale:LANGUAGE=en_US:en
 write /etc/locale.gen:en_US.UTF-8 UTF-8
+run-command locale-gen en_US.UTF-8
+run-command update-locale LANG=en_US.UTF-8
 firstboot-command locale-gen en_US.UTF-8
 firstboot-command update-locale LANG=en_US.UTF-8
-firstboot-command DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true dpkg-reconfigure -p low --force locales
 firstboot-command systemctl stop ssh
 firstboot-command systemctl start ssh
 

playbooks/roles/devconfig/tasks/main.yml

@@ -29,6 +29,48 @@
     dest: /etc/hostname
   tags: hostname
 
+- name: Ensure locales-all package is installed
+  become: true
+  become_flags: 'su - -c'
+  become_method: sudo
+  ansible.builtin.package:
+    name: locales-all
+    state: present
+  when:
+    - ansible_facts['os_family']|lower == 'debian'
+  tags: firstconfig
+
+- name: Configure en_US.UTF-8 locale files
+  become: true
+  become_flags: 'su - -c'
+  become_method: sudo
+  ansible.builtin.lineinfile:
+    path: "{{ item.path }}"
+    line: "{{ item.line }}"
+    create: true
+    mode: '0644'
+    owner: root
+    group: root
+  loop:
+    - { path: '/etc/default/locale', line: 'LANG=en_US.UTF-8' }
+    - { path: '/etc/default/locale', line: 'LANGUAGE=en_US:en' }
+    - { path: '/etc/locale.gen', line: 'en_US.UTF-8 UTF-8' }
+  when:
+    - ansible_facts['os_family']|lower == 'debian'
+  tags: firstconfig
+
+- name: Generate and update locales
+  become: true
+  become_flags: 'su - -c'
+  become_method: sudo
+  ansible.builtin.shell: |
+    locale-gen en_US.UTF-8
+    update-locale LANG=en_US.UTF-8
+  changed_when: true
+  when:
+    - ansible_facts['os_family']|lower == 'debian'
+  tags: firstconfig
+
 # Distro specific
 
 # Check and fix APT mirrors for Debian testing before installing dependencies